VR: VrUsageMonitor should use base::UmaHistogramCustomTimes |
|||||||
Issue descriptionThe code in VrUsageMonitor to update the session time historgram is templatized to ensure that the UMA_HISTOGRAM_CUSTOM_TIMES macro is instantiated separately for each possible SessionType. It would likely be more efficient to use base::UmaHistogramCustomTimes, which allows variable histogram names from a single callsite.
,
Feb 28 2018
,
Feb 28 2018
May as well assign to myself while I'm here. I'll probably address with a few other metrics cleanup at the same time.
,
Apr 17 2018
Moving out, will try to clean up this milestone.
,
Aug 1
,
Jan 18
(4 days ago)
VrUsageMonitor no longer exists. What is the new name? Also, is this specific to VR browsing or all of XR?
,
Jan 18
(4 days ago)
All of xr. In chrome/browser/vr/metrics/session_metrics_helper.cc, SessionTimerImpl is the templated class, which uses UMA_HISTOGRAM_CUSTOM_TIMES and templates to get different instances of each session type. Using base::UmaHistogramCustomTimes directly instead of the macro will avoid the templates and probably make this code easier to understand.
,
Jan 18
(4 days ago)
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by mthiesse@chromium.org
, Feb 28 2018