New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 789758 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

VR: VrUsageMonitor should use base::UmaHistogramCustomTimes

Project Member Reported by ymalik@chromium.org, Nov 29 2017

Issue description

The code in VrUsageMonitor to update the session time historgram is templatized  to ensure that the UMA_HISTOGRAM_CUSTOM_TIMES macro is instantiated separately for each possible SessionType.  

It would likely be more efficient  to use base::UmaHistogramCustomTimes, which allows variable histogram names from a single callsite.
 
P3 M65? Sounds like this needs to be re-prioritized :P
Labels: -M-65 M-67
Owner: billorr@chromium.org
May as well assign to myself while I'm here.  I'll probably address with a few other metrics cleanup at the same time.
Labels: -M-67 M-68
Moving out, will try to clean up this milestone.
Status: Assigned (was: Available)

Comment 6 by ddorwin@chromium.org, Jan 18 (4 days ago)

Cc: elalish@chromium.org samdrazin@chromium.org
Labels: -M-68
VrUsageMonitor no longer exists. What is the new name? Also, is this specific to VR browsing or all of XR?

Comment 7 by billorr@chromium.org, Jan 18 (4 days ago)

All of xr.  

In chrome/browser/vr/metrics/session_metrics_helper.cc, SessionTimerImpl is the templated class, which uses UMA_HISTOGRAM_CUSTOM_TIMES and templates to get different instances of each session type.

Using base::UmaHistogramCustomTimes directly instead of the macro will avoid the templates and probably make this code easier to understand.

Comment 8 by samdrazin@chromium.org, Jan 18 (4 days ago)

Cc: cassew@chromium.org
Labels: VR-metrics

Sign in to add a comment