New issue
Advanced search Search tips

Issue 789756 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug-Regression



Sign in to add a comment

5.9%-24.3% regression in media_perftests at 519003:519050

Project Member Reported by wolenetz@chromium.org, Nov 29 2017

Issue description

These 4 alert traces all look valid. There's no ref for media_perftests though, so perhaps something else changed. Starting a bisect.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Nov 29 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=789756

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=16d72992b7ff1c11907ca8bf0f9260b92f4c55cca005bf02bfd3f752d84ef15f


Bot(s) for this bug's original alert(s):

chromium-rel-mac11
chromium-rel-win8-dual
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Nov 30 2017

Cc: gab@chromium.org
Owner: gab@chromium.org
Status: Assigned (was: Untriaged)

=== Auto-CCing suspected CL author gab@chromium.org ===

Hi gab@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Gabriel Charette
  Commit : d4723a3dfd0215a72507d10ce0bd0e75f5f76bb6
  Date   : Fri Nov 24 00:11:18 2017
  Subject: Reland "Add MOCK_TIME mode to ScopedTaskEnvironment :)"

Bisect Details
  Configuration: win_8_perf_bisect
  Benchmark    : media_perftests
  Metric       : sinc_resampler_convolve/unoptimized_aligned
  Change       : 29.77% | 22308.3978953 -> 28950.7121778

Revision             Result                  N
chromium@519023      22308.4 +- 56.7278      6      good
chromium@519030      22275.0 +- 187.666      6      good
chromium@519031      22366.7 +- 85.1921      6      good
chromium@519032      29023.4 +- 424.513      6      bad       <--
chromium@519034      28921.5 +- 61.8939      6      bad
chromium@519037      29019.4 +- 349.056      6      bad
chromium@519050      28950.7 +- 104.827      6      bad

To Run This Test
  .\src\out\Release\media_perftests.exe --single-process-tests

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8961547589620064992


For feedback, file a bug with component Speed>Bisection
Cc: chrisha@chromium.org
Owner: fdoray@chromium.org
=> fdoray@, cc+=chrisha@ because gab@ is OoO
ping - is this issue resolved?

Comment 6 by gab@chromium.org, Feb 13 2018

Oh..! We have a better design in progress that should solve this issue but we're spread thin and it's still a month out or so... the fact that it also addressed a test perf regression had dropped off my mind.

Comment 7 by gab@chromium.org, Feb 13 2018

Cc: fdoray@chromium.org
Components: Internals
Owner: gab@chromium.org

Comment 8 by fdoray@chromium.org, Feb 14 2018

Labels: -Pri-2 Pri-3
It is important to note that the blamed CL only affects the testing environment, so this isn't a regression affecting real users. Lowering priority to 3.
Components: Internals>Media
Components: -Internals

Sign in to add a comment