New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 789751 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

[MD extensions] extend unit test

Project Member Reported by dschuyler@chromium.org, Nov 29 2017

Issue description

Follow-up on unit tests for LGTM comment in
https://chromium-review.googlesource.com/c/chromium/src/+/798123

(This bug is a todo/reminder).
 
Cc: dschuyler@chromium.org
 Issue 789902  has been merged into this issue.
Status: Started (was: Assigned)
CL at https://chromium-review.googlesource.com/c/chromium/src/+/807448
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf54b51cf5f2546ecfb7ad6a880ebf45fddc02aa

commit bf54b51cf5f2546ecfb7ad6a880ebf45fddc02aa
Author: Dave Schuyler <dschuyler@chromium.org>
Date: Wed Dec 06 00:41:21 2017

[MD extensions] browser test retrying extensions load

This CL adds a test for retrying the load of an extension that had errors.
Both a retry that fails and a retry that succeeds are tested.
This is a follow-up for CL 798123.

Bug:  789751 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I161f35127d5c37769d6c5e577c2e7d6689dbb482
Reviewed-on: https://chromium-review.googlesource.com/807448
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521920}
[modify] https://crrev.com/bf54b51cf5f2546ecfb7ad6a880ebf45fddc02aa/chrome/browser/resources/md_extensions/service.js
[modify] https://crrev.com/bf54b51cf5f2546ecfb7ad6a880ebf45fddc02aa/chrome/test/data/webui/extensions/cr_extensions_browsertest.js
[modify] https://crrev.com/bf54b51cf5f2546ecfb7ad6a880ebf45fddc02aa/chrome/test/data/webui/extensions/extension_load_error_test.js
[modify] https://crrev.com/bf54b51cf5f2546ecfb7ad6a880ebf45fddc02aa/chrome/test/data/webui/extensions/test_service.js

Status: Fixed (was: Started)

Sign in to add a comment