New issue
Advanced search Search tips

Issue 789738 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Replace LazyInstance::operator== with an explicit IsCreated() method.

Project Member Reported by lukasza@chromium.org, Nov 29 2017

Issue description

Let's replace LazyInstance::operator== with an explicit IsCreated() method.

The LazyInstance::operator== removed by this CL is undesirable, because
1) it didn't have a corresponding operator!=
2) it was only used to compare against nullptr
   (i.e. to check if the lazy instance was created already or not)
 
Status: Started (was: Assigned)
WIP CL @ https://crrev.com/c/792124
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d3e1913b13ad0c01fc499e317ce8ec6402350699

commit d3e1913b13ad0c01fc499e317ce8ec6402350699
Author: Lukasz Anforowicz <lukasza@chromium.org>
Date: Wed Dec 06 19:44:27 2017

Replace LazyInstance::operator== with an explicit IsCreated() method.

The LazyInstance::operator== removed by this CL is undesirable, because
1) it didn't have a corresponding operator!=
2) it was only used to compare against nullptr
   (i.e. to check if the lazy instance was created already or not)

This CL removes LazyInstance::operator== and replaces it with
LazyInstance::IsCreated() method.

Bug:  789738 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Idfbb4a9f0699cb10f3f861860070b7f316a16ad6
Reviewed-on: https://chromium-review.googlesource.com/792124
Reviewed-by: Nick Carter <nick@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Ɓukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522172}
[modify] https://crrev.com/d3e1913b13ad0c01fc499e317ce8ec6402350699/base/lazy_instance.h
[modify] https://crrev.com/d3e1913b13ad0c01fc499e317ce8ec6402350699/base/lazy_instance_unittest.cc
[modify] https://crrev.com/d3e1913b13ad0c01fc499e317ce8ec6402350699/base/logging.cc
[modify] https://crrev.com/d3e1913b13ad0c01fc499e317ce8ec6402350699/base/threading/sequenced_worker_pool.cc
[modify] https://crrev.com/d3e1913b13ad0c01fc499e317ce8ec6402350699/chrome/browser/after_startup_task_utils.cc
[modify] https://crrev.com/d3e1913b13ad0c01fc499e317ce8ec6402350699/chrome/browser/chromeos/app_mode/kiosk_app_manager.cc
[modify] https://crrev.com/d3e1913b13ad0c01fc499e317ce8ec6402350699/chrome/browser/devtools/devtools_ui_bindings.cc
[modify] https://crrev.com/d3e1913b13ad0c01fc499e317ce8ec6402350699/chrome/browser/devtools/devtools_window.cc
[modify] https://crrev.com/d3e1913b13ad0c01fc499e317ce8ec6402350699/chrome/browser/devtools/devtools_window_testing.cc
[modify] https://crrev.com/d3e1913b13ad0c01fc499e317ce8ec6402350699/components/crash/content/browser/crash_dump_observer_android.cc
[modify] https://crrev.com/d3e1913b13ad0c01fc499e317ce8ec6402350699/content/browser/browser_main_runner.cc
[modify] https://crrev.com/d3e1913b13ad0c01fc499e317ce8ec6402350699/content/browser/browser_thread_impl.cc
[modify] https://crrev.com/d3e1913b13ad0c01fc499e317ce8ec6402350699/content/browser/devtools/devtools_agent_host_impl.cc
[modify] https://crrev.com/d3e1913b13ad0c01fc499e317ce8ec6402350699/content/browser/devtools/render_frame_devtools_agent_host.cc
[modify] https://crrev.com/d3e1913b13ad0c01fc499e317ce8ec6402350699/content/common/content_ipc_logging.cc
[modify] https://crrev.com/d3e1913b13ad0c01fc499e317ce8ec6402350699/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/d3e1913b13ad0c01fc499e317ce8ec6402350699/content/test/layouttest_support.cc
[modify] https://crrev.com/d3e1913b13ad0c01fc499e317ce8ec6402350699/ios/web/web_thread_impl.cc
[modify] https://crrev.com/d3e1913b13ad0c01fc499e317ce8ec6402350699/ui/gfx/font_list.cc

Status: Fixed (was: Started)

Sign in to add a comment