Design doc: https://docs.google.com/document/d/1ww4AGMXxgGc25l1VIZkTPblJWrRe4kStGzDHmHtFCpo/edit
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8a0e9ba9f3becb1492b462c57c63bc245c7e8508 commit 8a0e9ba9f3becb1492b462c57c63bc245c7e8508 Author: Eugene But <eugenebut@google.com> Date: Mon Dec 11 22:21:21 2017 Added DownloadTask::GetHttpCode() method. This method will be user for reporting Download.IOSDownloadPassKitResult UMA metric. Bug: 789735 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ic39d5ea1869dfb4e7f45e0ffa2902829a2e09a6d Reviewed-on: https://chromium-review.googlesource.com/817950 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by: Gregory Chatzinoff <gchatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#523232} [modify] https://crrev.com/8a0e9ba9f3becb1492b462c57c63bc245c7e8508/ios/web/download/download_inttest.mm [modify] https://crrev.com/8a0e9ba9f3becb1492b462c57c63bc245c7e8508/ios/web/download/download_task_impl.h [modify] https://crrev.com/8a0e9ba9f3becb1492b462c57c63bc245c7e8508/ios/web/download/download_task_impl.mm [modify] https://crrev.com/8a0e9ba9f3becb1492b462c57c63bc245c7e8508/ios/web/download/download_task_impl_unittest.mm [modify] https://crrev.com/8a0e9ba9f3becb1492b462c57c63bc245c7e8508/ios/web/public/download/download_task.h [modify] https://crrev.com/8a0e9ba9f3becb1492b462c57c63bc245c7e8508/ios/web/public/test/fakes/fake_download_task.h [modify] https://crrev.com/8a0e9ba9f3becb1492b462c57c63bc245c7e8508/ios/web/public/test/fakes/fake_download_task.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/083b4ff273535766cd724ec442cc5f2b7397580b commit 083b4ff273535766cd724ec442cc5f2b7397580b Author: Eugene But <eugenebut@google.com> Date: Wed Dec 13 23:54:24 2017 Report Download.IOSDownloadPassKitResult UMA. This CL implements exising metrics reported by CRWPassKitDownloader. UMA constants are duplicated, which is fine because old constants will be removed along with CRWPassKitDownloader class. Bug: 789735 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I455e9247ed4493dbc7f3d59a74e1f5806e167956 Reviewed-on: https://chromium-review.googlesource.com/822528 Reviewed-by: Gregory Chatzinoff <gchatz@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#523931} [modify] https://crrev.com/083b4ff273535766cd724ec442cc5f2b7397580b/ios/chrome/browser/download/pass_kit_tab_helper.h [modify] https://crrev.com/083b4ff273535766cd724ec442cc5f2b7397580b/ios/chrome/browser/download/pass_kit_tab_helper.mm [modify] https://crrev.com/083b4ff273535766cd724ec442cc5f2b7397580b/ios/chrome/browser/download/pass_kit_tab_helper_unittest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/76f7a6b5a791a1c930ecd9609766a6be4d1cb9ed commit 76f7a6b5a791a1c930ecd9609766a6be4d1cb9ed Author: Eugene But <eugenebut@google.com> Date: Tue Dec 19 06:53:09 2017 Added Download.IOSPresentAddPassesDialogResult metric. Bug: 789735 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I23f6210c095834d36c1fc976c3924b4398a80f1e Reviewed-on: https://chromium-review.googlesource.com/824948 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by: Mark Pearson <mpearson@chromium.org> Reviewed-by: Gregory Chatzinoff <gchatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#524960} [modify] https://crrev.com/76f7a6b5a791a1c930ecd9609766a6be4d1cb9ed/ios/chrome/browser/ui/download/pass_kit_coordinator.h [modify] https://crrev.com/76f7a6b5a791a1c930ecd9609766a6be4d1cb9ed/ios/chrome/browser/ui/download/pass_kit_coordinator.mm [modify] https://crrev.com/76f7a6b5a791a1c930ecd9609766a6be4d1cb9ed/ios/chrome/browser/ui/download/pass_kit_coordinator_unittest.mm [modify] https://crrev.com/76f7a6b5a791a1c930ecd9609766a6be4d1cb9ed/tools/metrics/histograms/enums.xml [modify] https://crrev.com/76f7a6b5a791a1c930ecd9609766a6be4d1cb9ed/tools/metrics/histograms/histograms.xml
Comment 1 by eugene...@chromium.org
, Nov 29 2017