New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 789715 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Reset state map in ImageAnimationController on navigations

Project Member Reported by khushals...@chromium.org, Nov 29 2017

Issue description

The map can right now become unbounded because the state is maintained across commits. We should clear it on navigations, since we don't need to resume an animation after that.
 
Cc: sohanjg@chromium.org
Labels: -Type-Bug Type-Task
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d625d9e6abfc411096059057015d4b0612d1a32

commit 1d625d9e6abfc411096059057015d4b0612d1a32
Author: sohan <sohan.jyoti@huawei.com>
Date: Mon Mar 12 21:57:08 2018

cc: Reset ImageAnimationController maps.

This clears animation state maps maintained in IAC, on navigaion.
The navigaiton signal is recieved from LTH and the entries without
driver/recordings are cleared on activation. A new LTHI func is
introduced ::DidNavigate, which takes care of clearing both animation
and decode cache.

BUG= 789715 

Change-Id: I8c6b37a6c2783ff727931e9812ff41c4321ab855
Reviewed-on: https://chromium-review.googlesource.com/919265
Commit-Queue: Sohan Jyoti Ghosh <sohan.jyoti@huawei.com>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542613}
[modify] https://crrev.com/1d625d9e6abfc411096059057015d4b0612d1a32/cc/trees/image_animation_controller.cc
[modify] https://crrev.com/1d625d9e6abfc411096059057015d4b0612d1a32/cc/trees/image_animation_controller.h
[modify] https://crrev.com/1d625d9e6abfc411096059057015d4b0612d1a32/cc/trees/image_animation_controller_unittest.cc
[modify] https://crrev.com/1d625d9e6abfc411096059057015d4b0612d1a32/cc/trees/layer_tree_host.cc
[modify] https://crrev.com/1d625d9e6abfc411096059057015d4b0612d1a32/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/1d625d9e6abfc411096059057015d4b0612d1a32/cc/trees/layer_tree_host_impl.h

Status: Fixed (was: Assigned)

Sign in to add a comment