[MD extensions] Retry button not bringing up error dialog. |
|||
Issue descriptionIn the chrome://extensions page (with md-extensions flag enabled), load the* unpacked extension (using the load unpacked button). When the manifest error dialog comes up, press Retry. Problem: it doesn't seem to actually retry, the dialog closes. *Use the same extension form Issue 788926
,
Nov 29 2017
,
Nov 29 2017
,
Nov 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4db037c893d59ea11d75be89b9847ad708dad012 commit 4db037c893d59ea11d75be89b9847ad708dad012 Author: Dave Schuyler <dschuyler@chromium.org> Date: Thu Nov 30 00:51:25 2017 [MD extensions] fix Retry button on manifest error dialog This CL shows a paper spinner and disables the Retry button while retrying to load the extension. It will then refresh the contents of the dialog with the new error results. Bug: 789700 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I72b4f2fcf2e10724796daab82ab5b730bc6a741a Reviewed-on: https://chromium-review.googlesource.com/798123 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#520351} [modify] https://crrev.com/4db037c893d59ea11d75be89b9847ad708dad012/chrome/browser/resources/md_extensions/load_error.html [modify] https://crrev.com/4db037c893d59ea11d75be89b9847ad708dad012/chrome/browser/resources/md_extensions/load_error.js
,
Nov 30 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by dschuyler@chromium.org
, Nov 29 2017Status: Started (was: Untriaged)