Issue 789684 link

Starred by 1 user

Issue metadata

Status:	Verified
Owner:	einbinder@chromium.org
Closed:	Nov 2017
Components:	Platform>DevTools>Platform
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	3
Type:	Bug

DevTools: Network.getCookies gives expires: 0 instead of expires: -1

Project Member Reported by einbinder@chromium.org, Nov 29 2017

Issue description

For cookies with no set expiration, Network.getCookies is returning an expires value of 0. If this value is passed back into Network.setCookies the cookie immediately expires. It looks like we use -1 to represent a null expiry date in Network.setCookies.

Project Member

Comment 1 by bugdroid1@chromium.org, Nov 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/37e0cc6df89b402c25ce4f15884b55810a649fbb

commit 37e0cc6df89b402c25ce4f15884b55810a649fbb
Author: Joel Einbinder <einbinder@chromium.org>
Date: Thu Nov 30 00:37:30 2017

DevTools: Network.getCookies should return -1 for null expiry dates

Bug:  789684 
Change-Id: I0b0f387c2d95fa5ac01fc28a11e917c55bb673c5
Reviewed-on: https://chromium-review.googlesource.com/797914
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520341}
[modify] https://crrev.com/37e0cc6df89b402c25ce4f15884b55810a649fbb/content/browser/devtools/protocol/network_handler.cc
[modify] https://crrev.com/37e0cc6df89b402c25ce4f15884b55810a649fbb/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/cookies-protocol-test-expected.txt
[modify] https://crrev.com/37e0cc6df89b402c25ce4f15884b55810a649fbb/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/cookies-protocol-test.js

Comment 2 by einbinder@chromium.org, Nov 30 2017

Status: Verified (was: Assigned)

►

Issue 789684 link

Issue metadata

DevTools: Network.getCookies gives expires: 0 instead of expires: -1

Issue description

Comment 1 by bugdroid1@chromium.org, Nov 30 2017

Comment 1 Deleted

Comment 2 by einbinder@chromium.org, Nov 30 2017

Comment 2 Deleted

Sign in to add a comment