New issue
Advanced search Search tips

Issue 789679 link

Starred by 0 users
Status: Assigned
Owner:
hongchan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 2
Type: Bug


Show other hotlists

Hotlists containing this issue:
XXX


Sign in to add a comment

Do not access other Oilpan-managed object in class destructors in modules/webaudio

Project Member Reported by hongchan@chromium.org, Nov 29 2017 
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests%20(with%20patch)&showAllRuns=true&tests=webaudio%2Finternals%2Faudiosource-premature-gc.html

We do not know when this started, but it seems like flaky in rare cases. We should suppress the flakiness and handle it later.

Comment 1 by hongchan@chromium.org, Nov 29 2017 

This is not flaky and reproducible on OSX.

run-webkit-test.py webaudio/internals/audiosource-premature-gc.html --iteration=6

It crashes on every 6th iteration.

Comment 2 by hongchan@chromium.org, Nov 29 2017

Labels: -Pri-3 OS-Mac Pri-1

Comment 3 by hongchan@chromium.org, Nov 29 2017 

Note: this doesn't crash on browser or content_shell.

Comment 4 by hongchan@chromium.org, Nov 29 2017

Labels: -Pri-1 -OS-Mac Pri-3
My local verification was based on the CL https://chromium-review.googlesource.com/c/chromium/src/+/779862, but it does not crash on ToT.

Please ignore #1 and #3. I am also lowering the priority to 3.

Comment 5 by hongchan@chromium.org, Nov 29 2017 

With the iteration = 100, the test passes on Mac and Linux.

Comment 6 by hongchan@chromium.org, Dec 1 2017

Labels: -Pri-3 -Test-Layout OS-Android OS-Chrome OS-Fuchsia OS-Linux OS-Mac Pri-2
Owner: hongchan@chromium.org
Status: Assigned (was: Available)
Summary: Do not access other Oilpan-managed object in class destructors in modules/webaudio (was: webaudio/internal/audiosource-premature-gc.html is flaky)
I change the title to track the bigger issue in WebAudio. haraken@ pointed out the destruction process in BaseAudioContext is incorrect from Oilpan-GC perspective:
https://chromium-review.googlesource.com/c/chromium/src/+/779862#message-3b8e3ea8e9c6c7d04a5fe7edfcc4d3e4ff899e4f

We have to assess all class destructors in module/webaudio to find out if it accesses other Oilpan-managed objects.
►

Sign in to add a comment