New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 789675 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Chrome , Mac
Pri: 2
Type: Bug

Blocking:
issue 780164


Show other hotlists

Hotlists containing this issue:
XXX


Sign in to add a comment

Update illustration for drag-to-install

Project Member Reported by bettes@chromium.org, Nov 29 2017

Issue description

The neon green puzzle piece is just a placeholder image. Please point me to the assets being used so i can re-export and swap assets. 
 
Owner: bettes@chromium.org
Back to bettes@ based on #2.

bettes@, if you'd like me to make the change, just let me know which icon and color you'd like and change the Owner back to me.

Comment 3 by bettes@chromium.org, Dec 11 2017

I'll provide a size and assign it back to you when ready
More info from chatting with Alan:

Change the extensions drag and drop to more closely resemble the (empty/no downloads) downloads page drag and drop page

Make scrim a little more opaque
   opacity: 0.9;
   background-color: #f1f1f1;

Change the teal to icon color to color: var(--paper-grey-600);

Make font match #no-downloads in downloads (font size, weight, and color).

Change the iron-icon margin bottom to margin-bottom: 16px;

Owner: dschuyler@chromium.org
Status: Started (was: Assigned)
Here's a portion of the fixed screen
dropToInstall.png
9.4 KB View Download
Blocking: 780164
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b47df6d9d7f4cf3e5ba2a493b8a1e80aebeb3c4

commit 2b47df6d9d7f4cf3e5ba2a493b8a1e80aebeb3c4
Author: Dave Schuyler <dschuyler@chromium.org>
Date: Wed Dec 13 22:18:29 2017

[MD extensions] change the drop-to-install colors and font

This Cl updates some CSS to change the colors and font style as requested
by bettes@.

Bug:  789675 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I4f0c2c91b51e77721ad2b0036ff6c2319a053043
Reviewed-on: https://chromium-review.googlesource.com/822373
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523906}
[modify] https://crrev.com/2b47df6d9d7f4cf3e5ba2a493b8a1e80aebeb3c4/chrome/browser/resources/md_extensions/drop_overlay.html

Labels: Merge-Request-64
Project Member

Comment 10 by sheriffbot@chromium.org, Dec 14 2017

Labels: -Merge-Request-64 Hotlist-Merge-Review Merge-Review-64
This bug requires manual review: M64 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-64 Merge-Approved-64
Approving for M64 merge. Branch:3282
Project Member

Comment 12 by bugdroid1@chromium.org, Dec 15 2017

Labels: -merge-approved-64 merge-merged-3282
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d04d79ed0e9681162b25ea9045b768e9733afa88

commit d04d79ed0e9681162b25ea9045b768e9733afa88
Author: Dave Schuyler <dschuyler@chromium.org>
Date: Fri Dec 15 20:07:01 2017

[MD extensions] change the drop-to-install colors and font

This Cl updates some CSS to change the colors and font style as requested
by bettes@.

Bug:  789675 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I4f0c2c91b51e77721ad2b0036ff6c2319a053043
Reviewed-on: https://chromium-review.googlesource.com/822373
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#523906}(cherry picked from commit 2b47df6d9d7f4cf3e5ba2a493b8a1e80aebeb3c4)
Reviewed-on: https://chromium-review.googlesource.com/830626
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/branch-heads/3282@{#242}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
[modify] https://crrev.com/d04d79ed0e9681162b25ea9045b768e9733afa88/chrome/browser/resources/md_extensions/drop_overlay.html

Status: Fixed (was: Started)

Sign in to add a comment