New issue
Advanced search Search tips

Issue 789674 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug


Show other hotlists

Hotlists containing this issue:
XXX


Sign in to add a comment

ios-simulator keeps flaking in gn

Project Member Reported by a...@chromium.org, Nov 29 2017

Issue description

I'm writing CLs that are unrelated to iOS, like https://crrev.com/c/797677 and https://crrev.com/c/794171 . The ios-simulator trybot keeps dying:

ERROR at //v8/BUILD.gn:126:7: Duplicate build argument declaration.
      [ "//test/cctest/test-experimental-extra.js" ]
      ^--------------------------------------------
Here you're declaring an argument that was already declared elsewhere.
You can only declare each argument once in the entire build so there is one
canonical place for documentation and the default value. Either move this
argument to the build config file (for visibility everywhere) or to a .gni file
that you "import" from the files where you need it (preferred).
See //ios/BUILD.gn:15:41: Previous declaration.
  v8_experimental_extra_library_files = []
                                        ^
See also "gn help buildargs" for more on how build arguments work.
See //content/public/common/BUILD.gn:43:22: which caused the file to be included.
  public_configs = [ "//v8:external_startup_data" ]
                     ^---------------------------
GN gen failed: 1

This is extremely problematic. For example, on https://crrev.com/c/794171, ios-simulator has failed SIX TIMES in a row, and is blocking landing.

Searching for this text yields https://crrev.com/c/561922. kmilka@ is gone, so assigning to a reviewer.
 
Cc: rohitrao@chromium.org
Owner: ----
I don't know anything about v8_experimental_extra_library_files. I don't see how the CL you linked (https://crrev.com/c/561922) is related to that.

+rohitrao who might be able to help with ios-simulator

(Although I don't know why v8 stuff would be affecting iOS build).

Comment 2 by a...@chromium.org, Nov 29 2017

https://chromium-review.googlesource.com/c/chromium/src/+/561922#message-2762bbaa0decd6b71d128e72db7b3551056ab6a0 has a comment about how his ios-simulator test fails in exactly the way that I'm describing here.
I believe the issue is that https://chromium-review.googlesource.com/c/chromium/src/+/794171 adds a new unittest that depends on //content, so that needs to go into the !iOS block in the GN file.

The other referenced CL depends on the first, so it's getting hit by that even though it doesn't appear to change any GN files directly.

+CC sylvain to see if we can make the error message more obvious, or at least add some comments to the GN file to make it clear which block a new test target should go in.

Comment 4 by a...@chromium.org, Nov 29 2017

Rohit: Yikes! Thanks for the pointer.
Cc: sdefresne@chromium.org
(Actually +CC Sylvain.  I'll also follow up with him when he's back.)

Comment 6 by a...@chromium.org, Nov 29 2017

Status: WontFix (was: Untriaged)
Marking as WontFix as it's not actually a bot flake.

Sign in to add a comment