New issue
Advanced search Search tips

Issue 789672 link

Starred by 1 user
Status: Verified
Owner:
ntfschr@chromium.org
Closed: Nov 2017
Cc:
changwan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocked on:
issue 782848

Show other hotlists

Hotlists containing this issue:
XXX


Sign in to add a comment

Override annotations for OMR1 classes

Project Member Reported by ntfschr@chromium.org, Nov 29 2017 
Now that we're compiling the glue layer against OMR1, we should add @Override for the new methods (initSafeBrowsing, setSafeBrowsingWhitelist, getSafeBrowsingPrivacyPolicyUrl).

Not needed before branch, but I'll try to land.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36839d9e34a51551a99ce218912d723994074aaf

commit 36839d9e34a51551a99ce218912d723994074aaf
Author: Nate Fischer <ntfschr@chromium.org>
Date: Wed Nov 29 22:50:30 2017

AW: add @Override annotations for OMR1 APIs

This fixes some TODOs related to missing @Override annotations for the
OMR1 APIs.

Bug:  789672 
Test: ninja system_webview_google_apk (fewer compile warnings)
Change-Id: Id2417b9fbb6c73eb466f1fae5d4ac3a8f434e5eb
Reviewed-on: https://chromium-review.googlesource.com/797251
Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520284}
[modify] https://crrev.com/36839d9e34a51551a99ce218912d723994074aaf/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java

Comment 2 by ntfschr@chromium.org, Nov 29 2017

Cc: changwan@chromium.org
Status: Fixed (was: Assigned)

Comment 3 by ntfschr@chromium.org, Aug 24

Status: Verified (was: Fixed)
Bulk edit: marking stale 'fixed' bugs as 'verified' since they don't need verification at this point.
►

Sign in to add a comment