New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 789662 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Chrome , Mac
Pri: 2
Type: Bug


Show other hotlists

Hotlists containing this issue:
XXX


Sign in to add a comment

"Chrome apps" text too large & card margins too small

Project Member Reported by bettes@chromium.org, Nov 29 2017

Issue description

Align size of text and card placement with chrome settings. 

1. Chrome Apps text looks 1pt too big
2. The spacing between 2 cards is too small on extensions. Please match with settings. See screenshot
 
Screen Shot 2017-11-29 at 12.10.48 PM.png
40.4 KB View Download

Comment 1 by dpa...@chromium.org, Nov 29 2017

Owner: ----
Status: Available (was: Assigned)
Owner: dschuyler@chromium.org
Status: Started (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f6e1afd45ef5780146f6f94c7c75c1ba7b86938c

commit f6e1afd45ef5780146f6f94c7c75c1ba7b86938c
Author: Dave Schuyler <dschuyler@chromium.org>
Date: Thu Nov 30 03:05:21 2017

[MD extensions] style Chrome Apps label after settings section titles

This CL changes the text styling and spacing around the Chrome Apps label
in the MD extensions page so that it is like the section titles in the
MD settings page. Also changes the element from <h1> to <h2>.

Bug:  789662 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I9b85bd18253774069e801a9ac313785038594a79
Reviewed-on: https://chromium-review.googlesource.com/798067
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520404}
[modify] https://crrev.com/f6e1afd45ef5780146f6f94c7c75c1ba7b86938c/chrome/browser/resources/md_extensions/item_list.html
[modify] https://crrev.com/f6e1afd45ef5780146f6f94c7c75c1ba7b86938c/chrome/browser/resources/settings/settings_page/settings_section.html
[modify] https://crrev.com/f6e1afd45ef5780146f6f94c7c75c1ba7b86938c/ui/webui/resources/cr_elements/shared_vars_css.html

Status: Fixed (was: Started)
Labels: Needs-Feedback
dschuyler@ -- Could you please help us by providing the steps to verify the fix from Chrome-TE's end.

Attached the screencast of the latest UI in chrome://extensions screen on Mac 10.12.6.

Thanks in advance.
789662.mov
13.9 MB Download
@6 I'll try. In #0 there is an image with 'Actual' on the left and 'Expected' on the right. After the fix, the space around and font of "Chrome Apps" should look like the right side 'Expected'.

Another way of saying that is that there should be 21px above the "Chrome Apps" text and 12px below that text. The text itself should be 13 point (13px). Does that help?

Sign in to add a comment