MD extensions in "developer mode" should clip URLs in "Inspect view" regardless of protocol
Reported by
woxxom@gmail.com,
Nov 29 2017
|
|||||||||
Issue descriptionGoogle Chrome 64.0.3280.0 (Official Build) canary (64-bit) ======================================== 1. install a devtools extension e.g. Storage Area Explorer https://chrome.google.com/webstore/detail/storage-area-explorer/ocfjjjjhkpapocigimmppepjgfdecjkb 2. open chrome://extensions page 3. enable "Developer mode" in the top-right corner 4. open devtools on this page (Ctrl-Shift-I or by right-clicking the page, then Inspect) Expected: the "Inspected view" area doesn't overflow Observed: the "Inspected view" area overflows and covers other items if present, the displayed URL is chrome-devtools://devtools/bundled/inspector.html?remoteBase=https://chrome-devtools-frontend.appspot.com/serve_file/@12d6a1a2daf69e7fed839a65b0d1284021056b6a/&can_dock=true&dockSide=undocked&experiments=true (iframe), ======================================== The relevant code in computeInspectableViewLabel() doesn't check for any URL protocol except for chrome-extension:// https://cs.chromium.org/chromium/src/chrome/browser/resources/md_extensions/item_util.js?l=111&rcl=3ffc2457afa5d1c2d6450c40805fc13863a67355 Last relevant CL is r455099
,
Dec 1 2017
,
Dec 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4ff73a7945b89f4971734dc634ac2885269f5fa3 commit 4ff73a7945b89f4971734dc634ac2885269f5fa3 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Tue Dec 05 03:15:07 2017 [MD Extensions] Fix long inspect views on card rendering Inspectable views can have any url, including some maddeningly long ones. We need to ensure that these render appropriately on the extension's card in the main view of the chrome://extensions page. Make the following changes: - Ensure that the inspect views section does not grow beyond the content area. - Ensure that the "Inspect views" and "n more..." are always visible - Adjust the overflow for the shown inspectable view to be hidden behind ellipses, and have the title text have the full label. Bug: 789655 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Icb6b769ed96c5775ea34a62eb15b89dbf625d124 Reviewed-on: https://chromium-review.googlesource.com/802095 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#521601} [modify] https://crrev.com/4ff73a7945b89f4971734dc634ac2885269f5fa3/chrome/browser/resources/md_extensions/item.html [modify] https://crrev.com/4ff73a7945b89f4971734dc634ac2885269f5fa3/chrome/browser/resources/md_extensions/item.js
,
Dec 6 2017
Verified the issue on Windows-7 and Mac OS 10.12.6 using chrome latest Canary M65-65.0.3286.0 by following steps mentioned in the original comment. Observed that MD extensions in "developer mode" URLs are displaying in "Inspect view" as expected. Please find the screen shot for reference. Linux - Due to build failure(#65.0.3286.0) unable to check in Linux. Will check and update the Linux behaviour and Verified labels once build is available. Thank you!
,
Dec 6 2017
This should be fixed. woxxom@, let us know if you find any other weirdness.
,
Dec 8 2017
,
Dec 13 2017
,
Dec 14 2017
This bug requires manual review: M64 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 15 2017
Approving merge to M64. Branch:3282
,
Dec 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/383c24958e2e1e493b0adac3a0e77bed71a07d06 commit 383c24958e2e1e493b0adac3a0e77bed71a07d06 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Sat Dec 16 01:45:17 2017 [MD Extensions] Fix long inspect views on card rendering Inspectable views can have any url, including some maddeningly long ones. We need to ensure that these render appropriately on the extension's card in the main view of the chrome://extensions page. Make the following changes: - Ensure that the inspect views section does not grow beyond the content area. - Ensure that the "Inspect views" and "n more..." are always visible - Adjust the overflow for the shown inspectable view to be hidden behind ellipses, and have the title text have the full label. Bug: 789655 TBR=rdevlin.cronin@chromium.org (cherry picked from commit 4ff73a7945b89f4971734dc634ac2885269f5fa3) Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Icb6b769ed96c5775ea34a62eb15b89dbf625d124 Reviewed-on: https://chromium-review.googlesource.com/802095 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#521601} Reviewed-on: https://chromium-review.googlesource.com/830490 Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/branch-heads/3282@{#251} Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840} [modify] https://crrev.com/383c24958e2e1e493b0adac3a0e77bed71a07d06/chrome/browser/resources/md_extensions/item.html [modify] https://crrev.com/383c24958e2e1e493b0adac3a0e77bed71a07d06/chrome/browser/resources/md_extensions/item.js
,
Dec 20 2017
Verified the issue on Windows-7, Ubuntu 14.04 and Mac OS 10.12.6 using chrome latest Beta M64-64.0.3282.39 and as per comment #4 verified in latest canary #65.0.3299.0 by following steps mentioned in the original comment. Observed that MD extensions in "developer mode" URLs are displaying in "Inspect view" as expected.Hence adding TE-Verified label. Please find the screen shot for reference. Thank You! |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by rdevlin....@chromium.org
, Nov 30 2017Owner: rdevlin....@chromium.org
Status: Started (was: Unconfirmed)