.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/56204115e9a81654987d9a04720b6b7d641fa90b commit 56204115e9a81654987d9a04720b6b7d641fa90b Author: Robert Hogan <robhogan@gmail.com> Date: Thu Nov 30 00:29:07 2017 Remove unnecessary uses of |this->| in core/layout (1 of 3) The Blink Rename has made most uses of this-> unnecessary. The relevant variable names no longer clash with the getters. Bug: 789653 Change-Id: Ia08ed4c853c810a605a6f8756b4ef7037283f5e8 Reviewed-on: https://chromium-review.googlesource.com/797452 Commit-Queue: Robert Hogan <robhogan@gmail.com> Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#520334} [modify] https://crrev.com/56204115e9a81654987d9a04720b6b7d641fa90b/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp [modify] https://crrev.com/56204115e9a81654987d9a04720b6b7d641fa90b/third_party/WebKit/Source/core/layout/LayoutBox.h [modify] https://crrev.com/56204115e9a81654987d9a04720b6b7d641fa90b/third_party/WebKit/Source/core/layout/LayoutEmbeddedContent.cpp [modify] https://crrev.com/56204115e9a81654987d9a04720b6b7d641fa90b/third_party/WebKit/Source/core/layout/LayoutInline.cpp [modify] https://crrev.com/56204115e9a81654987d9a04720b6b7d641fa90b/third_party/WebKit/Source/core/layout/LayoutObject.cpp [modify] https://crrev.com/56204115e9a81654987d9a04720b6b7d641fa90b/third_party/WebKit/Source/core/layout/LayoutRubyRun.cpp [modify] https://crrev.com/56204115e9a81654987d9a04720b6b7d641fa90b/third_party/WebKit/Source/core/layout/LayoutTableCell.cpp [modify] https://crrev.com/56204115e9a81654987d9a04720b6b7d641fa90b/third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2e85adbbf9239ee66ca736fb5f4ab35b8678bff4 commit 2e85adbbf9239ee66ca736fb5f4ab35b8678bff4 Author: Robert Hogan <robhogan@gmail.com> Date: Thu Nov 30 20:04:34 2017 Remove unnecessary uses of |this->| in core/paint The Blink Rename has made most uses of this-> unnecessary. The relevant variable names no longer clash with the getters. Bug: 789653 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I5386997583eee778e5afc2b9718f62f3e814b5d4 Reviewed-on: https://chromium-review.googlesource.com/798031 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Robert Hogan <robhogan@gmail.com> Cr-Commit-Position: refs/heads/master@{#520653} [modify] https://crrev.com/2e85adbbf9239ee66ca736fb5f4ab35b8678bff4/third_party/WebKit/Source/core/paint/PaintInvalidationCapableScrollableArea.cpp [modify] https://crrev.com/2e85adbbf9239ee66ca736fb5f4ab35b8678bff4/third_party/WebKit/Source/core/paint/PaintLayer.cpp [modify] https://crrev.com/2e85adbbf9239ee66ca736fb5f4ab35b8678bff4/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp [modify] https://crrev.com/2e85adbbf9239ee66ca736fb5f4ab35b8678bff4/third_party/WebKit/Source/core/paint/PaintLayerStackingNode.cpp [modify] https://crrev.com/2e85adbbf9239ee66ca736fb5f4ab35b8678bff4/third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp [modify] https://crrev.com/2e85adbbf9239ee66ca736fb5f4ab35b8678bff4/third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.cpp [modify] https://crrev.com/2e85adbbf9239ee66ca736fb5f4ab35b8678bff4/third_party/WebKit/Source/core/paint/compositing/CompositedLayerMapping.cpp [modify] https://crrev.com/2e85adbbf9239ee66ca736fb5f4ab35b8678bff4/third_party/WebKit/Source/core/paint/compositing/PaintLayerCompositor.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/73754fe0c4712c4bec681244b67b9646abed6268 commit 73754fe0c4712c4bec681244b67b9646abed6268 Author: Robert Hogan <robhogan@gmail.com> Date: Thu Nov 30 20:55:05 2017 Remove unnecessary uses of |this->| in core/layout (2 of 3) Bug: 789653 Change-Id: I5ea9761a687b4c9a64437df032af27d1a96080fb Reviewed-on: https://chromium-review.googlesource.com/797454 Commit-Queue: Robert Hogan <robhogan@gmail.com> Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#520676} [modify] https://crrev.com/73754fe0c4712c4bec681244b67b9646abed6268/third_party/WebKit/Source/core/layout/GridTrackSizingAlgorithm.cpp [modify] https://crrev.com/73754fe0c4712c4bec681244b67b9646abed6268/third_party/WebKit/Source/core/layout/HitTestResult.cpp [modify] https://crrev.com/73754fe0c4712c4bec681244b67b9646abed6268/third_party/WebKit/Source/core/layout/LayoutBlock.cpp [modify] https://crrev.com/73754fe0c4712c4bec681244b67b9646abed6268/third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp [modify] https://crrev.com/73754fe0c4712c4bec681244b67b9646abed6268/third_party/WebKit/Source/core/layout/LayoutBox.cpp [modify] https://crrev.com/73754fe0c4712c4bec681244b67b9646abed6268/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp [modify] https://crrev.com/73754fe0c4712c4bec681244b67b9646abed6268/third_party/WebKit/Source/core/layout/LayoutFrame.cpp [modify] https://crrev.com/73754fe0c4712c4bec681244b67b9646abed6268/third_party/WebKit/Source/core/layout/LayoutFrameSet.cpp [modify] https://crrev.com/73754fe0c4712c4bec681244b67b9646abed6268/third_party/WebKit/Source/core/layout/LayoutImage.cpp [modify] https://crrev.com/73754fe0c4712c4bec681244b67b9646abed6268/third_party/WebKit/Source/core/layout/LayoutListItem.cpp [modify] https://crrev.com/73754fe0c4712c4bec681244b67b9646abed6268/third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp [modify] https://crrev.com/73754fe0c4712c4bec681244b67b9646abed6268/third_party/WebKit/Source/core/layout/LayoutObject.h [modify] https://crrev.com/73754fe0c4712c4bec681244b67b9646abed6268/third_party/WebKit/Source/core/layout/LayoutObjectInlines.h [modify] https://crrev.com/73754fe0c4712c4bec681244b67b9646abed6268/third_party/WebKit/Source/core/layout/LayoutReplaced.cpp [modify] https://crrev.com/73754fe0c4712c4bec681244b67b9646abed6268/third_party/WebKit/Source/core/layout/LayoutRubyBase.cpp [modify] https://crrev.com/73754fe0c4712c4bec681244b67b9646abed6268/third_party/WebKit/Source/core/layout/LayoutRubyText.cpp [modify] https://crrev.com/73754fe0c4712c4bec681244b67b9646abed6268/third_party/WebKit/Source/core/layout/LayoutScrollbar.cpp [modify] https://crrev.com/73754fe0c4712c4bec681244b67b9646abed6268/third_party/WebKit/Source/core/layout/LayoutTable.cpp [modify] https://crrev.com/73754fe0c4712c4bec681244b67b9646abed6268/third_party/WebKit/Source/core/layout/LayoutTableCol.cpp [modify] https://crrev.com/73754fe0c4712c4bec681244b67b9646abed6268/third_party/WebKit/Source/core/layout/LayoutTableRow.cpp [modify] https://crrev.com/73754fe0c4712c4bec681244b67b9646abed6268/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp [modify] https://crrev.com/73754fe0c4712c4bec681244b67b9646abed6268/third_party/WebKit/Source/core/layout/LayoutTableSection.h [modify] https://crrev.com/73754fe0c4712c4bec681244b67b9646abed6268/third_party/WebKit/Source/core/layout/LayoutText.cpp [modify] https://crrev.com/73754fe0c4712c4bec681244b67b9646abed6268/third_party/WebKit/Source/core/layout/LayoutTextFragment.cpp [modify] https://crrev.com/73754fe0c4712c4bec681244b67b9646abed6268/third_party/WebKit/Source/core/layout/LayoutView.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/99dfe70e223af3d57193c863d7f2bdaaa964c080 commit 99dfe70e223af3d57193c863d7f2bdaaa964c080 Author: Robert Hogan <robhogan@gmail.com> Date: Fri Dec 01 00:08:51 2017 Remove unnecessary uses of |this->| in core/layout (3 of 3) The Blink Rename has made most uses of this-> unnecessary. The relevant variable names no longer clash with the getters. Bug: 789653 Change-Id: I039e502d4d46149a408be164671db2d45f214aae Reviewed-on: https://chromium-review.googlesource.com/797455 Commit-Queue: Robert Hogan <robhogan@gmail.com> Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#520761} [modify] https://crrev.com/99dfe70e223af3d57193c863d7f2bdaaa964c080/third_party/WebKit/Source/core/layout/line/AbstractInlineTextBox.cpp [modify] https://crrev.com/99dfe70e223af3d57193c863d7f2bdaaa964c080/third_party/WebKit/Source/core/layout/line/InlineIterator.h [modify] https://crrev.com/99dfe70e223af3d57193c863d7f2bdaaa964c080/third_party/WebKit/Source/core/layout/svg/LayoutSVGForeignObject.cpp [modify] https://crrev.com/99dfe70e223af3d57193c863d7f2bdaaa964c080/third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp [modify] https://crrev.com/99dfe70e223af3d57193c863d7f2bdaaa964c080/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceContainer.h [modify] https://crrev.com/99dfe70e223af3d57193c863d7f2bdaaa964c080/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceFilter.cpp [modify] https://crrev.com/99dfe70e223af3d57193c863d7f2bdaaa964c080/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceFilterPrimitive.cpp [modify] https://crrev.com/99dfe70e223af3d57193c863d7f2bdaaa964c080/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceLinearGradient.cpp [modify] https://crrev.com/99dfe70e223af3d57193c863d7f2bdaaa964c080/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePattern.cpp [modify] https://crrev.com/99dfe70e223af3d57193c863d7f2bdaaa964c080/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceRadialGradient.cpp [modify] https://crrev.com/99dfe70e223af3d57193c863d7f2bdaaa964c080/third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp [modify] https://crrev.com/99dfe70e223af3d57193c863d7f2bdaaa964c080/third_party/WebKit/Source/core/layout/svg/LayoutSVGShape.cpp [modify] https://crrev.com/99dfe70e223af3d57193c863d7f2bdaaa964c080/third_party/WebKit/Source/core/layout/svg/LayoutSVGTransformableContainer.cpp [modify] https://crrev.com/99dfe70e223af3d57193c863d7f2bdaaa964c080/third_party/WebKit/Source/core/layout/svg/line/SVGInlineTextBox.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/88ae5ff74c0faf86e994bf6a89a13c7c53863b4f commit 88ae5ff74c0faf86e994bf6a89a13c7c53863b4f Author: Robert Hogan <robhogan@gmail.com> Date: Mon Dec 04 19:24:39 2017 Remove unnecessary uses of |this->| in core/loader The Blink Rename has made most uses of this-> unnecessary. The relevant variable names no longer clash with the getters. Bug: 789653 Change-Id: I016817495e3192c6bf2d226afb2901df4b4c90c7 Reviewed-on: https://chromium-review.googlesource.com/805255 Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Robert Hogan <robhogan@gmail.com> Cr-Commit-Position: refs/heads/master@{#521404} [modify] https://crrev.com/88ae5ff74c0faf86e994bf6a89a13c7c53863b4f/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp [modify] https://crrev.com/88ae5ff74c0faf86e994bf6a89a13c7c53863b4f/third_party/WebKit/Source/core/loader/TextTrackLoader.cpp [modify] https://crrev.com/88ae5ff74c0faf86e994bf6a89a13c7c53863b4f/third_party/WebKit/Source/core/loader/resource/ImageResource.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6d39826b65e1adc905d8cd0a4d99bc877d58bba6 commit 6d39826b65e1adc905d8cd0a4d99bc877d58bba6 Author: Robert Hogan <robhogan@gmail.com> Date: Mon Dec 04 19:55:38 2017 Remove unnecessary uses of |this->| in core/html The Blink Rename has made most uses of this-> unnecessary. The relevant variable names no longer clash with the getters. Bug: 789653 Change-Id: I6ce6cb4107354a411da57e674df667658ea5d2fc Reviewed-on: https://chromium-review.googlesource.com/798130 Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Robert Hogan <robhogan@gmail.com> Cr-Commit-Position: refs/heads/master@{#521421} [modify] https://crrev.com/6d39826b65e1adc905d8cd0a4d99bc877d58bba6/third_party/WebKit/Source/core/html/HTMLAllCollection.cpp [modify] https://crrev.com/6d39826b65e1adc905d8cd0a4d99bc877d58bba6/third_party/WebKit/Source/core/html/HTMLAreaElement.cpp [modify] https://crrev.com/6d39826b65e1adc905d8cd0a4d99bc877d58bba6/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp [modify] https://crrev.com/6d39826b65e1adc905d8cd0a4d99bc877d58bba6/third_party/WebKit/Source/core/html/HTMLElement.cpp [modify] https://crrev.com/6d39826b65e1adc905d8cd0a4d99bc877d58bba6/third_party/WebKit/Source/core/html/HTMLEmbedElement.cpp [modify] https://crrev.com/6d39826b65e1adc905d8cd0a4d99bc877d58bba6/third_party/WebKit/Source/core/html/HTMLIFrameElement.cpp [modify] https://crrev.com/6d39826b65e1adc905d8cd0a4d99bc877d58bba6/third_party/WebKit/Source/core/html/HTMLImageLoader.cpp [modify] https://crrev.com/6d39826b65e1adc905d8cd0a4d99bc877d58bba6/third_party/WebKit/Source/core/html/HTMLMarqueeElement.cpp [modify] https://crrev.com/6d39826b65e1adc905d8cd0a4d99bc877d58bba6/third_party/WebKit/Source/core/html/HTMLObjectElement.cpp [modify] https://crrev.com/6d39826b65e1adc905d8cd0a4d99bc877d58bba6/third_party/WebKit/Source/core/html/ImageData.cpp [modify] https://crrev.com/6d39826b65e1adc905d8cd0a4d99bc877d58bba6/third_party/WebKit/Source/core/html/ImageDocument.cpp [modify] https://crrev.com/6d39826b65e1adc905d8cd0a4d99bc877d58bba6/third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.cpp [modify] https://crrev.com/6d39826b65e1adc905d8cd0a4d99bc877d58bba6/third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreatorTest.cpp [modify] https://crrev.com/6d39826b65e1adc905d8cd0a4d99bc877d58bba6/third_party/WebKit/Source/core/html/forms/ColorInputType.cpp [modify] https://crrev.com/6d39826b65e1adc905d8cd0a4d99bc877d58bba6/third_party/WebKit/Source/core/html/forms/DateTimeEditElement.cpp [modify] https://crrev.com/6d39826b65e1adc905d8cd0a4d99bc877d58bba6/third_party/WebKit/Source/core/html/forms/DateTimeNumericFieldElement.cpp [modify] https://crrev.com/6d39826b65e1adc905d8cd0a4d99bc877d58bba6/third_party/WebKit/Source/core/html/forms/FileInputType.cpp [modify] https://crrev.com/6d39826b65e1adc905d8cd0a4d99bc877d58bba6/third_party/WebKit/Source/core/html/forms/HTMLFormControlElement.cpp [modify] https://crrev.com/6d39826b65e1adc905d8cd0a4d99bc877d58bba6/third_party/WebKit/Source/core/html/forms/HTMLFormControlsCollection.cpp [modify] https://crrev.com/6d39826b65e1adc905d8cd0a4d99bc877d58bba6/third_party/WebKit/Source/core/html/forms/HTMLFormElement.cpp [modify] https://crrev.com/6d39826b65e1adc905d8cd0a4d99bc877d58bba6/third_party/WebKit/Source/core/html/forms/HTMLInputElement.cpp [modify] https://crrev.com/6d39826b65e1adc905d8cd0a4d99bc877d58bba6/third_party/WebKit/Source/core/html/forms/HTMLOptionElement.cpp [modify] https://crrev.com/6d39826b65e1adc905d8cd0a4d99bc877d58bba6/third_party/WebKit/Source/core/html/forms/HTMLOptionsCollection.cpp [modify] https://crrev.com/6d39826b65e1adc905d8cd0a4d99bc877d58bba6/third_party/WebKit/Source/core/html/forms/HTMLSelectElement.cpp [modify] https://crrev.com/6d39826b65e1adc905d8cd0a4d99bc877d58bba6/third_party/WebKit/Source/core/html/forms/HTMLTextAreaElement.cpp [modify] https://crrev.com/6d39826b65e1adc905d8cd0a4d99bc877d58bba6/third_party/WebKit/Source/core/html/forms/HTMLTextAreaElement.h [modify] https://crrev.com/6d39826b65e1adc905d8cd0a4d99bc877d58bba6/third_party/WebKit/Source/core/html/forms/MultipleFieldsTemporalInputTypeView.cpp [modify] https://crrev.com/6d39826b65e1adc905d8cd0a4d99bc877d58bba6/third_party/WebKit/Source/core/html/forms/RangeInputType.cpp [modify] https://crrev.com/6d39826b65e1adc905d8cd0a4d99bc877d58bba6/third_party/WebKit/Source/core/html/forms/StepRange.cpp [modify] https://crrev.com/6d39826b65e1adc905d8cd0a4d99bc877d58bba6/third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp [modify] https://crrev.com/6d39826b65e1adc905d8cd0a4d99bc877d58bba6/third_party/WebKit/Source/core/html/imports/HTMLImport.cpp [modify] https://crrev.com/6d39826b65e1adc905d8cd0a4d99bc877d58bba6/third_party/WebKit/Source/core/html/imports/HTMLImportChild.cpp [modify] https://crrev.com/6d39826b65e1adc905d8cd0a4d99bc877d58bba6/third_party/WebKit/Source/core/html/media/HTMLMediaElement.cpp [modify] https://crrev.com/6d39826b65e1adc905d8cd0a4d99bc877d58bba6/third_party/WebKit/Source/core/html/track/CueTimeline.cpp
Comment 1 by bugdroid1@chromium.org
, Nov 30 2017