Wallpaper decoder should be independent of Chrome. |
||||
Issue descriptionCurrently wallpaper_manager uses user_image_loader [1] under //chrome as the decoder. This results in two issues: 1) //ash can't use it. 2) Decoded wallpapers are stored in |UserImage| which is used mainly for avatars. This involves lots of irrelevant code for wallpapers. So we need a simple wallpaper-specific decoder. [1] https://cs.chromium.org/chromium/src/chrome/browser/chromeos/login/users/avatar/user_image_loader.h?type=cs
,
Dec 1 2017
,
Dec 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bb76aacae674d19264a0acb83e4c9f6ef9117b19 commit bb76aacae674d19264a0acb83e4c9f6ef9117b19 Author: Wenzhao Zang <wzang@chromium.org> Date: Sat Dec 02 19:19:50 2017 cros: Create a simplified and Chrome-independent wallpaper decoder 1) Removes the Chrome dependency of wallpaper decoding. 2) wallpaper_decoder.h is very similar to ash/login/ui/image_parser.h. 3) Aimed to introduce zero regression. The only difference with the current decoder is that some of the PostTask calls are removed. Bug: 789649 Change-Id: Ia13da24a8911d71d2c1d503f2160c58c8d781267 Reviewed-on: https://chromium-review.googlesource.com/801935 Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Reviewed-by: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#521219} [modify] https://crrev.com/bb76aacae674d19264a0acb83e4c9f6ef9117b19/ash/BUILD.gn [modify] https://crrev.com/bb76aacae674d19264a0acb83e4c9f6ef9117b19/ash/wallpaper/DEPS [add] https://crrev.com/bb76aacae674d19264a0acb83e4c9f6ef9117b19/ash/wallpaper/wallpaper_decoder.cc [add] https://crrev.com/bb76aacae674d19264a0acb83e4c9f6ef9117b19/ash/wallpaper/wallpaper_decoder.h [modify] https://crrev.com/bb76aacae674d19264a0acb83e4c9f6ef9117b19/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc
,
Dec 5 2017
,
Jul 30
|
||||
►
Sign in to add a comment |
||||
Comment 1 by wzang@chromium.org
, Nov 30 2017