New issue
Advanced search Search tips

Issue 789645 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Feature


Show other hotlists

Hotlists containing this issue:
XXX


Sign in to add a comment

Chrome Upstream Partial Data: Field Metadata Upload (Implementation bug)

Project Member Reported by jsaul@google.com, Nov 29 2017

Issue description

Payments is attempting to relax its upload credit card requirements of CVC + name + address.  In Chrome's check to see if a card can be uploaded to Google Payments, send metadata on if CVC, address, and cardholder name were found in the checkout flow (NOT their values), along with whether the user is already a Google Payments user (via existence of the billing_customer_number Priority Preference).  Payments would then use this information to decide if the card can be saved to Google Payments or not.

This bug is for the implementation of the feature.
The launch bug is Issue 759910.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e4786a323e8eca4d5a66474bf23aa7fa80fe7ae

commit 1e4786a323e8eca4d5a66474bf23aa7fa80fe7ae
Author: Jared Saul <jsaul@google.com>
Date: Thu Dec 14 01:43:09 2017

Credit card upload save always asks Google payments if save is possible, provides metadata on detected values

Bug:  789645 
Change-Id: I4c4709d9a4bd08134893dc64aa5a07e188bc2388
Reviewed-on: https://chromium-review.googlesource.com/816078
Commit-Queue: Jared Saul <jsaul@google.com>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523976}
[modify] https://crrev.com/1e4786a323e8eca4d5a66474bf23aa7fa80fe7ae/chrome/browser/about_flags.cc
[modify] https://crrev.com/1e4786a323e8eca4d5a66474bf23aa7fa80fe7ae/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/1e4786a323e8eca4d5a66474bf23aa7fa80fe7ae/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/1e4786a323e8eca4d5a66474bf23aa7fa80fe7ae/components/autofill/core/browser/autofill_experiments.cc
[modify] https://crrev.com/1e4786a323e8eca4d5a66474bf23aa7fa80fe7ae/components/autofill/core/browser/autofill_experiments.h
[modify] https://crrev.com/1e4786a323e8eca4d5a66474bf23aa7fa80fe7ae/components/autofill/core/browser/credit_card_save_manager.cc
[modify] https://crrev.com/1e4786a323e8eca4d5a66474bf23aa7fa80fe7ae/components/autofill/core/browser/credit_card_save_manager.h
[modify] https://crrev.com/1e4786a323e8eca4d5a66474bf23aa7fa80fe7ae/components/autofill/core/browser/credit_card_save_manager_unittest.cc
[modify] https://crrev.com/1e4786a323e8eca4d5a66474bf23aa7fa80fe7ae/components/autofill/core/browser/form_data_importer.cc
[modify] https://crrev.com/1e4786a323e8eca4d5a66474bf23aa7fa80fe7ae/components/autofill/core/browser/payments/payments_client.cc
[modify] https://crrev.com/1e4786a323e8eca4d5a66474bf23aa7fa80fe7ae/components/autofill/core/browser/payments/payments_client.h
[modify] https://crrev.com/1e4786a323e8eca4d5a66474bf23aa7fa80fe7ae/components/autofill/core/browser/payments/payments_client_unittest.cc
[modify] https://crrev.com/1e4786a323e8eca4d5a66474bf23aa7fa80fe7ae/tools/metrics/histograms/enums.xml

Project Member

Comment 2 by bugdroid1@chromium.org, Dec 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db75f306dd6169bcc32227373ba8b4c14ee5b64e

commit db75f306dd6169bcc32227373ba8b4c14ee5b64e
Author: Jared Saul <jsaul@google.com>
Date: Thu Dec 14 23:54:01 2017

Update waterfall testing config for new Chrome Upstream launches

Make the following changes:

* Remove AutofillUpstreamShowGoogleLogo and AutofillUpstreamShowNewUi.  The code has been updated to make those default.
* Add Mac to AutofillUpstreamRequestCvcIfMissing in preparation of the M64 launch.
* Add config for AutofillUpstreamSendDetectedValues and AutofillUpstreamSendPanFirstSix, part of the Upstream Partial Data Project targeting M65.

Bug:  736944 ,  789645 ,  793490 
Change-Id: If6888d203dbceb3dcba8d38184244375c9cb110a
Reviewed-on: https://chromium-review.googlesource.com/827631
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#524234}
[modify] https://crrev.com/db75f306dd6169bcc32227373ba8b4c14ee5b64e/testing/variations/fieldtrial_testing_config.json

Project Member

Comment 3 by bugdroid1@chromium.org, Dec 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/65fe00d55f8b6d257a8b8b82e6b7089a11a3178d

commit 65fe00d55f8b6d257a8b8b82e6b7089a11a3178d
Author: Jared Saul <jsaul@google.com>
Date: Tue Dec 19 15:03:29 2017

Update DCHECK and add comments

Bug:  789645 
Change-Id: I12aec6e11c4506b70a00848173fae24d310748cb
Reviewed-on: https://chromium-review.googlesource.com/833211
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525033}
[modify] https://crrev.com/65fe00d55f8b6d257a8b8b82e6b7089a11a3178d/components/autofill/core/browser/credit_card_save_manager.cc
[modify] https://crrev.com/65fe00d55f8b6d257a8b8b82e6b7089a11a3178d/components/autofill/core/browser/credit_card_save_manager.h

Comment 6 by jsaul@google.com, Mar 7 2018

Status: Fixed (was: Started)
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/009129516ae0130a4c8470870c78d7f68efc58e5

commit 009129516ae0130a4c8470870c78d7f68efc58e5
Author: Jared Saul <jsaul@google.com>
Date: Thu Mar 08 00:46:30 2018

Add unit test for detecting HAS_GOOGLE_PAYMENTS_ACCOUNT

Bug:  789645 
Change-Id: I6c07392942a49c7ce20ece83cdd5284310377559
Reviewed-on: https://chromium-review.googlesource.com/953969
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541656}
[modify] https://crrev.com/009129516ae0130a4c8470870c78d7f68efc58e5/components/autofill/core/browser/credit_card_save_manager_unittest.cc

Sign in to add a comment