The CookieStore and ChannelIDStore need to be configurable when the network service is enabled.
Beyond just where to store them, QuotaPolicyCookieStore and QuotaPolicyChannelIDStore allow the embedder to configure per-origin policies. We also use encrypted storage of some sort.
cduvall@, since you have some context here can you look at what other aspects of cookie (and channel ID) storage remain unconfigured when we enable the Network Service?
Owner: cduvall@chromium.org Status: Started (was: Assigned)
The remaining things for CookieStore and ChannelIDStore that I know of are:
- ChannelID session cleanup, similar to the cookie session cleanup
- Encrypted storage for cookies
I'll take this bug since I have some context about whats going on and needs to be done.
As duped issue-848361 is working as intended on windows using latest canary-69.0.3493.0,tested the same on Mac , debian &adding TE Verified labels here.
Thanks..!
I see that we still have this issue and below are steps which reproduces the issue :
Steps to reproduce :
1. Install and launch Chrome Canary
2. From Chrome://flags -->Enable "Enable network service" flag from "About://flags"
3. Relaunch Chrome
4. Visit "https://www.gmail.com" and signin.
5. Make sure you are signed in and also verify that "chrome://settings/content/cookies --> Keep local data only until you quit your browser" isn't enabled.
6. From Chrome://flags -->Disable "Enable network service" flag from "About://flags"
What is the expected result?
Should still be signed in to gmail.com
What happens instead?
Kicked me out of gmail.
Since I am still able to reproduce this issue changing the status back to assigned, please let me know if above issue should be tracked separately.
cduvall kindly pointed out to me that the channel ID store is apparently not encrypted, unlike the cookie store, so I'm not sure why this wouldn't be working.
Looked into this a bit more, I can repro by:
1. Enable network service
2. Sign in to gmail
3. Restart chrome
It looks like network service isn't persisting cookies for some reason.
After some more investigation, network service seems to be persisting cookies fine, but this is an issue with Chrome signin. I noticed that when logging into gmail without network service, it also logs into Chrome. This does not happen with network service enabled. Even if you try to log in by clicking the account button -> "Sign in" with network service enabled, you get a 404. I believe this is the root cause.
My best guess is that signin::FixAccountConsistencyRequestHeader is no longer being run on that header when network service is disabled, which is causing some issues.
Comment 1 by mmenke@chromium.org
, Nov 29 2017