Separate gesture token for touch events and corresponding pointerevents |
||
Issue descriptionAfter this CL: https://chromium-review.googlesource.com/c/chromium/src/+/785871 The shared gesture token between pointerup and touchend is kept as a class member instead of a stack variable that gets cleared automatically as soon as it goes out of stack. Mustaq is suggesting maybe having one token for each of these types isn't that bad considering the non-consuming token behavior of FF and old Safari and it also makes the code much more cleaner.
,
Dec 4 2017
I think this is probably OK (at least for now). There's a longstanding bug somewhere about touchend and click getting separate tokens and IIRC we've never seen a problem in practice and everyone has been fine considering it a low-priority bug.
,
Jan 4 2018
Sounds good. Now that my refactoring wave passed that point of the code this might be a good time to revisit this issue. mustaq@ do you like to take a look at this or do you want me to separate the gesture tokens?
,
Jan 9 2018
This is almost like a code-health issue because the impact of the split token should be negligible. |
||
►
Sign in to add a comment |
||
Comment 1 by mustaq@chromium.org
, Nov 29 2017