New issue
Advanced search Search tips

Issue 789640 link

Starred by 1 user
Status: Fixed
Owner:
jam@chromium.org
Closed: May 2018
Cc:
vakh@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Proj-Servicification

Blocked on:
issue 789644
Blocking:
issue 598073


Show other hotlists

Hotlists containing this issue:
XXX


Sign in to add a comment

Make SafeBrowsing URLRequestContext use the NetworkService when the network service is enabled.

Project Member Reported by mmenke@chromium.org, Nov 29 2017 
SafeBrowsing creates its own URLRequestContext which "borrows" a lot of components of the main URLRequestContext, so not clear how to handle this.  We need to figure out what to do about this when the network service is enabled.  Policy requests also use this URLRequestContext.

We many need to punt this until have cookie store / channel ID store configuration working when the network service is enabled, though this issue does block updating consumers of Safebrowsing's cookie store.

Comment 1 by mmenke@chromium.org, Nov 29 2017

Summary: Make SafeBrowsing URLRequestContext use the NetworkService when the network service is enabled. (was: Make SafeBrowsing URLRequestContext using the NetworkService when the network service is enabled.)

Comment 2 by mmenke@chromium.org, Nov 29 2017

Blockedon: 789644

Comment 3 by nparker@chromium.org, Dec 1 2017

Labels: SafeBrowsing-Triaged
Project Member

Comment 4 by bugdroid1@chromium.org, May 8 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/516cc36eb209e416ee9560b994ab47abf75830d9

commit 516cc36eb209e416ee9560b994ab47abf75830d9
Author: Matt Menke <mmenke@chromium.org>
Date: Tue May 08 18:29:04 2018

Make NetworkContextConfigurationBrowserTests run for SafeBrowsing.

Currently, they only run when the network service is disabled.  This CL
will both make it easier to enable them for SafeBrowsing once
SafeBrowsing correctly sets up its tests with the network service
enabled, and protects against regressions in the legacy in-process path
in the meantime.

Bug:  789640 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I5d33acbe7c3ee918a2fe5335c60c7c2b7bb0721a
Reviewed-on: https://chromium-review.googlesource.com/1042888
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Matt Mueller <mattm@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556887}
[modify] https://crrev.com/516cc36eb209e416ee9560b994ab47abf75830d9/chrome/browser/net/network_context_configuration_browsertest.cc
[modify] https://crrev.com/516cc36eb209e416ee9560b994ab47abf75830d9/chrome/browser/safe_browsing/safe_browsing_service.cc
[modify] https://crrev.com/516cc36eb209e416ee9560b994ab47abf75830d9/chrome/browser/safe_browsing/safe_browsing_service.h
[modify] https://crrev.com/516cc36eb209e416ee9560b994ab47abf75830d9/components/safe_browsing/browser/safe_browsing_network_context.cc
[modify] https://crrev.com/516cc36eb209e416ee9560b994ab47abf75830d9/components/safe_browsing/browser/safe_browsing_network_context.h
[modify] https://crrev.com/516cc36eb209e416ee9560b994ab47abf75830d9/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
Project Member

Comment 5 by bugdroid1@chromium.org, May 11 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/067364dfbb2b96b762a9f1b157d7f657f1bf6e36

commit 067364dfbb2b96b762a9f1b157d7f657f1bf6e36
Author: John Abd-El-Malek <jam@chromium.org>
Date: Fri May 11 03:09:18 2018

Don't use the browser-process URLRequestContext for safe browsing with network service.

Instead use a NetworkContext, which runs in the network process when network service is enabled.

Bug:  825242 ,  789640 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I1f1244fbc71968a78bbb8ad1235e69f9935658fa
Reviewed-on: https://chromium-review.googlesource.com/1008839
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Matt Mueller <mattm@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557776}
[modify] https://crrev.com/067364dfbb2b96b762a9f1b157d7f657f1bf6e36/android_webview/browser/DEPS
[modify] https://crrev.com/067364dfbb2b96b762a9f1b157d7f657f1bf6e36/android_webview/browser/aw_safe_browsing_ui_manager.cc
[modify] https://crrev.com/067364dfbb2b96b762a9f1b157d7f657f1bf6e36/android_webview/browser/aw_safe_browsing_ui_manager.h
[modify] https://crrev.com/067364dfbb2b96b762a9f1b157d7f657f1bf6e36/chrome/browser/net/network_context_configuration_browsertest.cc
[modify] https://crrev.com/067364dfbb2b96b762a9f1b157d7f657f1bf6e36/chrome/browser/net/system_network_context_manager.cc
[modify] https://crrev.com/067364dfbb2b96b762a9f1b157d7f657f1bf6e36/chrome/browser/policy/policy_network_browsertest.cc
[modify] https://crrev.com/067364dfbb2b96b762a9f1b157d7f657f1bf6e36/chrome/browser/safe_browsing/notification_image_reporter_unittest.cc
[modify] https://crrev.com/067364dfbb2b96b762a9f1b157d7f657f1bf6e36/chrome/browser/safe_browsing/safe_browsing_service.cc
[modify] https://crrev.com/067364dfbb2b96b762a9f1b157d7f657f1bf6e36/chrome/browser/safe_browsing/safe_browsing_service.h
[modify] https://crrev.com/067364dfbb2b96b762a9f1b157d7f657f1bf6e36/components/safe_browsing/DEPS
[modify] https://crrev.com/067364dfbb2b96b762a9f1b157d7f657f1bf6e36/components/safe_browsing/browser/safe_browsing_network_context.cc
[modify] https://crrev.com/067364dfbb2b96b762a9f1b157d7f657f1bf6e36/components/safe_browsing/browser/safe_browsing_network_context.h
[modify] https://crrev.com/067364dfbb2b96b762a9f1b157d7f657f1bf6e36/content/browser/network_service_instance.cc
[modify] https://crrev.com/067364dfbb2b96b762a9f1b157d7f657f1bf6e36/content/public/browser/network_service_instance.h
[modify] https://crrev.com/067364dfbb2b96b762a9f1b157d7f657f1bf6e36/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Comment 6 by jam@chromium.org, May 11 2018

Owner: jam@chromium.org
Status: Fixed (was: Untriaged)
►

Sign in to add a comment