Issue metadata
Sign in to add a comment
|
72 Kb regression in resource_sizes (MonochromePublic.apk) at 520061:520062 |
||||||||||||||||||||||
Issue descriptionCaused by "[oilpan] Remove HEAP_INCREMENTAL_MARKING compile time flag" Commit: 5f56deb44521c891ed8093cadd3ba8cc52a168a7 Link to size graph: https://chromeperf.appspot.com/report?sid=a097e74b1aa288511afb4cb616efe0f95ba4d347ad61d5e835072f23450938ba&num_points=10&rev=520062 Debugging size regressions is documented at: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/apk_size_regressions.md#Debugging-Apk-Size-Increase Based on the graph: All native code growth.
,
Nov 29 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8961563961754443088
,
Nov 29 2017
It looks like this increase was probably unexpected or might be avoidable. Please have a look and either: Close as “Won't Fix” with a short justification, or Land a revert / fix-up. mlippautz - can you take a look? 72 Kb is a fairly sizable regression on Android.
,
Nov 29 2017
=== BISECT JOB RESULTS ===
NO Perf regression found, tests failed to produce values
Bisect Details
Configuration: android_nexus7_perf_bisect
Benchmark : resource_sizes
Metric : MonochromePublic.apk_Specifics/normalized apk size
To Run This Test
src/build/android/resource_sizes.py --chromium-output-directory {CHROMIUM_OUTPUT_DIR} --chartjson {CHROMIUM_OUTPUT_DIR}/apks/MonochromePublic.apk
More information on addressing performance regressions:
http://g.co/ChromePerformanceRegressions
Debug information about this bisect:
https://chromeperf.appspot.com/buildbucket_job_status/8961563961754443088
For feedback, file a bug with component Speed>Bisection
,
Nov 30 2017
The regression is sort of intended. The barrier is core infrastructure for garbage collection improvements. We might be able to optimize the size by outlining a few things though. Let me keep this open and assigned to me.
,
Nov 30 2017
,
Dec 5 2017
,
Dec 8 2017
The optimization in faf0c6646d65d165018b9af7331033b4c358e7ba is getting back 40960. I realize that it is still ~30k but considering that this is core garbage collection infrastructure I think the increase is justified.
,
Dec 8 2017
Agreed. Thanks for your efforts! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Nov 29 2017