New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 789622 link

Starred by 1 user
Status: Assigned
Owner:
█ bradnelson@chromium.org
Last visit > 30 days ago
Cc:
estevenson@chromium.org
EstimatedDays: ----
NextAction: 2018-02-28
OS: Android
Pri: 3
Type: Bug-Regression


Show other hotlists

Hotlists containing this issue:
XXX


Sign in to add a comment

36 Kb regression in resource_sizes (MonochromePublic.apk) at 520046:520046)

Project Member Reported by estevenson@chromium.org, Nov 29 2017 
Caused by "Revert "Revert "[wasm] JIT using WasmCodeManager"""

Commit: a027c5408d5daf209dbe58986f68c271138b983b (v8 commit: b03b1bd9a87aa34380d62eb5bf42d52ba919f2f3)

Link to size graph: https://chromeperf.appspot.com/report?sid=a097e74b1aa288511afb4cb616efe0f95ba4d347ad61d5e835072f23450938ba&num_points=10&rev=520046

Debugging size regressions is documented at: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/apk_size_regressions.md#Debugging-Apk-Size-Increase

It's not clear to me whether or not this increase was expected.
Please have a look and either:

Close as “Won't Fix” with a short justification, or
Land a revert / fix-up.
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Nov 29 2017 

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=789622

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=e20758be0c4f0a52e704950132ba22dab2e54f44ba21badd38f0eb8b09c55370


Bot(s) for this bug's original alert(s):

Android Builder

Comment 2 by estevenson@chromium.org, Nov 29 2017

Labels: OS-Android
See attached diff for more details.
diff_results.txt
53.3 KB View Download

Comment 3 by mtrofin@chromium.org, Nov 29 2017 

If I understand this correctly, this observes a 36KB growth in what probably is native libraries. 

This is expected with this change. It added, behind a flag, a secondary mechanism for allocating executable code for wasm.

The growth is temporary. Once we gain confidence in the new feature, we will enable the flag by default, and then, once we believe we do not need a 'fast way to revert to the old mechanism', delete the old code.

Comment 4 by estevenson@chromium.org, Dec 8 2017

Summary: Remove (was: 36 Kb regression in resource_sizes (MonochromePublic.apk) at 520046:520046)
Makes sense! Should we keep this bug open to make sure the old code paths are removed?

Comment 5 by mtrofin@chromium.org, Dec 8 2017 

Yes, but we need to remove the target milestone and lower priority, because we will probably want to keep the old paths for a milestone (at most, I hope). Just in case we need a quick revert.

Comment 6 by estevenson@chromium.org, Dec 8 2017

Labels: -Pri-2 -M-64 Pri-3
Summary: 36 Kb regression in resource_sizes (MonochromePublic.apk) at 520046:520046) (was: Remove)

Comment 7 by agrieve@chromium.org, Jan 10 2018

NextAction: 2018-02-28

Comment 8 by monor...@bugs.chromium.org, Feb 28 2018 

The NextAction date has arrived: 2018-02-28

Comment 9 by mtrofin@chromium.org, Feb 28 2018

Owner: bradnelson@chromium.org
►

Sign in to add a comment