New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 789621 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug


Show other hotlists

Hotlists containing this issue:
XXX


Sign in to add a comment

webgl2_conformance_d3d11_passthrough_tests reliably failing deqp_functional_gles3_lifetime test on Windows 7 NVIDIA config

Project Member Reported by jmad...@chromium.org, Nov 29 2017

Issue description

Unsure what CL caused this - I feel it's unlikely to be an ANGLE CL because we test this on our CQ. I would suspect a Chromium CL.

First failing:

https://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20Release%20%28NVIDIA%29/builds/32291

Regression range:

https://chromium.googlesource.com/chromium/src/+log/3b7e23cfbdde4becd958815fb5bcf1d7aea90a17..55c1ed1a0331696c3b6cecf8d079562af6019f1d

Some suspicious gpu changes:

from Geoff:

"Add fieldtrial testing for DefaultPassthroughCommandDecoder."
https://chromium.googlesource.com/chromium/src/+/3c1643876d820e241f10d0f67edf8740be72be3d

"Don't delete the invalid service id."
https://chromium.googlesource.com/chromium/src/+/d4214b507906607ed46248718a3642a760d64ba4

From Eric:

"Handle context loss + gpu:buffer creation failure in Discardable system"
https://chromium.googlesource.com/chromium/src/+/c97b35ae7f1b059e1760b1f8b802a6b0c939f3d8

Geoff can you help triage this?
 
Actually, it might not be the fieldtrial testing CL, since that was reverted in https://chromium-review.googlesource.com/796690 and the bot still failed. The other two CLs seem like they might be suspicious.
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b93d7c1a57837c8b93135bed14a3c9a9478acd01

commit b93d7c1a57837c8b93135bed14a3c9a9478acd01
Author: Geoff Lang <geofflang@chromium.org>
Date: Wed Nov 29 20:23:27 2017

Revert "Don't delete the invalid service id."

This reverts commit d4214b507906607ed46248718a3642a760d64ba4.

Reason for revert: Possibly causing WebGL failures and other assertion failures.

BUG=789621

Original change's description:
> Don't delete the invalid service id.
> 
> It was possible to put thing in a bad state by calling glBind* with an
> invalid client id (which binds the invalid service id) and then calling
> glDelete* with an invalid client id (which deletes the invald service
> id).
> 
> BUG= 785753 
> 
> Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> Change-Id: I4628f964e9d14a1d87bc12b1cde3f056acb8314e
> Reviewed-on: https://chromium-review.googlesource.com/791011
> Reviewed-by: Antoine Labour <piman@chromium.org>
> Commit-Queue: Geoff Lang <geofflang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#519752}

TBR=geofflang@chromium.org,piman@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  785753 
Change-Id: If2343ecb8fd12c8bfc400bffa455de91f0caf8bb
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/797570
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520222}
[modify] https://crrev.com/b93d7c1a57837c8b93135bed14a3c9a9478acd01/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc

Sign in to add a comment