New issue
Advanced search Search tips

Issue 789620 link

Starred by 2 users
Status: Fixed
Owner:
billorr@chromium.org
Closed: Dec 13
Cc:
billorr@chromium.org
bajones@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug
Proj-XR


Show other hotlists

Hotlists containing this issue:
XXX


Sign in to add a comment

WebVR: Implement OnDeviceDisconnected and clean up VRDisplay for removed devices.

Project Member Reported by mthiesse@chromium.org, Nov 29 2017 
Right now if a device were to be removed (which doesn't yet happen), then the mojo connections would be torn down, but the VRDisplay would persist in a state where presentation/pose requests fail.

We should implement VRServiceClient::OnDisplayDisconnected and cleanly tear down the VRDisplay.

Comment 1 by mthiesse@chromium.org, Jan 17 2018

Labels: -M-65
Owner: billorr@chromium.org
Status: Assigned (was: Available)
Assigning to Bill, assuming we to properly support desktop headsets connecting and disconnecting.

Comment 2 by btebbs@chromium.org, Jul 4

Components: Blink>WebXR

Comment 3 by efoo@chromium.org, Aug 7

Labels: BlinkWebXR
Removing Blink>WebVR component and assigning to Blink>WebXR

Comment 4 by efoo@chromium.org, Aug 7

Labels: -BlinkWebXR
Removing Blink>WebVR component and assigning to Blink>WebXR

Comment 5 by efoo@chromium.org, Aug 7

Components: -Blink>WebVR
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca60fe109315de3d88e1bf9d5ade38b5aaf5f544

commit ca60fe109315de3d88e1bf9d5ade38b5aaf5f544
Author: Bill Orr <billorr@chromium.org>
Date: Thu Dec 13 00:24:50 2018

Detect and handle XR device connect/disconnect

This change finishes plumbing of device connection events from the devices
to the browser, and fixes handling in the WebXR implementation.

Bug:  789620 , 778041 
Change-Id: Iba9999c0b021261df23add4d1bb2826bd0764ed4
Reviewed-on: https://chromium-review.googlesource.com/c/1364332
Commit-Queue: Bill Orr <billorr@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616118}
[modify] https://crrev.com/ca60fe109315de3d88e1bf9d5ade38b5aaf5f544/chrome/services/isolated_xr_device/xr_runtime_provider.cc
[modify] https://crrev.com/ca60fe109315de3d88e1bf9d5ade38b5aaf5f544/chrome/services/isolated_xr_device/xr_runtime_provider.h
[modify] https://crrev.com/ca60fe109315de3d88e1bf9d5ade38b5aaf5f544/device/vr/oculus/oculus_device.cc
[modify] https://crrev.com/ca60fe109315de3d88e1bf9d5ade38b5aaf5f544/device/vr/oculus/oculus_device.h
[modify] https://crrev.com/ca60fe109315de3d88e1bf9d5ade38b5aaf5f544/device/vr/openvr/openvr_device.cc
[modify] https://crrev.com/ca60fe109315de3d88e1bf9d5ade38b5aaf5f544/device/vr/openvr/openvr_device.h
[modify] https://crrev.com/ca60fe109315de3d88e1bf9d5ade38b5aaf5f544/third_party/blink/renderer/modules/xr/xr.cc

Comment 7 by billorr@chromium.org, Dec 13

Status: Fixed (was: Assigned)
►

Sign in to add a comment