chromeos archive is missing libminigbm.so, breaks bisect-builds.py |
|||||||||||||
Issue descriptionRepro 1: Try to bisect a recent chromeos build, e.g.: tools/bisect-builds.py -a chromeos -g 517000 --use-local-cache Expected: opens up Chrome Actual: prompts for good/bad without ever opening Chrome. Underlying error: chrome: error while loading shared libraries: libminigbm.so: cannot open shared object file: No such file or directory =========== Repro 2: 1. Grab a recent chromeos snapshot from: http://commondatastorage.googleapis.com/chromium-browser-snapshots/Linux_ChromiumOS_Full/ 2. Unzip the resulting archive 3. Try to run chrome chrome: error while loading shared libraries: libminigbm.so: cannot open shared object file: No such file or directory Workaround: manually copy libminigbm.so from a recent build. Most likely broken since: https://chromium-review.googlesource.com/c/chromium/src/+/625550
,
Nov 29 2017
FYI msw
,
Nov 29 2017
+stevenjb also, does anyone know what script/process generates these archives?
,
Nov 29 2017
I can take this. We need to flip this from "Linux Chromium Full" to linux-chromeos-rel as well.
,
Nov 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/215e80bda9803c6ef212ad016efd9561e9025c9c commit 215e80bda9803c6ef212ad016efd9561e9025c9c Author: Dominic Mazzoni <dmazzoni@chromium.org> Date: Wed Nov 29 20:05:27 2017 Another hack to fix bisect-builds for chromeos Bug: 789612 Change-Id: Ic81a3a20bb6bbbec72d49e76163a781752aa1605 Reviewed-on: https://chromium-review.googlesource.com/797532 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#520210} [modify] https://crrev.com/215e80bda9803c6ef212ad016efd9561e9025c9c/tools/bisect-builds.py
,
Nov 29 2017
,
Feb 2 2018
Dunno if/when I'll get to this, so marking as available and disclaiming ownership :(.
,
Sep 6
,
Sep 6
,
Sep 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/93ae05c8843e4d501bbf14c8d606ad8bc3b87047 commit 93ae05c8843e4d501bbf14c8d606ad8bc3b87047 Author: Dominic Mazzoni <dmazzoni@chromium.org> Date: Wed Sep 12 21:05:42 2018 Add missing files to Chrome OS archives Bug: 789612 , 872783 , 879733 Change-Id: I068c03306aca5f107033efbea66abf062e747c0d Reviewed-on: https://chromium-review.googlesource.com/1222688 Reviewed-by: Michael Moss <mmoss@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#590819} [modify] https://crrev.com/93ae05c8843e4d501bbf14c8d606ad8bc3b87047/chrome/tools/build/chromeos/FILES.cfg
,
Sep 13
Unfortunately this didn't seem to help. I tried downloading r591029: https://www.googleapis.com/download/storage/v1/b/chromium-browser-snapshots/o/Linux_ChromiumOS_Full%2F591029%2Fchrome-linux.zip?alt=media It doesn't have either of the two files I added in this change.
,
Sep 13
I wonder if the chromeos bot is incorrectly picking up the linux/FILES.cfg file, and not the chromeos/FILES.cfg... For example, it's adding "chrome_sandbox" to the archive: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8935466236056225696/+/steps/archive_build/0/stdout But that isn't in chromeos/FILES.cfg: https://codesearch.chromium.org/chromium/src/chrome/tools/build/chromeos/FILES.cfg And it is in linux/FILES.cfg: https://codesearch.chromium.org/chromium/src/chrome/tools/build/linux/FILES.cfg?rcl=960b2849662538cdb8a84352d8aa69a122382c74&l=47 Stephen's making some changes to how this bot archives builds in https://chromium-review.googlesource.com/c/chromium/tools/build/+/1225413. I can take a look at fixing this once that lands (if it's still busted).
,
Sep 13
,
Sep 13
My change shouldn't affect this
,
Sep 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/3d2a5ddb88ae6d7266fd7e55ccf68ae913cb1087 commit 3d2a5ddb88ae6d7266fd7e55ccf68ae913cb1087 Author: Ben Pastene <bpastene@chromium.org> Date: Fri Sep 14 21:36:59 2018 Plumb a builder's target_os down to archive_build.py Bug: 789612 Change-Id: I38d7dc76f6106060310259566ecd4d62d337a0de Reviewed-on: https://chromium-review.googlesource.com/1226086 Reviewed-by: Stephen Martinis <martiniss@chromium.org> Reviewed-by: Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> [modify] https://crrev.com/3d2a5ddb88ae6d7266fd7e55ccf68ae913cb1087/scripts/slave/recipe_modules/chromium_tests/chromium_chromiumos.py [modify] https://crrev.com/3d2a5ddb88ae6d7266fd7e55ccf68ae913cb1087/scripts/slave/recipe_modules/chromium_tests/tests/api/archive_build.expected/archive_build.json [modify] https://crrev.com/3d2a5ddb88ae6d7266fd7e55ccf68ae913cb1087/scripts/slave/chromium/archive_build.py [modify] https://crrev.com/3d2a5ddb88ae6d7266fd7e55ccf68ae913cb1087/scripts/slave/recipe_modules/chromium/api.py
,
Sep 14
Starting with 591490, this should be fixed. (Not retroactive unfortunately). It's now packaging up libmini in the archive zip: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8935371779951341904/+/steps/archive_build/0/stdout Note that the zip file name changed from chrome-linux.zip to chrome-chromeos.zip. I'll close this out, but if that filename change proves problematic (eg: bisect tool breaks) please reopen.
,
Oct 5
Still broken due to change in archive names, fixing here: https://chromium-review.googlesource.com/c/chromium/src/+/1259864
,
Oct 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e84e40bb849917b308f747659af851c963a46655 commit e84e40bb849917b308f747659af851c963a46655 Author: Dominic Mazzoni <dmazzoni@chromium.org> Date: Mon Oct 08 06:44:45 2018 Update the bisect script to check for new archive names Starting with revision 591483, the Chrome OS and Win archives are named chrome-chromeos.zip instead of chrome-linux.zip, and chrome-win.zip instead of chrome-win32.zip, respectively. TBR=robertocn@chromium.org Bug: 872783 , 789612 Change-Id: I3bc72fa47c6e54b9a0b25306048af9942c06c1fa Reviewed-on: https://chromium-review.googlesource.com/c/1259864 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#597490} [modify] https://crrev.com/e84e40bb849917b308f747659af851c963a46655/tools/bisect-builds.py
,
Oct 8
|
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by dmazz...@chromium.org
, Nov 29 2017