New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 789607 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug


Show other hotlists

Hotlists containing this issue:
XXX


Sign in to add a comment

We need to increase the number of increased files in cros chrome-sdk

Project Member Reported by yunlian@chromium.org, Nov 29 2017

Issue description

We want to enable ThinLTO on Chrome for performance and security reasons.
ThinLTO requires a large number of file descriptors, and we have
https://chromium-review.googlesource.com/c/chromiumos/chromite/+/540675
to change to increase it inside cros_sdk.

We need to find a way to increase it in chrome-sdk to make in the TestSimpleChromeWorkflow pass in the builtbot. (currently the number of allowed open file is 4096).
 
Labels: OS-Chrome
priority seems incorrect?
Labels: -Pri-3 Pri-2
Components: Infra>Client>ChromeOS
Owner: akes...@chromium.org
Cc: akes...@chromium.org steve...@chromium.org achuith@chromium.org
Owner: steve...@chromium.org
Status: Available (was: Untriaged)
+stevenjb, achuith. Have y'all touched chrome-sdk and know how this would be accomlpished?

Comment 6 by vapier@chromium.org, Nov 29 2017

as noted in the CL, i don't think this is something we can easily accomplish in chrome-sdk itself.  that doesn't run as root and doesn't gain root caps, and changing hard user limits is a privileged operations.

so we could change chrome-sdk to query the current hard/soft limits and raise the soft limit if it's too small for our needs, and throw an error if the hard limit isn't big enough.

however, we'd still need help on the cbuildbot side of things, or on the builder side of things (since resource limits are an overall user/login setting).
Owner: ----
Cc: dpranke@chromium.org
Project Member

Comment 9 by bugdroid1@chromium.org, Dec 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/6f1e2a7e49d7e689319d83c56dd475074b84c279

commit 6f1e2a7e49d7e689319d83c56dd475074b84c279
Author: Yunlian Jiang <yunlian@google.com>
Date: Mon Dec 11 05:51:04 2017

chrome_sdk: Disable thinlto on SimpleChrome

ThinLTO requires a lot more file descriptors. On buildbot matchine, the
default value is 4096 and it is not enough. As a workaround, we need
to disable thinlto on simple chrome workflow.

BUG=chromium:789607
TEST=TestSimpleChromeWorkflowStage passes with USE="thinlto" is set.

Change-Id: I3206611962bf15113b06b3c7cfd3f33ab6af35cd
Reviewed-on: https://chromium-review.googlesource.com/812113
Commit-Ready: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>

[modify] https://crrev.com/6f1e2a7e49d7e689319d83c56dd475074b84c279/cli/cros/cros_chrome_sdk.py

Components: Tools>ChromeOS-Toolchain
Components: Infra>Client>ChromeOS>CI
Components: -Infra>Client>ChromeOS
Is this still an issue?

What would the benefit to SimpleChrome be if we did up the file descriptors?
i think this is still valid, but we're leaving it on the toolchain team's plate as part of their general thinlto work
Owner: yunlian@chromium.org
Status: Assigned (was: Available)
ThinLTO should be disabled by default on Simple Chrome , but we need a mode where devs can use it from Simple Chrome. 

I agree that there would be value to supporting all of the same optimization options that we use inside the chroot in Simple Chrome (including any we may only use in official release builders).

This will require a combination of build team + chromite expertise to get working and support.

We should also re-examine TestSimpleChromeWorkflowStage and audit what we are testing on what builders:
* default dev setup (external)
* default dev setup (internal)
* PFQ/CQ build setup
* Release build setup (I'm not actually sure if this is different, but I heard something somewhere suggesting that we turn on additional optimization there?)


Sign in to add a comment