We need to increase the number of increased files in cros chrome-sdk |
|||||||||||
Issue descriptionWe want to enable ThinLTO on Chrome for performance and security reasons. ThinLTO requires a large number of file descriptors, and we have https://chromium-review.googlesource.com/c/chromiumos/chromite/+/540675 to change to increase it inside cros_sdk. We need to find a way to increase it in chrome-sdk to make in the TestSimpleChromeWorkflow pass in the builtbot. (currently the number of allowed open file is 4096).
,
Nov 29 2017
,
Nov 29 2017
,
Nov 29 2017
,
Nov 29 2017
+stevenjb, achuith. Have y'all touched chrome-sdk and know how this would be accomlpished?
,
Nov 29 2017
as noted in the CL, i don't think this is something we can easily accomplish in chrome-sdk itself. that doesn't run as root and doesn't gain root caps, and changing hard user limits is a privileged operations. so we could change chrome-sdk to query the current hard/soft limits and raise the soft limit if it's too small for our needs, and throw an error if the hard limit isn't big enough. however, we'd still need help on the cbuildbot side of things, or on the builder side of things (since resource limits are an overall user/login setting).
,
Nov 30 2017
,
Dec 9 2017
,
Dec 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/6f1e2a7e49d7e689319d83c56dd475074b84c279 commit 6f1e2a7e49d7e689319d83c56dd475074b84c279 Author: Yunlian Jiang <yunlian@google.com> Date: Mon Dec 11 05:51:04 2017 chrome_sdk: Disable thinlto on SimpleChrome ThinLTO requires a lot more file descriptors. On buildbot matchine, the default value is 4096 and it is not enough. As a workaround, we need to disable thinlto on simple chrome workflow. BUG=chromium:789607 TEST=TestSimpleChromeWorkflowStage passes with USE="thinlto" is set. Change-Id: I3206611962bf15113b06b3c7cfd3f33ab6af35cd Reviewed-on: https://chromium-review.googlesource.com/812113 Commit-Ready: Yunlian Jiang <yunlian@chromium.org> Tested-by: Yunlian Jiang <yunlian@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> [modify] https://crrev.com/6f1e2a7e49d7e689319d83c56dd475074b84c279/cli/cros/cros_chrome_sdk.py
,
Feb 5 2018
,
Mar 30 2018
,
Mar 30 2018
,
Jun 29 2018
Is this still an issue? What would the benefit to SimpleChrome be if we did up the file descriptors?
,
Jun 29 2018
i think this is still valid, but we're leaving it on the toolchain team's plate as part of their general thinlto work
,
Jun 29 2018
ThinLTO should be disabled by default on Simple Chrome , but we need a mode where devs can use it from Simple Chrome.
,
Jun 29 2018
I agree that there would be value to supporting all of the same optimization options that we use inside the chroot in Simple Chrome (including any we may only use in official release builders). This will require a combination of build team + chromite expertise to get working and support. We should also re-examine TestSimpleChromeWorkflowStage and audit what we are testing on what builders: * default dev setup (external) * default dev setup (internal) * PFQ/CQ build setup * Release build setup (I'm not actually sure if this is different, but I heard something somewhere suggesting that we turn on additional optimization there?) |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by llozano@chromium.org
, Nov 29 2017