New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 789605 link

Starred by 1 user
Status: WontFix
Owner:
jdonnelly@chromium.org
Closed: May 2018
Cc:
█ alonm@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug


Show other hotlists

Hotlists containing this issue:
XXX


Sign in to add a comment

Entity disambiguation suggestions are meant to have more than one shown

Project Member Reported by jdonnelly@chromium.org, Nov 29 2017 
Entity disambiguation suggestions are Search suggestions that are meant to allow the user to distinguish between two or more entities that share the same name. They add a type string to disambiguate between, for example: Madagascar ("Country in East Africa") and Madagascar ("2005 film") (see first attached screenshot).

The omnibox autocomplete logic, however, does not account for the fact that these suggestions are related. When mixing suggestions from multiple sources and truncating the resulting merged list, it will often omit one of the disambiguation suggestions. For example, see second attached screenshot.

The autocomplete logic should recognize when there are multiple disambiguation suggestions and attempt to include them as a set meant to be shown together rather than treating them as independent suggestions.
entity-disambiguation-multiple.png
130 KB View Download
entity-disambiguation-one.png
105 KB View Download

Comment 1 by mpear...@chromium.org, Nov 30 2017 

As far as I know, we should only omit suggestions under three conditions
- we hit the maximum number of suggestions per provider limit
- something else scores higher than the suggestion
- we hit the maximum number of suggestions in the dropdown limit

None of these seem to apply in the example screenshot you provide that shows only three suggestions, including one disambiguation suggestion.

How are the additional disambiguation suggestions getting dropped?  (Are you sure they're coming back from the server?)

Comment 2 by jdonnelly@chromium.org, Nov 30 2017 

Good question. Perhaps there's something else going on in the second screenshot. But I'm certain that when I did some testing a while back there were cases where more than one entity suggestion came back from the server but only one was shown (I think because of the "max # of suggestions in the dropdown" limit, though I'm not certain).

Comment 3 by alonm@google.com, Nov 30 2017

Cc: alonm@google.com

Comment 4 by alonm@google.com, Nov 30 2017 

FYI - I'm not familiar with debugging in Chrome, but when I tried this on the server side (with the chrome client id) all disambiguations were returned.

Comment 5 by jdonnelly@chromium.org, May 10 2018

Status: WontFix (was: Assigned)
This feature is being unlaunched in favor of rich entity suggestions.
►

Sign in to add a comment