New issue
Advanced search Search tips

Issue 789598 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task
STS
Team-Accessibility



Sign in to add a comment

Select-to-Speak integration tests

Project Member Reported by katie@chromium.org, Nov 29 2017

Issue description

Add browser tests and integration tests for select-to-speak.
This should cover:
Combining key and mouse events to get STS to start
Reading some part of a page
And more?
 

Comment 1 by lpalmaro@google.com, Nov 29 2017

Labels: STS

Comment 2 by katie@chromium.org, Nov 30 2017

Labels: -Pri-3 Pri-2
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad2869c08ee6eda404d8bb2d59705492785f969f

commit ad2869c08ee6eda404d8bb2d59705492785f969f
Author: Katie Dektar <katydek@google.com>
Date: Mon Dec 04 17:46:12 2017

Adds integration / browser tests for Select-to-Speak.

Adds a function to SpeechMonitor to block until a stop
event is called. This will be used in later tests.

Bug:  789598 
Change-Id: Id25069e60d472eed3bf363e9cf597d2fe07d91e2
Reviewed-on: https://chromium-review.googlesource.com/804415
Commit-Queue: Katie D <katie@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521379}
[modify] https://crrev.com/ad2869c08ee6eda404d8bb2d59705492785f969f/chrome/browser/chromeos/accessibility/select_to_speak_browsertest.cc
[modify] https://crrev.com/ad2869c08ee6eda404d8bb2d59705492785f969f/chrome/browser/chromeos/accessibility/speech_monitor.cc
[modify] https://crrev.com/ad2869c08ee6eda404d8bb2d59705492785f969f/chrome/browser/chromeos/accessibility/speech_monitor.h

Comment 4 by katie@chromium.org, Dec 4 2017

Status: Started (was: Untriaged)

Comment 5 by katie@chromium.org, Dec 5 2017

Labels: -Type-Bug Type-Task
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c124b83383cd929e10b26d545eaa6e7e323d138a

commit c124b83383cd929e10b26d545eaa6e7e323d138a
Author: Katie Dektar <katydek@google.com>
Date: Wed Dec 06 23:35:21 2017

Adds test to ensure Select-to-Speak gets mouse movements.

This would catch a regression that happened last week where mousemove
events were not passed properly to the background extension, should
it re-occur in the future.

Bug:  789598 
Change-Id: Idd61c1e63f9dfa4f0e87603b62b0cc0a31a34902
Reviewed-on: https://chromium-review.googlesource.com/806647
Commit-Queue: Katie D <katie@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522252}
[modify] https://crrev.com/c124b83383cd929e10b26d545eaa6e7e323d138a/ash/accessibility/accessibility_focus_ring_controller.cc
[modify] https://crrev.com/c124b83383cd929e10b26d545eaa6e7e323d138a/ash/accessibility/accessibility_focus_ring_controller.h
[modify] https://crrev.com/c124b83383cd929e10b26d545eaa6e7e323d138a/chrome/browser/chromeos/accessibility/select_to_speak_browsertest.cc

Comment 7 by katie@chromium.org, Dec 6 2017

Status: Fixed (was: Started)

Sign in to add a comment