Always use DecoderFactory to create decoders |
|||
Issue descriptioncurrently, DefaultRendererFactory uses a DecoderFactory and some built-in logic to add all the decoder types. this is mostly since it can't take a dependency on mojo for MojoVideoDecoder. however, it also makes the logic a bit convoluted. make one DefaultDecoderFactory that does the work of MojoDecoderFactory and DefaultRendererFactory::Create*Decoders .
,
Mar 24 2018
I'm interested to take this issue :)
,
May 4 2018
FWIW, Lizhi who has started the work: https://chromium-review.googlesource.com/c/chromium/src/+/983093
,
May 4 2018
Lizhi: Sorry I can't add you as the owner of this issue since "you are not a member of the project". To avoid the odd case where a task has been started without an owner, I'll assign this to liberato@ as the owner. Sorry for the confusion.
,
May 5 2018
XiaoHan: that's ok, I totally understand :)
,
May 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/511e203bf5c7bea87e177a4530aab074a858e66b commit 511e203bf5c7bea87e177a4530aab074a858e66b Author: Lizhi Fan <lizhi.fan@samsung.com> Date: Tue May 22 14:46:15 2018 Add DefaultDecoderFactory for all decoders make one DefaultDecoderFactory that does the work of MojoDecoderFactory and DefaultRendererFactory::Create*Decoders Bug: 789597 R=liberato@chromium.org, xhwang@chromium.org Change-Id: Idce0a0a8e69d72aa4d19d045343f47ea4975b93b Reviewed-on: https://chromium-review.googlesource.com/983093 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#560576} [modify] https://crrev.com/511e203bf5c7bea87e177a4530aab074a858e66b/content/renderer/media/media_factory.cc [modify] https://crrev.com/511e203bf5c7bea87e177a4530aab074a858e66b/media/base/decoder_factory.cc [modify] https://crrev.com/511e203bf5c7bea87e177a4530aab074a858e66b/media/base/decoder_factory.h [modify] https://crrev.com/511e203bf5c7bea87e177a4530aab074a858e66b/media/blink/webmediaplayer_impl_unittest.cc [modify] https://crrev.com/511e203bf5c7bea87e177a4530aab074a858e66b/media/mojo/clients/mojo_decoder_factory.cc [modify] https://crrev.com/511e203bf5c7bea87e177a4530aab074a858e66b/media/mojo/clients/mojo_decoder_factory.h [modify] https://crrev.com/511e203bf5c7bea87e177a4530aab074a858e66b/media/mojo/services/test_mojo_media_client.cc [modify] https://crrev.com/511e203bf5c7bea87e177a4530aab074a858e66b/media/mojo/services/test_mojo_media_client.h [modify] https://crrev.com/511e203bf5c7bea87e177a4530aab074a858e66b/media/renderers/BUILD.gn [add] https://crrev.com/511e203bf5c7bea87e177a4530aab074a858e66b/media/renderers/default_decoder_factory.cc [add] https://crrev.com/511e203bf5c7bea87e177a4530aab074a858e66b/media/renderers/default_decoder_factory.h [modify] https://crrev.com/511e203bf5c7bea87e177a4530aab074a858e66b/media/renderers/default_renderer_factory.cc |
|||
►
Sign in to add a comment |
|||
Comment 1 by julien.isorce@chromium.org
, Jan 7 2018