Findit has detected a flake at test TranslateLanguageBrowserTest.RecentTargetLanguage. Culprit (100.0% confidence): https://chromium-review.googlesource.com/q/I8be60e81db2476e83707c090b34a0c6d955bbd25 Regression range: https://crrev.com/2a92c0110e253df8d358b0d47a5a098595116566..690388494eca03a9d3427835b28e6fdfe5145520?pretty=fuller Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyxQELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKOAWNocm9taXVtLm1lbW9yeS9MaW51eCBDaHJvbWl1bSBPUyBBU2FuIExTYW4gVGVzdHMgKDEpLzI0OTYxL2Jyb3dzZXJfdGVzdHMvVkhKaGJuTnNZWFJsVEdGdVozVmhaMlZDY205M2MyVnlWR1Z6ZEM1U1pXTmxiblJVWVhKblpYUk1ZVzVuZFdGblpRPT0MCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA If this result was incorrect, apply the label Findit-Incorrect-Result, mark the bug as Untriaged and the component Tools>Test>Findit>Flakiness.
Revert in CQ: https://chromium-review.googlesource.com/c/chromium/src/+/799011
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/40ffa19684348c6e3ede1d06de00e3bf4728ccdf commit 40ffa19684348c6e3ede1d06de00e3bf4728ccdf Author: Timothy Loh <timloh@chromium.org> Date: Thu Nov 30 05:52:03 2017 Revert "Record and reuse most recent target language." This reverts commit 32365f399cf6f0cd7387480ed95c439ac85ac0b7. Reason for revert: Added test TranslateLanguageBrowserTest.RecentTargetLanguage is flaky e.g. see https://chromium-swarm.appspot.com/task?id=3a2181a949be7f10&refresh=10&show_raw=1 Check failed: expect_translate != bubble == nullptr (1 vs. 1) Original change's description: > Record and reuse most recent target language. > > This change introduces a synced preference that tracks the language > that the user most-recently chose as a target language. This language > is then offered as the default target language. > > Bug: 624604 > Change-Id: I8be60e81db2476e83707c090b34a0c6d955bbd25 > Reviewed-on: https://chromium-review.googlesource.com/757882 > Commit-Queue: Michael Martis <martis@chromium.org> > Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org> > Reviewed-by: Renjie Liu <renjieliu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#519975} TBR=hajimehoshi@chromium.org,renjieliu@chromium.org,martis@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 624604 , 789593 Change-Id: I8750661898b9cfd7ce888fce9ca43d0b5add699f Reviewed-on: https://chromium-review.googlesource.com/799011 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#520453} [modify] https://crrev.com/40ffa19684348c6e3ede1d06de00e3bf4728ccdf/chrome/browser/ui/translate/translate_bubble_test_utils.h [modify] https://crrev.com/40ffa19684348c6e3ede1d06de00e3bf4728ccdf/chrome/browser/ui/views/translate/translate_bubble_test_utils_views.cc [modify] https://crrev.com/40ffa19684348c6e3ede1d06de00e3bf4728ccdf/chrome/browser/ui/views/translate/translate_bubble_view.h [modify] https://crrev.com/40ffa19684348c6e3ede1d06de00e3bf4728ccdf/chrome/browser/ui/views/translate/translate_language_browsertest.cc [delete] https://crrev.com/332e801f018a773c9920c0551b4e765b3b422177/chrome/test/data/italian_page.html [modify] https://crrev.com/40ffa19684348c6e3ede1d06de00e3bf4728ccdf/components/translate/core/browser/translate_manager.cc [modify] https://crrev.com/40ffa19684348c6e3ede1d06de00e3bf4728ccdf/components/translate/core/browser/translate_manager_unittest.cc [modify] https://crrev.com/40ffa19684348c6e3ede1d06de00e3bf4728ccdf/components/translate/core/browser/translate_prefs.cc [modify] https://crrev.com/40ffa19684348c6e3ede1d06de00e3bf4728ccdf/components/translate/core/browser/translate_prefs.h [modify] https://crrev.com/40ffa19684348c6e3ede1d06de00e3bf4728ccdf/components/translate/core/browser/translate_ui_delegate.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e48850d972279a4ad261f741a21752f0f5ed7f1c commit e48850d972279a4ad261f741a21752f0f5ed7f1c Author: Michael Martis <martis@chromium.org> Date: Thu Nov 30 09:44:41 2017 Fixed flaky test for recent target language. This patch is exactly the same as https://chromium-review.googlesource.com/757882 except for new logic in NavigateToUrl. Bug: 789593 , 624604 Change-Id: I90cb4f640ca4296ae7d4a88bd17808ebe63566e9 Reviewed-on: https://chromium-review.googlesource.com/798816 Commit-Queue: Michael Martis <martis@chromium.org> Reviewed-by: Renjie Liu <renjieliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#520493} [modify] https://crrev.com/e48850d972279a4ad261f741a21752f0f5ed7f1c/chrome/browser/ui/translate/translate_bubble_test_utils.h [modify] https://crrev.com/e48850d972279a4ad261f741a21752f0f5ed7f1c/chrome/browser/ui/views/translate/translate_bubble_test_utils_views.cc [modify] https://crrev.com/e48850d972279a4ad261f741a21752f0f5ed7f1c/chrome/browser/ui/views/translate/translate_bubble_view.h [modify] https://crrev.com/e48850d972279a4ad261f741a21752f0f5ed7f1c/chrome/browser/ui/views/translate/translate_language_browsertest.cc [add] https://crrev.com/e48850d972279a4ad261f741a21752f0f5ed7f1c/chrome/test/data/italian_page.html [modify] https://crrev.com/e48850d972279a4ad261f741a21752f0f5ed7f1c/components/translate/core/browser/translate_manager.cc [modify] https://crrev.com/e48850d972279a4ad261f741a21752f0f5ed7f1c/components/translate/core/browser/translate_manager_unittest.cc [modify] https://crrev.com/e48850d972279a4ad261f741a21752f0f5ed7f1c/components/translate/core/browser/translate_prefs.cc [modify] https://crrev.com/e48850d972279a4ad261f741a21752f0f5ed7f1c/components/translate/core/browser/translate_prefs.h [modify] https://crrev.com/e48850d972279a4ad261f741a21752f0f5ed7f1c/components/translate/core/browser/translate_ui_delegate.cc
Comment 1 by wylieb@chromium.org
, Nov 29 2017