New issue
Advanced search Search tips

Issue 789591 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 22
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 1
Type: Bug

Blocking:
issue 696617



Sign in to add a comment

Temporarily turn on UserActivationV2 in M69 Canary

Project Member Reported by mustaq@chromium.org, Nov 29 2017

Issue description

We will turn on User Activation v2 (to replace UserGestureIndicator) temporarily in Canary/Dev to assess how the feature works in the wild.

This feature can be turned on through command-line flag
  --enable-features=UserActivationV2

See the blocked bug (Issue 696617) for details about the feature.
 

Comment 1 by mustaq@chromium.org, Nov 29 2017

Labels: -Pri-3 Pri-1
Please add affected OSs.

Comment 3 by mustaq@chromium.org, Nov 29 2017

Labels: OS-Android OS-Chrome OS-Fuchsia OS-iOS OS-Linux OS-Mac OS-Windows
Hi, this is tagged as a beta blocker for M64.  We're not that far out and this bug hasn't been updated in a while.  Ping?  Thanks...

Labels: -M-64 M-65
We found some breakages that need a closer look.  Since we won't be able to fix all the breakages quickly, we decided to hold it back from M64.
Labels: -OS-iOS
mustaq@,
Friendly ping to get an update on this issue as it is marked as beta blocker.
Thanks..!
Summary: Temporarily turn on UserActivationV2 in M65 Canary (was: Temporarily turn on UserActivationV2 in M64 Canary)
I will resume working on breakages by eow.
mustaq@ Gentle Ping! This issue is marked as RB-Beta, could you please let us know is there any latest update available on this issue?

Thanks!
This is WIP, trying to resolve test breakages in PasswordManager, Permissions and a few others.  There's still a chance to have all resolved by next week's branch; in the worst case I will defer to 66.
Blocking: 696617
This is getting marginal for M65 but there is still a slim hope.  I will update the bug by tomorrow eod (either close or defer-to-66).
Labels: -M-65 M-66
Summary: Temporarily turn on UserActivationV2 in M66 Canary (was: Temporarily turn on UserActivationV2 in M65 Canary)
Need more time to address all test failure, discovering newer kind of dependencies on scopes of UGIs.  E.g. a fix for PasswordManager tests now fires new test failures:
https://chromium-review.googlesource.com/c/chromium/src/+/871516
Friendly ping to get an update on this issue as it is marked as beta blocker.
Thanks..!
We tracking the regressions through  Issue 802294  (not marking it as a blocker because some regressions are expected).

Current status: done with layout tests, the remaining ones are expected.  Majority of the browser tests are also fixed (yayy), we have three more to go.


Friendly ping to get an update on this issue as it is marked as beta blocker.

Thanks..!
As M66 beta promotion is coming tentatively in March & requesting you to provide an update on the same as it is marked as beta blocker for M66.

Thanks..!
Blocking: 780556
Labels: -M-66 M-67
Last week we decided to focus on fixing OOPIFs first.  Our original plan was to tackle OOPIF during/after the beta but our priorities are different now.
Blocking: -780556
Blockedon: 780556
Friendly ping to get an update on this issue as it is marked as beta blocker.
Thanks..!

Comment 21 Deleted

A friendly reminder that M67 branch is coming soon on 04/12! Your bug is labelled as Beta ReleaseBlock, pls make sure to land the fix ASAP to trunk. This way we branch M67 from a high quality trunk. Thank you.
A friendly reminder that M67 branch is coming soon on 04/12! Your bug is labelled as Beta ReleaseBlock, pls make sure to land the fix ASAP to trunk. This way we branch M67 from a high quality trunk. Thank you.
mustaq@,
Gentle  ping to get an update on this issue as it is marked as beta blocker &  M67 branch is coming soon on 04/12!

Thanks..! 
Labels: -M-67 M-68
Summary: Temporarily turn on UserActivationV2 in M68 Canary (was: Temporarily turn on UserActivationV2 in M66 Canary)
We have a fix ready for review for the blocker bug ( Issue 780556 ) for a while now.  I am now working on a new browser test that doesn't work as expected (stalls).  Don't think we can hit 67.
Friendly ping to get an update on this issue as per C#25.
Thanks.
mustaq@, Please let us know any update on this issue as it is marked as beta blocker.
Thanks..!
We will resume test fixing tomorrow, will update current status by eow.
mustaq@, Please let us know any update on this issue as per C#28 
Thanks..!
This is at risk.

Last week we were able to fix most of the site-isolation failures we had (and also pass an old failure) except one, which turned out to be needing a fix that would touch v1 and v2.

We switched our direction to work on browser-side consumption for all user activation (v1 & v2) cases, see  Issue 780556  #c15.


As per c30: still at risk.  My investigation into browser-side consumption last week suggested some tricky corner cases but I am hopeful.
Friendly ping to get an update on this issue .
Thanks..!
We made good progress on browser side consumption last week: all ChromeSitePerProcessTests are passing locally now with UAv2.

On the other hand, we now have new wpt tests that are failing (the number of failures increased from 21 to 37 because of them).

Summary: still at risk.
Gentle ping to get an update on this issue .
Thanks..!
NextAction: 2018-05-24
Highly at risk, most like we are missing M68.  I will update the label by eow (before branch).

The main blocker now is webkit_layout_tests: the number of failures jumped to 426 last week (from 37 on May 10).  I didn't get a chance to dig into it but I *guess* some massive rebaselining could be the cause.

Our CL (crrev.com/c/967260) for OOPIF needs a minor fix around a popup-blocker icon.

Your bug is tagged as Release block Beta and we are branching in 2 days.Please have a fix ASAP.
Labels: -M-68 M-69
NextAction: ----
Summary: Temporarily turn on UserActivationV2 in M69 Canary (was: Temporarily turn on UserActivationV2 in M68 Canary)
It's impossible to fix both blockers in <2 days, so deferring the experiment.
Labels: -ReleaseBlock-Beta
Removing the RB-beta label after some discussion.  We will add this label *after* turning on the feature temporarily in Canary so that we never forget to remove it from Beta.
Mustaq, if you are planning to turning it off and on for testing wouldn't it be better to do through Finch trials?
Description: Show this description
Description: Show this description
Blockedon: -780556
Status: Fixed (was: Started)
This has been turned on through Finch on M69 Dev/Canary.

We avoided full turn on because skipping remaining test failures should be risky as we are seeing new test failures every few weeks.

Blockedon: 867599
Status: Assigned (was: Fixed)
Turning off the trial temporarily, will resume after fixing the blocker bug.
Labels: -M-69 M-71
Status: Started (was: Assigned)
Summary: Temporarily turn on UserActivationV2 in M71 Canary (was: Temporarily turn on UserActivationV2 in M69 Canary)
Will turn the finch trial back on from M71.
Blockedon: -867599
Labels: -M-71 M-69
Summary: Temporarily turn on UserActivationV2 in M69 Canary (was: Temporarily turn on UserActivationV2 in M71 Canary)
Can't turn on at m71,  Issue 867599  wasn't fixed before m71 branched.

I am "moving" the bug back to "M69" for posterity and closing it.  If we turn on finch later on, we will track through a new bug.
Status: Fixed (was: Started)

Sign in to add a comment