New issue
Advanced search Search tips

Issue 789590 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 672921



Sign in to add a comment

Rename ScrollBoundaryBehavior to OverscrollBehavior in Chromium

Project Member Reported by sunyunjia@chromium.org, Nov 29 2017

Issue description

The spec has made a decision to use "overscroll-behavior" name instead. [1]

 crbug.com/776776  has renamed this for the web-exposed APIs. We should complete the rename throughout the code base.

[1] https://github.com/WICG/scroll-boundary-behavior/issues/24
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2288e85346fc8f3f1a0c65949ce630a2fbb70c55

commit 2288e85346fc8f3f1a0c65949ce630a2fbb70c55
Author: Sandra Sun <sunyunjia@chromium.org>
Date: Thu Nov 30 22:50:16 2017

Rename ScrollBoundaryBehavior to OverscrollBehavior

The name change was decided here [1].

This patch renames every ScrollBoundaryBehavior in the codebase to OverscrollBehaior. It is a
follow-up patch of https://chromium-review.googlesource.com/c/chromium/src/+/737090

[1] https://github.com/WICG/overscroll-behavior/issues/24

Bug:  789590 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I43609da09f707ec0d09cab94c3b005007868a1b1
Reviewed-on: https://chromium-review.googlesource.com/797351
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Dimitri Glazkov <dglazkov@chromium.org>
Commit-Queue: Sandra Sun <sunyunjia@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520728}
[modify] https://crrev.com/2288e85346fc8f3f1a0c65949ce630a2fbb70c55/cc/BUILD.gn
[modify] https://crrev.com/2288e85346fc8f3f1a0c65949ce630a2fbb70c55/cc/blink/web_layer_impl.cc
[modify] https://crrev.com/2288e85346fc8f3f1a0c65949ce630a2fbb70c55/cc/blink/web_layer_impl.h
[modify] https://crrev.com/2288e85346fc8f3f1a0c65949ce630a2fbb70c55/cc/input/input_handler.h
[add] https://crrev.com/2288e85346fc8f3f1a0c65949ce630a2fbb70c55/cc/input/overscroll_behavior.h
[delete] https://crrev.com/a648b776f80a5039f7a78558b3acfb68975071dc/cc/input/scroll_boundary_behavior.h
[modify] https://crrev.com/2288e85346fc8f3f1a0c65949ce630a2fbb70c55/cc/input/scroll_state_data.h
[modify] https://crrev.com/2288e85346fc8f3f1a0c65949ce630a2fbb70c55/cc/layers/layer.cc
[modify] https://crrev.com/2288e85346fc8f3f1a0c65949ce630a2fbb70c55/cc/layers/layer.h
[modify] https://crrev.com/2288e85346fc8f3f1a0c65949ce630a2fbb70c55/cc/layers/layer_impl_test_properties.cc
[modify] https://crrev.com/2288e85346fc8f3f1a0c65949ce630a2fbb70c55/cc/layers/layer_impl_test_properties.h
[modify] https://crrev.com/2288e85346fc8f3f1a0c65949ce630a2fbb70c55/cc/trees/layer_tree_host.cc
[modify] https://crrev.com/2288e85346fc8f3f1a0c65949ce630a2fbb70c55/cc/trees/layer_tree_host.h
[modify] https://crrev.com/2288e85346fc8f3f1a0c65949ce630a2fbb70c55/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/2288e85346fc8f3f1a0c65949ce630a2fbb70c55/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/2288e85346fc8f3f1a0c65949ce630a2fbb70c55/cc/trees/layer_tree_impl.cc
[modify] https://crrev.com/2288e85346fc8f3f1a0c65949ce630a2fbb70c55/cc/trees/layer_tree_impl.h
[modify] https://crrev.com/2288e85346fc8f3f1a0c65949ce630a2fbb70c55/cc/trees/property_tree_builder.cc
[modify] https://crrev.com/2288e85346fc8f3f1a0c65949ce630a2fbb70c55/cc/trees/scroll_node.cc
[modify] https://crrev.com/2288e85346fc8f3f1a0c65949ce630a2fbb70c55/cc/trees/scroll_node.h
[modify] https://crrev.com/2288e85346fc8f3f1a0c65949ce630a2fbb70c55/chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper.h
[modify] https://crrev.com/2288e85346fc8f3f1a0c65949ce630a2fbb70c55/chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper.mm
[modify] https://crrev.com/2288e85346fc8f3f1a0c65949ce630a2fbb70c55/chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper_unit_test.mm
[modify] https://crrev.com/2288e85346fc8f3f1a0c65949ce630a2fbb70c55/content/browser/android/overscroll_controller_android.cc
[modify] https://crrev.com/2288e85346fc8f3f1a0c65949ce630a2fbb70c55/content/browser/android/overscroll_controller_android_unittest.cc
[modify] https://crrev.com/2288e85346fc8f3f1a0c65949ce630a2fbb70c55/content/common/input_messages.h
[modify] https://crrev.com/2288e85346fc8f3f1a0c65949ce630a2fbb70c55/content/renderer/gpu/render_widget_compositor.cc
[modify] https://crrev.com/2288e85346fc8f3f1a0c65949ce630a2fbb70c55/content/renderer/gpu/render_widget_compositor.h
[modify] https://crrev.com/2288e85346fc8f3f1a0c65949ce630a2fbb70c55/content/renderer/input/input_handler_wrapper.cc
[modify] https://crrev.com/2288e85346fc8f3f1a0c65949ce630a2fbb70c55/content/renderer/input/input_handler_wrapper.h
[modify] https://crrev.com/2288e85346fc8f3f1a0c65949ce630a2fbb70c55/content/renderer/input/render_widget_input_handler.cc
[modify] https://crrev.com/2288e85346fc8f3f1a0c65949ce630a2fbb70c55/content/renderer/input/render_widget_input_handler.h
[modify] https://crrev.com/2288e85346fc8f3f1a0c65949ce630a2fbb70c55/content/renderer/input/widget_input_handler_manager.cc
[modify] https://crrev.com/2288e85346fc8f3f1a0c65949ce630a2fbb70c55/content/renderer/input/widget_input_handler_manager.h
[modify] https://crrev.com/2288e85346fc8f3f1a0c65949ce630a2fbb70c55/content/renderer/render_view_impl.cc
[modify] https://crrev.com/2288e85346fc8f3f1a0c65949ce630a2fbb70c55/content/renderer/render_view_impl.h
[modify] https://crrev.com/2288e85346fc8f3f1a0c65949ce630a2fbb70c55/content/renderer/render_widget.cc
[modify] https://crrev.com/2288e85346fc8f3f1a0c65949ce630a2fbb70c55/content/renderer/render_widget.h
[modify] https://crrev.com/2288e85346fc8f3f1a0c65949ce630a2fbb70c55/content/renderer/render_widget_unittest.cc
[modify] https://crrev.com/2288e85346fc8f3f1a0c65949ce630a2fbb70c55/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/2288e85346fc8f3f1a0c65949ce630a2fbb70c55/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/2288e85346fc8f3f1a0c65949ce630a2fbb70c55/third_party/WebKit/Source/core/css/parser/CSS.proto
[modify] https://crrev.com/2288e85346fc8f3f1a0c65949ce630a2fbb70c55/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/2288e85346fc8f3f1a0c65949ce630a2fbb70c55/third_party/WebKit/Source/core/exported/WebFrameTest.cpp
[modify] https://crrev.com/2288e85346fc8f3f1a0c65949ce630a2fbb70c55/third_party/WebKit/Source/core/exported/WebViewImpl.cpp
[modify] https://crrev.com/2288e85346fc8f3f1a0c65949ce630a2fbb70c55/third_party/WebKit/Source/core/exported/WebViewImpl.h
[modify] https://crrev.com/2288e85346fc8f3f1a0c65949ce630a2fbb70c55/third_party/WebKit/Source/core/input/OverscrollBehaviorTest.cpp
[delete] https://crrev.com/a648b776f80a5039f7a78558b3acfb68975071dc/third_party/WebKit/Source/core/input/ScrollBoundaryBehaviorTest.cpp
[modify] https://crrev.com/2288e85346fc8f3f1a0c65949ce630a2fbb70c55/third_party/WebKit/Source/core/input/ScrollManager.cpp
[modify] https://crrev.com/2288e85346fc8f3f1a0c65949ce630a2fbb70c55/third_party/WebKit/Source/core/loader/EmptyClients.h
[modify] https://crrev.com/2288e85346fc8f3f1a0c65949ce630a2fbb70c55/third_party/WebKit/Source/core/page/ChromeClient.h
[modify] https://crrev.com/2288e85346fc8f3f1a0c65949ce630a2fbb70c55/third_party/WebKit/Source/core/page/ChromeClientImpl.cpp
[modify] https://crrev.com/2288e85346fc8f3f1a0c65949ce630a2fbb70c55/third_party/WebKit/Source/core/page/ChromeClientImpl.h
[modify] https://crrev.com/2288e85346fc8f3f1a0c65949ce630a2fbb70c55/third_party/WebKit/Source/core/page/scrolling/OverscrollController.cpp
[modify] https://crrev.com/2288e85346fc8f3f1a0c65949ce630a2fbb70c55/third_party/WebKit/Source/core/page/scrolling/OverscrollController.h
[modify] https://crrev.com/2288e85346fc8f3f1a0c65949ce630a2fbb70c55/third_party/WebKit/Source/core/page/scrolling/RootScrollerTest.cpp
[modify] https://crrev.com/2288e85346fc8f3f1a0c65949ce630a2fbb70c55/third_party/WebKit/Source/core/paint/compositing/CompositedLayerMapping.cpp
[modify] https://crrev.com/2288e85346fc8f3f1a0c65949ce630a2fbb70c55/third_party/WebKit/Source/core/paint/compositing/CompositedLayerMapping.h
[modify] https://crrev.com/2288e85346fc8f3f1a0c65949ce630a2fbb70c55/third_party/WebKit/Source/core/style/ComputedStyle.cpp
[modify] https://crrev.com/2288e85346fc8f3f1a0c65949ce630a2fbb70c55/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp
[modify] https://crrev.com/2288e85346fc8f3f1a0c65949ce630a2fbb70c55/third_party/WebKit/Source/platform/graphics/GraphicsLayer.h
[modify] https://crrev.com/2288e85346fc8f3f1a0c65949ce630a2fbb70c55/third_party/WebKit/Source/platform/runtime_enabled_features.json5
[modify] https://crrev.com/2288e85346fc8f3f1a0c65949ce630a2fbb70c55/third_party/WebKit/public/BUILD.gn
[modify] https://crrev.com/2288e85346fc8f3f1a0c65949ce630a2fbb70c55/third_party/WebKit/public/platform/WebLayer.h
[modify] https://crrev.com/2288e85346fc8f3f1a0c65949ce630a2fbb70c55/third_party/WebKit/public/platform/WebLayerTreeView.h
[add] https://crrev.com/2288e85346fc8f3f1a0c65949ce630a2fbb70c55/third_party/WebKit/public/platform/WebOverscrollBehavior.h
[delete] https://crrev.com/a648b776f80a5039f7a78558b3acfb68975071dc/third_party/WebKit/public/platform/WebScrollBoundaryBehavior.h
[modify] https://crrev.com/2288e85346fc8f3f1a0c65949ce630a2fbb70c55/third_party/WebKit/public/web/WebViewClient.h
[modify] https://crrev.com/2288e85346fc8f3f1a0c65949ce630a2fbb70c55/third_party/WebKit/public/web/WebWidgetClient.h
[modify] https://crrev.com/2288e85346fc8f3f1a0c65949ce630a2fbb70c55/ui/android/overscroll_refresh.h
[modify] https://crrev.com/2288e85346fc8f3f1a0c65949ce630a2fbb70c55/ui/events/blink/DEPS
[modify] https://crrev.com/2288e85346fc8f3f1a0c65949ce630a2fbb70c55/ui/events/blink/did_overscroll_params.h
[modify] https://crrev.com/2288e85346fc8f3f1a0c65949ce630a2fbb70c55/ui/events/blink/input_handler_proxy.cc
[modify] https://crrev.com/2288e85346fc8f3f1a0c65949ce630a2fbb70c55/ui/events/blink/input_handler_proxy_client.h
[modify] https://crrev.com/2288e85346fc8f3f1a0c65949ce630a2fbb70c55/ui/events/blink/input_handler_proxy_unittest.cc

Status: Fixed (was: Assigned)
Blocking: 672921

Sign in to add a comment