New issue
Advanced search Search tips

Issue 789583 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug

Blocking:
issue 784603



Sign in to add a comment

Position Find in Page with named layout guide

Project Member Reported by gambard@chromium.org, Nov 29 2017

Issue description

For now the Find in Page controller is using the toolbar frame to position itself.
It should used a named layout guide instead.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6e35ffb40e69d873bfc7435ff9cf10092d79fee2

commit 6e35ffb40e69d873bfc7435ff9cf10092d79fee2
Author: Gauthier Ambard <gambard@chromium.org>
Date: Fri Jan 05 11:46:45 2018

Use NamedLayoutGuide for FindInPage

This CL uses Named Layout Guide to get the omnibox frame used by
FindInPage.
It also fixes FindInPage as it was using a wrong omnibox frame. The
visible omnibox frame returned by the toolbar was correcting for the
invisible padding added by the background image of FindInPage.
This CL moves the correction to FindInPage.

The NamedLayoutGuide is only used in the clean toolbar as the current
toolbar doesn't use autolayout.

Bug:  789583 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ibeadc1c3e4fec041c49a02209b5f6c7cf6da5267
Reviewed-on: https://chromium-review.googlesource.com/852092
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527257}
[modify] https://crrev.com/6e35ffb40e69d873bfc7435ff9cf10092d79fee2/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/6e35ffb40e69d873bfc7435ff9cf10092d79fee2/ios/chrome/browser/ui/find_bar/find_bar_controller_ios.mm
[modify] https://crrev.com/6e35ffb40e69d873bfc7435ff9cf10092d79fee2/ios/chrome/browser/ui/toolbar/clean/toolbar_coordinator.h
[modify] https://crrev.com/6e35ffb40e69d873bfc7435ff9cf10092d79fee2/ios/chrome/browser/ui/toolbar/clean/toolbar_coordinator.mm
[modify] https://crrev.com/6e35ffb40e69d873bfc7435ff9cf10092d79fee2/ios/chrome/browser/ui/toolbar/clean/toolbar_view_controller.h
[modify] https://crrev.com/6e35ffb40e69d873bfc7435ff9cf10092d79fee2/ios/chrome/browser/ui/toolbar/clean/toolbar_view_controller.mm
[modify] https://crrev.com/6e35ffb40e69d873bfc7435ff9cf10092d79fee2/ios/chrome/browser/ui/toolbar/legacy_toolbar_coordinator.h
[modify] https://crrev.com/6e35ffb40e69d873bfc7435ff9cf10092d79fee2/ios/chrome/browser/ui/toolbar/public/legacy_toolbar_coordinator.h
[modify] https://crrev.com/6e35ffb40e69d873bfc7435ff9cf10092d79fee2/ios/chrome/browser/ui/toolbar/public/web_toolbar_controller_constants.h
[modify] https://crrev.com/6e35ffb40e69d873bfc7435ff9cf10092d79fee2/ios/chrome/browser/ui/toolbar/public/web_toolbar_controller_constants.mm
[modify] https://crrev.com/6e35ffb40e69d873bfc7435ff9cf10092d79fee2/ios/chrome/browser/ui/toolbar/toolbar_adapter.mm
[modify] https://crrev.com/6e35ffb40e69d873bfc7435ff9cf10092d79fee2/ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm

Owner: gambard@chromium.org
Status: Fixed (was: Available)
Fixing this as find in page using named layout guide for positioning itself. We could expand it by having the position be using more autolayout, but it will probably be fixed with the UI refresh as Find in Page is changing.

Sign in to add a comment