Gaia is extending the Dice header with a "ENABLE_SYNC" action, which can be obtained by using a new endpoint. See the design doc: https://docs.google.com/a/google.com/document/d/1zaU4bPlmASIoWlQl2lCYxjIUfqHsvmiRsh4N6r21FWM/edit?usp=sharing
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1452832ce14ed71b48e4bb48dca5b7d23d24b88d commit 1452832ce14ed71b48e4bb48dca5b7d23d24b88d Author: David Roger <droger@chromium.org> Date: Wed Nov 29 17:29:32 2017 [signin] Parse the ENABLE_SYNC action in the Dice response header. Bug: 789578 Change-Id: I18b4189417a803a21b37bb1ab29f792ad53085d9 Reviewed-on: https://chromium-review.googlesource.com/796858 Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#520153} [modify] https://crrev.com/1452832ce14ed71b48e4bb48dca5b7d23d24b88d/chrome/browser/signin/chrome_signin_helper.cc [modify] https://crrev.com/1452832ce14ed71b48e4bb48dca5b7d23d24b88d/chrome/browser/signin/dice_response_handler.cc [modify] https://crrev.com/1452832ce14ed71b48e4bb48dca5b7d23d24b88d/chrome/browser/signin/dice_response_handler.h [modify] https://crrev.com/1452832ce14ed71b48e4bb48dca5b7d23d24b88d/chrome/browser/signin/dice_response_handler_unittest.cc [modify] https://crrev.com/1452832ce14ed71b48e4bb48dca5b7d23d24b88d/components/signin/core/browser/dice_header_helper.cc [modify] https://crrev.com/1452832ce14ed71b48e4bb48dca5b7d23d24b88d/components/signin/core/browser/signin_header_helper.cc [modify] https://crrev.com/1452832ce14ed71b48e4bb48dca5b7d23d24b88d/components/signin/core/browser/signin_header_helper.h [modify] https://crrev.com/1452832ce14ed71b48e4bb48dca5b7d23d24b88d/components/signin/core/browser/signin_header_helper_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2828d5e04f291bc0832d39220a1fb8802389415c commit 2828d5e04f291bc0832d39220a1fb8802389415c Author: Mihai Sardarescu <msarda@chromium.org> Date: Thu Nov 30 15:53:23 2017 [signin][dice] Process enable sync Gaia header. This changes the way sync is enabled when the DICE sign-in flow is used. 1. The refresh tokens are always fetched and then saved to the token service as soon as the auth code is received from Gaia. 2. Once Chrome receives the enable sync signal, Chrome starts sync for the account as informed by Gaia. This has a side effect when signing in to Chrome with an enterprise account. In this case if the user chooses to create a new profile, then the refresh token is not moved to the new profile and the user needs to sign in to Chrome in the new profile. Bug: 789578 Change-Id: Ic5174b80a3d891e7d84236279a36001ce5afe53c Reviewed-on: https://chromium-review.googlesource.com/796990 Reviewed-by: David Roger <droger@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#520554} [modify] https://crrev.com/2828d5e04f291bc0832d39220a1fb8802389415c/chrome/browser/signin/dice_response_handler.cc [modify] https://crrev.com/2828d5e04f291bc0832d39220a1fb8802389415c/chrome/browser/signin/dice_response_handler.h [modify] https://crrev.com/2828d5e04f291bc0832d39220a1fb8802389415c/chrome/browser/signin/dice_response_handler_unittest.cc [modify] https://crrev.com/2828d5e04f291bc0832d39220a1fb8802389415c/chrome/browser/signin/dice_tab_helper.cc [modify] https://crrev.com/2828d5e04f291bc0832d39220a1fb8802389415c/chrome/browser/signin/process_dice_header_delegate_impl.cc [modify] https://crrev.com/2828d5e04f291bc0832d39220a1fb8802389415c/chrome/browser/signin/process_dice_header_delegate_impl.h [modify] https://crrev.com/2828d5e04f291bc0832d39220a1fb8802389415c/chrome/browser/ui/sync/one_click_signin_sync_starter.cc [modify] https://crrev.com/2828d5e04f291bc0832d39220a1fb8802389415c/chrome/browser/ui/sync/one_click_signin_sync_starter.h [modify] https://crrev.com/2828d5e04f291bc0832d39220a1fb8802389415c/chrome/browser/ui/webui/signin/dice_turn_sync_on_helper.cc [modify] https://crrev.com/2828d5e04f291bc0832d39220a1fb8802389415c/chrome/browser/ui/webui/signin/dice_turn_sync_on_helper.h [modify] https://crrev.com/2828d5e04f291bc0832d39220a1fb8802389415c/components/signin/core/browser/signin_manager.cc [modify] https://crrev.com/2828d5e04f291bc0832d39220a1fb8802389415c/components/signin/core/browser/signin_manager.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8bb5b3b238ddfacbb203fe61727a3de29baae5ad commit 8bb5b3b238ddfacbb203fe61727a3de29baae5ad Author: David Roger <droger@chromium.org> Date: Thu Nov 30 16:15:01 2017 [signin] Add feature flag to enable new Gaia signin endpoint This endpoint is not ready yet, but this CL adds a feature flag that will be toggled once it is ready. Bug: 789578 Change-Id: I94670b980f8d34f3a394d404858f31cf4a95b4ac Reviewed-on: https://chromium-review.googlesource.com/800631 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#520559} [modify] https://crrev.com/8bb5b3b238ddfacbb203fe61727a3de29baae5ad/chrome/browser/about_flags.cc [modify] https://crrev.com/8bb5b3b238ddfacbb203fe61727a3de29baae5ad/chrome/browser/signin/account_reconcilor_factory.cc [modify] https://crrev.com/8bb5b3b238ddfacbb203fe61727a3de29baae5ad/chrome/browser/signin/dice_browsertest.cc [modify] https://crrev.com/8bb5b3b238ddfacbb203fe61727a3de29baae5ad/components/signin/core/browser/about_signin_internals.cc [modify] https://crrev.com/8bb5b3b238ddfacbb203fe61727a3de29baae5ad/components/signin/core/browser/account_reconcilor_unittest.cc [modify] https://crrev.com/8bb5b3b238ddfacbb203fe61727a3de29baae5ad/components/signin/core/browser/profile_management_switches.cc [modify] https://crrev.com/8bb5b3b238ddfacbb203fe61727a3de29baae5ad/components/signin/core/browser/profile_management_switches.h [modify] https://crrev.com/8bb5b3b238ddfacbb203fe61727a3de29baae5ad/components/signin/core/browser/profile_management_switches_unittest.cc [modify] https://crrev.com/8bb5b3b238ddfacbb203fe61727a3de29baae5ad/components/signin/core/browser/scoped_account_consistency.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cc55e2950bbb28e91e6d5a5208182bbc8ed7cedd commit cc55e2950bbb28e91e6d5a5208182bbc8ed7cedd Author: Mihai Sardarescu <msarda@chromium.org> Date: Thu Nov 30 18:07:31 2017 [signin] Use the new Chrome sync endpoint when signing in to Chrome with DICE. This CL uses the /signin/chrome/sync Gaia endpoint when signing in to Chrome when DICE is enabled. Bug: 789578 Change-Id: Ide40f5b7cc1d3f34f07a482f369d6826c1e2ca29 Reviewed-on: https://chromium-review.googlesource.com/800619 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#520599} [modify] https://crrev.com/cc55e2950bbb28e91e6d5a5208182bbc8ed7cedd/chrome/browser/signin/dice_tab_helper.cc [modify] https://crrev.com/cc55e2950bbb28e91e6d5a5208182bbc8ed7cedd/chrome/browser/signin/signin_promo.cc [modify] https://crrev.com/cc55e2950bbb28e91e6d5a5208182bbc8ed7cedd/chrome/browser/signin/signin_promo.h [modify] https://crrev.com/cc55e2950bbb28e91e6d5a5208182bbc8ed7cedd/chrome/browser/signin/signin_util.cc [modify] https://crrev.com/cc55e2950bbb28e91e6d5a5208182bbc8ed7cedd/chrome/browser/signin/signin_util.h [modify] https://crrev.com/cc55e2950bbb28e91e6d5a5208182bbc8ed7cedd/chrome/browser/ui/signin_view_controller.cc [modify] https://crrev.com/cc55e2950bbb28e91e6d5a5208182bbc8ed7cedd/chrome/browser/ui/signin_view_controller.h [modify] https://crrev.com/cc55e2950bbb28e91e6d5a5208182bbc8ed7cedd/chrome/browser/ui/sync/one_click_signin_sync_starter.cc [modify] https://crrev.com/cc55e2950bbb28e91e6d5a5208182bbc8ed7cedd/chrome/browser/ui/sync/one_click_signin_sync_starter.h [modify] https://crrev.com/cc55e2950bbb28e91e6d5a5208182bbc8ed7cedd/google_apis/gaia/gaia_urls.cc [modify] https://crrev.com/cc55e2950bbb28e91e6d5a5208182bbc8ed7cedd/google_apis/gaia/gaia_urls.h
Merge request for CLs: https://chromium-review.googlesource.com/796990 https://chromium-review.googlesource.com/800631 https://chromium-review.googlesource.com/800619 They all landed on branch day, but after the cutoff.
Oops, seems the CL are actually on the branch already. Cancelling merge request.
Comment 1 by bugdroid1@chromium.org
, Nov 29 2017