New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 789577 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 796035
issue 689549



Sign in to add a comment

Deprecate and remove the old navigation codepath

Project Member Reported by clamy@chromium.org, Nov 29 2017

Issue description

Once PlzNavigate has fully launched, we'll be able to deprecate and remove the old navigation codepath from the code base.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6700070029814fa77c7b377b7eb65e8c80145afb

commit 6700070029814fa77c7b377b7eb65e8c80145afb
Author: clamy <clamy@chromium.org>
Date: Wed Nov 29 18:06:43 2017

Remove BrowserSideNavigation from about://flags

BrowserSideNavigation has launched on all chromium platforms (except Android WebView), and the old
navigation codepath is no longer supported at the Chrome layer. Removing
the option to turn off browser-side navigation in regular Chrome.

BUG=789577

Change-Id: I6e450f1e33108aa5b5cfe5241a7fd3af188d6394
Reviewed-on: https://chromium-review.googlesource.com/796857
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520162}
[modify] https://crrev.com/6700070029814fa77c7b377b7eb65e8c80145afb/chrome/browser/about_flags.cc
[modify] https://crrev.com/6700070029814fa77c7b377b7eb65e8c80145afb/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/6700070029814fa77c7b377b7eb65e8c80145afb/chrome/browser/flag_descriptions.h

Comment 2 by nasko@chromium.org, Nov 29 2017

Cc: creis@chromium.org

Comment 3 by creis@chromium.org, Nov 29 2017

Components: UI>Browser>Navigation
Labels: Proj-PlzNavigate
Are we starting this removal (based on comment 1)?  Or is Android Webview still a blocker?  Is there a bug for that?

Comment 4 by nasko@chromium.org, Nov 29 2017

My assumption is that this work isn't starting yet, until we know Android WebView is ready. The tracking bug for that work is issue 766255.

Comment 5 by clamy@chromium.org, Nov 30 2017

For most of the old code, which lives inside content/, we'll have to wait until Android WebView is ready. I'll update this bug and close the PlzNavigate launch when that's the case.

However, I'm starting the work in the chrome/ layer right now. It is not used by WebView, and the old code path is not tested and maintained anymore, so we can start removing out the old code there. My plan is the following:
1) Remove browser side navigation from chrome://flags (done)
2) Clean up the old code in browser_tests & unit_tests (in progress)
3) Clean up the old code in chrome/.

The goal is not to have any usage of IsBrowserSideNavigation enabled or any mention of PlzNavigate in chrome/ once 2 and 3 are done.

Comment 6 by kbr@chromium.org, Dec 19 2017

Blockedon: 796035
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9093bf442222fd49b3616b77f31272ad8e90ff80

commit 9093bf442222fd49b3616b77f31272ad8e90ff80
Author: clamy <clamy@chromium.org>
Date: Tue Dec 19 18:17:01 2017

Deprecate renderer-side navigation

Following the launch of PlzNavigate, this CL deprecates the old
navigation architecture. Following this CL, the old navigation codepath
will no longer be tested.

Bug=789577

Change-Id: I1ceb5c81748c05f8777f057e84b8c52acf0d753c
Reviewed-on: https://chromium-review.googlesource.com/772231
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525086}
[modify] https://crrev.com/9093bf442222fd49b3616b77f31272ad8e90ff80/testing/buildbot/chromium.android.json
[modify] https://crrev.com/9093bf442222fd49b3616b77f31272ad8e90ff80/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/9093bf442222fd49b3616b77f31272ad8e90ff80/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/9093bf442222fd49b3616b77f31272ad8e90ff80/testing/buildbot/test_suite_exceptions.pyl
[modify] https://crrev.com/9093bf442222fd49b3616b77f31272ad8e90ff80/testing/buildbot/test_suites.pyl
[modify] https://crrev.com/9093bf442222fd49b3616b77f31272ad8e90ff80/testing/buildbot/waterfalls.pyl

Project Member

Comment 8 by bugdroid1@chromium.org, Dec 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05c0006e3a511fa6f71257c65c7a804fbd7f495d

commit 05c0006e3a511fa6f71257c65c7a804fbd7f495d
Author: clamy <clamy@chromium.org>
Date: Wed Dec 20 15:01:17 2017

Always enable PlzNavigate

This CL ensures that PlzNavigate aka browser-side navigation is always
enabled. Renderer-side navigation is no longer supported.

BUG= 789577

Change-Id: Icc8f99966ae562799ebd44d077287970702d642f
Reviewed-on: https://chromium-review.googlesource.com/832651
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525330}
[modify] https://crrev.com/05c0006e3a511fa6f71257c65c7a804fbd7f495d/content/browser/service_worker/service_worker_process_manager_unittest.cc
[modify] https://crrev.com/05c0006e3a511fa6f71257c65c7a804fbd7f495d/content/public/common/browser_side_navigation_policy.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Dec 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/583eb8a034ad2d2b8cd0f961a4db2a2fa1bf0f71

commit 583eb8a034ad2d2b8cd0f961a4db2a2fa1bf0f71
Author: clamy <clamy@chromium.org>
Date: Wed Dec 20 18:51:59 2017

Remove NavigationResourceThrottle

This CL removes the class NavigationResourceThrottle which is no longer
used. Also removes several ResourceDispatcherHostTests using it that are
now obsolete due to the navigation architecture change.

Bug=789577

Change-Id: Ia9718ff161ef942b64218106be29b8530df8eca1
Reviewed-on: https://chromium-review.googlesource.com/776894
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525388}
[modify] https://crrev.com/583eb8a034ad2d2b8cd0f961a4db2a2fa1bf0f71/content/browser/BUILD.gn
[delete] https://crrev.com/0df8abc8afa9f36f6a039eb3912e31fa19b6c189/content/browser/loader/navigation_resource_throttle.cc
[delete] https://crrev.com/0df8abc8afa9f36f6a039eb3912e31fa19b6c189/content/browser/loader/navigation_resource_throttle.h
[modify] https://crrev.com/583eb8a034ad2d2b8cd0f961a4db2a2fa1bf0f71/content/browser/loader/navigation_url_loader_network_service.cc
[modify] https://crrev.com/583eb8a034ad2d2b8cd0f961a4db2a2fa1bf0f71/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/583eb8a034ad2d2b8cd0f961a4db2a2fa1bf0f71/content/browser/loader/resource_dispatcher_host_unittest.cc
[modify] https://crrev.com/583eb8a034ad2d2b8cd0f961a4db2a2fa1bf0f71/content/browser/loader/url_loader_factory_impl_unittest.cc

Project Member

Comment 10 by bugdroid1@chromium.org, Dec 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/37020db3052c52ecd554e7528d056f6c11242f30

commit 37020db3052c52ecd554e7528d056f6c11242f30
Author: clamy <clamy@chromium.org>
Date: Wed Dec 20 19:14:39 2017

Remove browser-side navigation from content switches

This CL removes the command line switches
--enable-browser-side-navigation and --disable-browser-side-navigation.
They are no longer used: browser-side-navigation is now always on.

BUG=789577

Change-Id: I98745f58ba9ae752b70b35dadbb9e506618134cb
Reviewed-on: https://chromium-review.googlesource.com/837047
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525397}
[modify] https://crrev.com/37020db3052c52ecd554e7528d056f6c11242f30/content/browser/browser_side_navigation_browsertest.cc
[modify] https://crrev.com/37020db3052c52ecd554e7528d056f6c11242f30/content/browser/frame_host/navigation_controller_impl_unittest.cc
[modify] https://crrev.com/37020db3052c52ecd554e7528d056f6c11242f30/content/browser/frame_host/navigation_handle_impl_browsertest.cc
[modify] https://crrev.com/37020db3052c52ecd554e7528d056f6c11242f30/content/browser/frame_host/navigation_handle_impl_unittest.cc
[modify] https://crrev.com/37020db3052c52ecd554e7528d056f6c11242f30/content/browser/frame_host/navigator_impl_unittest.cc
[modify] https://crrev.com/37020db3052c52ecd554e7528d056f6c11242f30/content/browser/frame_host/render_frame_host_manager_unittest.cc
[modify] https://crrev.com/37020db3052c52ecd554e7528d056f6c11242f30/content/browser/loader/navigation_url_loader_network_service_unittest.cc
[modify] https://crrev.com/37020db3052c52ecd554e7528d056f6c11242f30/content/browser/loader/navigation_url_loader_unittest.cc
[modify] https://crrev.com/37020db3052c52ecd554e7528d056f6c11242f30/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/37020db3052c52ecd554e7528d056f6c11242f30/content/browser/service_worker/service_worker_provider_host_unittest.cc
[modify] https://crrev.com/37020db3052c52ecd554e7528d056f6c11242f30/content/public/common/content_features.cc
[modify] https://crrev.com/37020db3052c52ecd554e7528d056f6c11242f30/content/public/common/content_features.h
[modify] https://crrev.com/37020db3052c52ecd554e7528d056f6c11242f30/content/public/common/content_switches.cc
[modify] https://crrev.com/37020db3052c52ecd554e7528d056f6c11242f30/content/public/common/content_switches.h
[modify] https://crrev.com/37020db3052c52ecd554e7528d056f6c11242f30/content/public/test/browser_side_navigation_test_utils.cc
[modify] https://crrev.com/37020db3052c52ecd554e7528d056f6c11242f30/content/public/test/browser_side_navigation_test_utils.h
[modify] https://crrev.com/37020db3052c52ecd554e7528d056f6c11242f30/content/renderer/loader/web_url_loader_impl_unittest.cc
[modify] https://crrev.com/37020db3052c52ecd554e7528d056f6c11242f30/content/renderer/service_worker/service_worker_context_client_unittest.cc
[modify] https://crrev.com/37020db3052c52ecd554e7528d056f6c11242f30/content/renderer/service_worker/service_worker_timeout_timer_unittest.cc

Project Member

Comment 11 by bugdroid1@chromium.org, Dec 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/79ef8de31fffb49d3db57514781944672d23b8d0

commit 79ef8de31fffb49d3db57514781944672d23b8d0
Author: clamy <clamy@chromium.org>
Date: Thu Dec 21 11:04:46 2017

Clear old navigation code from NavigationHandle

This CL removes code related to the old navigation code path from
NavigationHandleImpl. It also starts removing some of the old transfer
navigation logic.

Bug: 789577
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: I8037d4049d40f9886f261c81a0182754e66adf10
Reviewed-on: https://chromium-review.googlesource.com/776856
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525666}
[modify] https://crrev.com/79ef8de31fffb49d3db57514781944672d23b8d0/content/browser/frame_host/navigation_handle_impl.cc
[modify] https://crrev.com/79ef8de31fffb49d3db57514781944672d23b8d0/content/browser/frame_host/navigation_handle_impl.h
[modify] https://crrev.com/79ef8de31fffb49d3db57514781944672d23b8d0/content/browser/frame_host/navigation_handle_impl_unittest.cc
[modify] https://crrev.com/79ef8de31fffb49d3db57514781944672d23b8d0/content/browser/frame_host/navigation_request.cc
[modify] https://crrev.com/79ef8de31fffb49d3db57514781944672d23b8d0/content/browser/frame_host/navigator_impl.cc
[modify] https://crrev.com/79ef8de31fffb49d3db57514781944672d23b8d0/content/browser/frame_host/render_frame_host_manager.cc
[modify] https://crrev.com/79ef8de31fffb49d3db57514781944672d23b8d0/content/browser/frame_host/render_frame_host_manager.h
[modify] https://crrev.com/79ef8de31fffb49d3db57514781944672d23b8d0/content/public/test/navigation_simulator.cc

Project Member

Comment 12 by bugdroid1@chromium.org, Dec 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3397c7bc146e3080e867c15cbbaf5659c545c87e

commit 3397c7bc146e3080e867c15cbbaf5659c545c87e
Author: clamy <clamy@chromium.org>
Date: Thu Dec 21 13:16:30 2017

Clean up NavigationSimulator

This CL removes code from the old navigation architecture from
NavigationSimulator.

Bug: 789577
Change-Id: I890f9d653628e42cea5492bb114d576f879c5abe
Reviewed-on: https://chromium-review.googlesource.com/776855
Commit-Queue: Camille Lamy <clamy@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525680}
[modify] https://crrev.com/3397c7bc146e3080e867c15cbbaf5659c545c87e/content/public/test/navigation_simulator.cc
[modify] https://crrev.com/3397c7bc146e3080e867c15cbbaf5659c545c87e/content/public/test/navigation_simulator.h

Project Member

Comment 13 by bugdroid1@chromium.org, Dec 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/093e340400fd22bc7e03a08e586e57e88adcc9c6

commit 093e340400fd22bc7e03a08e586e57e88adcc9c6
Author: clamy <clamy@chromium.org>
Date: Thu Dec 21 16:31:39 2017

Cleanup old navigation code in RenderFrameHostImpl

This CL removes the old navigation code (aka renderer-side navigation)
from RenderFrameHostImpl.

Bug: 789577
Change-Id: I76339c2c4a1713ba404977b0122ad01c3c18aa11
Reviewed-on: https://chromium-review.googlesource.com/839771
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525710}
[modify] https://crrev.com/093e340400fd22bc7e03a08e586e57e88adcc9c6/content/browser/frame_host/navigator_impl.cc
[modify] https://crrev.com/093e340400fd22bc7e03a08e586e57e88adcc9c6/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/093e340400fd22bc7e03a08e586e57e88adcc9c6/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/093e340400fd22bc7e03a08e586e57e88adcc9c6/content/browser/frame_host/render_frame_host_manager.cc
[modify] https://crrev.com/093e340400fd22bc7e03a08e586e57e88adcc9c6/content/browser/frame_host/render_frame_host_manager.h
[modify] https://crrev.com/093e340400fd22bc7e03a08e586e57e88adcc9c6/content/browser/frame_host/render_frame_host_manager_unittest.cc
[modify] https://crrev.com/093e340400fd22bc7e03a08e586e57e88adcc9c6/content/browser/web_contents/web_contents_impl_unittest.cc

Project Member

Comment 14 by bugdroid1@chromium.org, Dec 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/533b579a94bcb2636944b784ab83c19a8eb9e087

commit 533b579a94bcb2636944b784ab83c19a8eb9e087
Author: clamy <clamy@chromium.org>
Date: Thu Dec 21 19:33:54 2017

Cleanup old navigation code in Navigator

This CL removes old navigation code from Navigator*.

Bug: 789577
Change-Id: I86295fc66b9751f888081bc244004a1399a44a5a
Reviewed-on: https://chromium-review.googlesource.com/840240
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525768}
[modify] https://crrev.com/533b579a94bcb2636944b784ab83c19a8eb9e087/content/browser/frame_host/navigator.h
[modify] https://crrev.com/533b579a94bcb2636944b784ab83c19a8eb9e087/content/browser/frame_host/navigator_impl.cc
[modify] https://crrev.com/533b579a94bcb2636944b784ab83c19a8eb9e087/content/browser/frame_host/navigator_impl.h

Project Member

Comment 15 by bugdroid1@chromium.org, Dec 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/610c63b35c9432e0de9ad25581abf09eb76cf9bd

commit 610c63b35c9432e0de9ad25581abf09eb76cf9bd
Author: clamy <clamy@chromium.org>
Date: Fri Dec 22 16:43:04 2017

Remove old navigation code from RenderFrameHostManager

This CL cleans up the old navigation code from RenderFrameHostManager.

Bug: 789577
Change-Id: Ib7b01df9e7fd3b87361f386725837e4022c4c454
Reviewed-on: https://chromium-review.googlesource.com/840030
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526007}
[modify] https://crrev.com/610c63b35c9432e0de9ad25581abf09eb76cf9bd/chrome/browser/prerender/prerender_contents.cc
[modify] https://crrev.com/610c63b35c9432e0de9ad25581abf09eb76cf9bd/chrome/browser/prerender/prerender_contents.h
[modify] https://crrev.com/610c63b35c9432e0de9ad25581abf09eb76cf9bd/chrome/browser/prerender/prerender_final_status.h
[modify] https://crrev.com/610c63b35c9432e0de9ad25581abf09eb76cf9bd/chrome/browser/prerender/prerender_manager.cc
[modify] https://crrev.com/610c63b35c9432e0de9ad25581abf09eb76cf9bd/content/browser/devtools/render_frame_devtools_agent_host.cc
[modify] https://crrev.com/610c63b35c9432e0de9ad25581abf09eb76cf9bd/content/browser/frame_host/frame_tree_node.cc
[modify] https://crrev.com/610c63b35c9432e0de9ad25581abf09eb76cf9bd/content/browser/frame_host/navigator_impl_unittest.cc
[modify] https://crrev.com/610c63b35c9432e0de9ad25581abf09eb76cf9bd/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/610c63b35c9432e0de9ad25581abf09eb76cf9bd/content/browser/frame_host/render_frame_host_manager.cc
[modify] https://crrev.com/610c63b35c9432e0de9ad25581abf09eb76cf9bd/content/browser/frame_host/render_frame_host_manager.h
[modify] https://crrev.com/610c63b35c9432e0de9ad25581abf09eb76cf9bd/content/browser/frame_host/render_frame_host_manager_browsertest.cc
[modify] https://crrev.com/610c63b35c9432e0de9ad25581abf09eb76cf9bd/content/browser/frame_host/render_frame_host_manager_unittest.cc
[modify] https://crrev.com/610c63b35c9432e0de9ad25581abf09eb76cf9bd/content/browser/screen_orientation/screen_orientation_browsertest.cc
[modify] https://crrev.com/610c63b35c9432e0de9ad25581abf09eb76cf9bd/content/browser/security_exploit_browsertest.cc
[modify] https://crrev.com/610c63b35c9432e0de9ad25581abf09eb76cf9bd/content/browser/site_per_process_browsertest.cc
[modify] https://crrev.com/610c63b35c9432e0de9ad25581abf09eb76cf9bd/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/610c63b35c9432e0de9ad25581abf09eb76cf9bd/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/610c63b35c9432e0de9ad25581abf09eb76cf9bd/content/public/browser/web_contents.h
[modify] https://crrev.com/610c63b35c9432e0de9ad25581abf09eb76cf9bd/content/public/test/test_renderer_host.cc
[modify] https://crrev.com/610c63b35c9432e0de9ad25581abf09eb76cf9bd/content/test/content_browser_test_utils_internal.cc
[modify] https://crrev.com/610c63b35c9432e0de9ad25581abf09eb76cf9bd/content/test/test_web_contents.cc

Project Member

Comment 16 by bugdroid1@chromium.org, Dec 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/15562b02f265c6cc73ed2f0dada6c30a993b39c2

commit 15562b02f265c6cc73ed2f0dada6c30a993b39c2
Author: clamy <clamy@chromium.org>
Date: Fri Dec 22 17:40:11 2017

Cleanup old navigation code in RenderFrameImpl

This CL cleans up the old navigation code from RenderFrameImpl. In
particular, it removes the StartNavigationParams and the
FrameMsg_Navigate IPC, which are no longer used.

Bug: 789577
Change-Id: I3c4e7a1ed8b735095f05234acaabbbe028c45156
Reviewed-on: https://chromium-review.googlesource.com/842543
Commit-Queue: Camille Lamy <clamy@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526017}
[modify] https://crrev.com/15562b02f265c6cc73ed2f0dada6c30a993b39c2/content/browser/frame_host/navigation_controller_impl_unittest.cc
[modify] https://crrev.com/15562b02f265c6cc73ed2f0dada6c30a993b39c2/content/browser/frame_host/navigation_entry_impl.cc
[modify] https://crrev.com/15562b02f265c6cc73ed2f0dada6c30a993b39c2/content/browser/frame_host/navigation_entry_impl.h
[modify] https://crrev.com/15562b02f265c6cc73ed2f0dada6c30a993b39c2/content/common/frame_messages.h
[modify] https://crrev.com/15562b02f265c6cc73ed2f0dada6c30a993b39c2/content/common/navigation_params.cc
[modify] https://crrev.com/15562b02f265c6cc73ed2f0dada6c30a993b39c2/content/common/navigation_params.h
[modify] https://crrev.com/15562b02f265c6cc73ed2f0dada6c30a993b39c2/content/public/test/render_view_test.cc
[modify] https://crrev.com/15562b02f265c6cc73ed2f0dada6c30a993b39c2/content/renderer/loader/request_extra_data.cc
[modify] https://crrev.com/15562b02f265c6cc73ed2f0dada6c30a993b39c2/content/renderer/loader/request_extra_data.h
[modify] https://crrev.com/15562b02f265c6cc73ed2f0dada6c30a993b39c2/content/renderer/navigation_state_impl.cc
[modify] https://crrev.com/15562b02f265c6cc73ed2f0dada6c30a993b39c2/content/renderer/navigation_state_impl.h
[modify] https://crrev.com/15562b02f265c6cc73ed2f0dada6c30a993b39c2/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/15562b02f265c6cc73ed2f0dada6c30a993b39c2/content/renderer/render_frame_impl.h
[modify] https://crrev.com/15562b02f265c6cc73ed2f0dada6c30a993b39c2/content/renderer/render_frame_impl_browsertest.cc
[modify] https://crrev.com/15562b02f265c6cc73ed2f0dada6c30a993b39c2/content/renderer/render_view_browsertest.cc
[modify] https://crrev.com/15562b02f265c6cc73ed2f0dada6c30a993b39c2/content/test/content_browser_test_test.cc
[modify] https://crrev.com/15562b02f265c6cc73ed2f0dada6c30a993b39c2/content/test/test_render_frame.cc
[modify] https://crrev.com/15562b02f265c6cc73ed2f0dada6c30a993b39c2/content/test/test_render_frame.h
[modify] https://crrev.com/15562b02f265c6cc73ed2f0dada6c30a993b39c2/tools/perf/core/stacktrace_unittest.py

Project Member

Comment 17 by bugdroid1@chromium.org, Jan 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/28a73925a888173243e775a0aebbd960b4d0d991

commit 28a73925a888173243e775a0aebbd960b4d0d991
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Wed Jan 03 19:11:11 2018

[DevTools] Remove old navigation path support

Bug: 789577
Change-Id: Idc8ac26283f863b280a50ec3036990630c6e81c3
Reviewed-on: https://chromium-review.googlesource.com/847853
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526758}
[modify] https://crrev.com/28a73925a888173243e775a0aebbd960b4d0d991/content/browser/devtools/devtools_agent_host_impl.cc
[modify] https://crrev.com/28a73925a888173243e775a0aebbd960b4d0d991/content/browser/devtools/devtools_manager_unittest.cc
[modify] https://crrev.com/28a73925a888173243e775a0aebbd960b4d0d991/content/browser/devtools/devtools_session.cc
[modify] https://crrev.com/28a73925a888173243e775a0aebbd960b4d0d991/content/browser/devtools/devtools_session.h
[modify] https://crrev.com/28a73925a888173243e775a0aebbd960b4d0d991/content/browser/devtools/forwarding_agent_host.cc
[modify] https://crrev.com/28a73925a888173243e775a0aebbd960b4d0d991/content/browser/devtools/protocol/page_handler.cc
[modify] https://crrev.com/28a73925a888173243e775a0aebbd960b4d0d991/content/browser/devtools/protocol/target_auto_attacher.cc
[modify] https://crrev.com/28a73925a888173243e775a0aebbd960b4d0d991/content/browser/devtools/render_frame_devtools_agent_host.cc
[modify] https://crrev.com/28a73925a888173243e775a0aebbd960b4d0d991/content/browser/devtools/render_frame_devtools_agent_host.h
[modify] https://crrev.com/28a73925a888173243e775a0aebbd960b4d0d991/content/browser/devtools/render_frame_devtools_agent_host_browsertest.cc
[modify] https://crrev.com/28a73925a888173243e775a0aebbd960b4d0d991/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp
[modify] https://crrev.com/28a73925a888173243e775a0aebbd960b4d0d991/third_party/WebKit/Source/core/inspector/InspectorPageAgent.h
[modify] https://crrev.com/28a73925a888173243e775a0aebbd960b4d0d991/third_party/WebKit/Source/core/inspector/inspector_protocol_config.json

Project Member

Comment 18 by bugdroid1@chromium.org, Jan 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0f0804c5f71bdeafdf9a86175e54291ffb6a172

commit f0f0804c5f71bdeafdf9a86175e54291ffb6a172
Author: Matt Falkenhagen <falken@chromium.org>
Date: Fri Jan 12 06:34:00 2018

service worker: Remove cross-site transfer code.

Cross-site transfer does not happen with PlzNavigate, and non-PlzNavigate
is no longer supported.

Also update ServiceWorkerProviderHost to take a "PlzNavigate always on" point
of view.

Bug: 789577
Change-Id: I43052ae84d5a6d48a24c6fa2b17514eb2b428f63
Reviewed-on: https://chromium-review.googlesource.com/863003
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528894}
[modify] https://crrev.com/f0f0804c5f71bdeafdf9a86175e54291ffb6a172/content/browser/service_worker/service_worker_context_core.cc
[modify] https://crrev.com/f0f0804c5f71bdeafdf9a86175e54291ffb6a172/content/browser/service_worker/service_worker_context_core.h
[modify] https://crrev.com/f0f0804c5f71bdeafdf9a86175e54291ffb6a172/content/browser/service_worker/service_worker_provider_host.cc
[modify] https://crrev.com/f0f0804c5f71bdeafdf9a86175e54291ffb6a172/content/browser/service_worker/service_worker_provider_host.h
[modify] https://crrev.com/f0f0804c5f71bdeafdf9a86175e54291ffb6a172/content/browser/service_worker/service_worker_provider_host_unittest.cc
[modify] https://crrev.com/f0f0804c5f71bdeafdf9a86175e54291ffb6a172/content/browser/service_worker/service_worker_request_handler.cc
[modify] https://crrev.com/f0f0804c5f71bdeafdf9a86175e54291ffb6a172/content/browser/service_worker/service_worker_request_handler.h

Project Member

Comment 19 by bugdroid1@chromium.org, Jan 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b0e4b4840bff841de8ae65d01e1b3b1482da8c77

commit b0e4b4840bff841de8ae65d01e1b3b1482da8c77
Author: Matt Falkenhagen <falken@chromium.org>
Date: Fri Jan 12 07:48:57 2018

service worker: Remove manual process management.

ServiceWorkerProcessManager had a code path that manually
tracked renderer processes that was only used in non-PlzNavigate.
The PlzNavigate code path uses SiteInstance for process reuse
for service workers implemented for  issue 705318 .

Since non-PlzNavigate is not supported, we can remove the
manual tracking.

Bug:  705318 , 789577
Change-Id: I66d51e4534e983cddf9f94bb0b9e688c0103ea95
Reviewed-on: https://chromium-review.googlesource.com/863005
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528905}
[modify] https://crrev.com/b0e4b4840bff841de8ae65d01e1b3b1482da8c77/content/browser/service_worker/embedded_worker_test_helper.cc
[modify] https://crrev.com/b0e4b4840bff841de8ae65d01e1b3b1482da8c77/content/browser/service_worker/embedded_worker_test_helper.h
[modify] https://crrev.com/b0e4b4840bff841de8ae65d01e1b3b1482da8c77/content/browser/service_worker/service_worker_browsertest.cc
[modify] https://crrev.com/b0e4b4840bff841de8ae65d01e1b3b1482da8c77/content/browser/service_worker/service_worker_process_manager.cc
[modify] https://crrev.com/b0e4b4840bff841de8ae65d01e1b3b1482da8c77/content/browser/service_worker/service_worker_process_manager.h
[modify] https://crrev.com/b0e4b4840bff841de8ae65d01e1b3b1482da8c77/content/browser/service_worker/service_worker_process_manager_unittest.cc
[modify] https://crrev.com/b0e4b4840bff841de8ae65d01e1b3b1482da8c77/content/browser/service_worker/service_worker_provider_host.cc
[modify] https://crrev.com/b0e4b4840bff841de8ae65d01e1b3b1482da8c77/content/browser/service_worker/service_worker_provider_host.h
[modify] https://crrev.com/b0e4b4840bff841de8ae65d01e1b3b1482da8c77/content/browser/service_worker/service_worker_provider_host_unittest.cc
[modify] https://crrev.com/b0e4b4840bff841de8ae65d01e1b3b1482da8c77/content/browser/service_worker/service_worker_version_unittest.cc

Project Member

Comment 20 by bugdroid1@chromium.org, Jan 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b93d16f6215f223d4482acfd6cf934eee8a7dc19

commit b93d16f6215f223d4482acfd6cf934eee8a7dc19
Author: Matt Falkenhagen <falken@chromium.org>
Date: Mon Jan 15 03:39:08 2018

service worker: Remove obsolete code needed for manual process management.

Follow-up to https://chromium-review.googlesource.com/863005.
This patch removes the now no-op functions from ServiceWorkerProviderHost
and the tree of callsites to them.

Bug:  705318 , 789577
Change-Id: I0618a106237bff0e33d1e8ed4c19d3d417b8a968
Reviewed-on: https://chromium-review.googlesource.com/863864
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529195}
[modify] https://crrev.com/b93d16f6215f223d4482acfd6cf934eee8a7dc19/content/browser/background_fetch/background_fetch_test_base.cc
[modify] https://crrev.com/b93d16f6215f223d4482acfd6cf934eee8a7dc19/content/browser/background_sync/background_sync_manager_unittest.cc
[modify] https://crrev.com/b93d16f6215f223d4482acfd6cf934eee8a7dc19/content/browser/background_sync/background_sync_service_impl_unittest.cc
[modify] https://crrev.com/b93d16f6215f223d4482acfd6cf934eee8a7dc19/content/browser/notifications/platform_notification_context_unittest.cc
[modify] https://crrev.com/b93d16f6215f223d4482acfd6cf934eee8a7dc19/content/browser/payments/payment_app_content_unittest_base.cc
[modify] https://crrev.com/b93d16f6215f223d4482acfd6cf934eee8a7dc19/content/browser/service_worker/service_worker_context_core.cc
[modify] https://crrev.com/b93d16f6215f223d4482acfd6cf934eee8a7dc19/content/browser/service_worker/service_worker_context_core.h
[modify] https://crrev.com/b93d16f6215f223d4482acfd6cf934eee8a7dc19/content/browser/service_worker/service_worker_context_unittest.cc
[modify] https://crrev.com/b93d16f6215f223d4482acfd6cf934eee8a7dc19/content/browser/service_worker/service_worker_context_watcher_unittest.cc
[modify] https://crrev.com/b93d16f6215f223d4482acfd6cf934eee8a7dc19/content/browser/service_worker/service_worker_context_wrapper.cc
[modify] https://crrev.com/b93d16f6215f223d4482acfd6cf934eee8a7dc19/content/browser/service_worker/service_worker_controllee_request_handler.cc
[modify] https://crrev.com/b93d16f6215f223d4482acfd6cf934eee8a7dc19/content/browser/service_worker/service_worker_job_coordinator.cc
[modify] https://crrev.com/b93d16f6215f223d4482acfd6cf934eee8a7dc19/content/browser/service_worker/service_worker_job_coordinator.h
[modify] https://crrev.com/b93d16f6215f223d4482acfd6cf934eee8a7dc19/content/browser/service_worker/service_worker_job_unittest.cc
[modify] https://crrev.com/b93d16f6215f223d4482acfd6cf934eee8a7dc19/content/browser/service_worker/service_worker_provider_host.cc
[modify] https://crrev.com/b93d16f6215f223d4482acfd6cf934eee8a7dc19/content/browser/service_worker/service_worker_provider_host.h
[modify] https://crrev.com/b93d16f6215f223d4482acfd6cf934eee8a7dc19/content/browser/service_worker/service_worker_register_job.cc
[modify] https://crrev.com/b93d16f6215f223d4482acfd6cf934eee8a7dc19/content/browser/service_worker/service_worker_register_job.h
[modify] https://crrev.com/b93d16f6215f223d4482acfd6cf934eee8a7dc19/content/browser/service_worker/service_worker_registration_object_host.cc

Project Member

Comment 21 by bugdroid1@chromium.org, Jan 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ce52ae6fecebeb9be485e8a4d81cbe03c6721c3c

commit ce52ae6fecebeb9be485e8a4d81cbe03c6721c3c
Author: Matt Falkenhagen <falken@chromium.org>
Date: Mon Jan 15 04:43:38 2018

service worker: Remove SimulateAddProcessToPattern

Follow-up to https://chromium-review.googlesource.com/863005

Bug:  705318 , 789577
Change-Id: Idd57bc8215c41880c5c33c06022d24a68b850e98
Reviewed-on: https://chromium-review.googlesource.com/864462
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529200}
[modify] https://crrev.com/ce52ae6fecebeb9be485e8a4d81cbe03c6721c3c/content/browser/service_worker/embedded_worker_instance_unittest.cc
[modify] https://crrev.com/ce52ae6fecebeb9be485e8a4d81cbe03c6721c3c/content/browser/service_worker/embedded_worker_test_helper.cc
[modify] https://crrev.com/ce52ae6fecebeb9be485e8a4d81cbe03c6721c3c/content/browser/service_worker/embedded_worker_test_helper.h
[modify] https://crrev.com/ce52ae6fecebeb9be485e8a4d81cbe03c6721c3c/content/browser/service_worker/service_worker_context_unittest.cc
[modify] https://crrev.com/ce52ae6fecebeb9be485e8a4d81cbe03c6721c3c/content/browser/service_worker/service_worker_dispatcher_host_unittest.cc
[modify] https://crrev.com/ce52ae6fecebeb9be485e8a4d81cbe03c6721c3c/content/browser/service_worker/service_worker_handle_unittest.cc
[modify] https://crrev.com/ce52ae6fecebeb9be485e8a4d81cbe03c6721c3c/content/browser/service_worker/service_worker_version_unittest.cc

Project Member

Comment 22 by bugdroid1@chromium.org, Jan 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8e779e6a5d827c7eb3deead6564f2eb39b7fc7c

commit c8e779e6a5d827c7eb3deead6564f2eb39b7fc7c
Author: Matt Falkenhagen <falken@chromium.org>
Date: Thu Jan 25 07:43:22 2018

service worker: Remove non-PlzNavigate code around SWProviderHost::web_contents_getter()

The non-PlzNavigate code path is no longer supported.

R=shimazu

Bug: 789577
Change-Id: Id0b61bd9042769d3afdcb78df6913632d833d831
Reviewed-on: https://chromium-review.googlesource.com/885687
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531843}
[modify] https://crrev.com/c8e779e6a5d827c7eb3deead6564f2eb39b7fc7c/content/browser/service_worker/service_worker_controllee_request_handler.cc
[modify] https://crrev.com/c8e779e6a5d827c7eb3deead6564f2eb39b7fc7c/content/browser/service_worker/service_worker_provider_host_unittest.cc

Project Member

Comment 23 by bugdroid1@chromium.org, Feb 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/63dda2955590d6388517bcfb2d18e2ad184af77e

commit 63dda2955590d6388517bcfb2d18e2ad184af77e
Author: Nasko Oskov <nasko@chromium.org>
Date: Fri Feb 09 19:35:42 2018

Remove IsBrowserSideNavigationEnabled from content/ browser tests.

Browser side navigation (aka PlzNavigate) is now the only navigation
code, so checking IsBrowserSideNavigationEnabled is no longer useful.

Bug: 789577
Change-Id: I3020c83a2dbc8d74906c5c11f1742817dabec849
Reviewed-on: https://chromium-review.googlesource.com/910394
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535785}
[modify] https://crrev.com/63dda2955590d6388517bcfb2d18e2ad184af77e/content/browser/frame_host/data_url_navigation_browsertest.cc
[modify] https://crrev.com/63dda2955590d6388517bcfb2d18e2ad184af77e/content/browser/frame_host/form_submission_throttle_browsertest.cc
[modify] https://crrev.com/63dda2955590d6388517bcfb2d18e2ad184af77e/content/browser/frame_host/navigation_controller_impl_browsertest.cc
[modify] https://crrev.com/63dda2955590d6388517bcfb2d18e2ad184af77e/content/browser/frame_host/navigation_handle_impl_browsertest.cc
[modify] https://crrev.com/63dda2955590d6388517bcfb2d18e2ad184af77e/content/browser/frame_host/render_frame_host_impl_browsertest.cc
[modify] https://crrev.com/63dda2955590d6388517bcfb2d18e2ad184af77e/content/browser/frame_host/render_frame_host_manager_browsertest.cc
[modify] https://crrev.com/63dda2955590d6388517bcfb2d18e2ad184af77e/content/browser/isolated_origin_browsertest.cc
[modify] https://crrev.com/63dda2955590d6388517bcfb2d18e2ad184af77e/content/browser/site_per_process_browsertest.cc
[modify] https://crrev.com/63dda2955590d6388517bcfb2d18e2ad184af77e/content/renderer/render_view_browsertest.cc

Project Member

Comment 25 by bugdroid1@chromium.org, Feb 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e31f22e7f13b1219bf86582460b9667c8e50dceb

commit e31f22e7f13b1219bf86582460b9667c8e50dceb
Author: John Abd-El-Malek <jam@chromium.org>
Date: Tue Feb 13 22:25:36 2018

Remove IsBrowserSideNavigationEnabled from components/.

Browser side navigation (aka PlzNavigate) is now the only navigation code.

Bug: 789577
Change-Id: I9ac8275e19846de64a9cc832943e679eddb9836a
Reviewed-on: https://chromium-review.googlesource.com/916622
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536513}
[modify] https://crrev.com/e31f22e7f13b1219bf86582460b9667c8e50dceb/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager_unittest.cc
[modify] https://crrev.com/e31f22e7f13b1219bf86582460b9667c8e50dceb/components/subresource_filter/content/browser/subframe_navigation_filtering_throttle.cc
[modify] https://crrev.com/e31f22e7f13b1219bf86582460b9667c8e50dceb/components/subresource_filter/content/browser/subframe_navigation_filtering_throttle_unittest.cc

Project Member

Comment 26 by bugdroid1@chromium.org, Feb 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc53168e9847a06f0f5769770b135a5279b3fc1b

commit fc53168e9847a06f0f5769770b135a5279b3fc1b
Author: Nasko Oskov <nasko@chromium.org>
Date: Tue Feb 13 23:14:57 2018

Remove IsBrowserSideNavigationEnabled from content/ unit tests.

Browser side navigation (aka PlzNavigate) is now the only navigation
code, so checking IsBrowserSideNavigationEnabled is no longer useful.

Bug: 789577
Change-Id: Iead65af2d1f1e2f1df24023a2d943de34f32d040
Reviewed-on: https://chromium-review.googlesource.com/910689
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536538}
[modify] https://crrev.com/fc53168e9847a06f0f5769770b135a5279b3fc1b/content/browser/frame_host/navigation_controller_impl_unittest.cc
[modify] https://crrev.com/fc53168e9847a06f0f5769770b135a5279b3fc1b/content/browser/frame_host/navigation_handle_impl_unittest.cc
[modify] https://crrev.com/fc53168e9847a06f0f5769770b135a5279b3fc1b/content/browser/frame_host/render_frame_host_manager_unittest.cc
[modify] https://crrev.com/fc53168e9847a06f0f5769770b135a5279b3fc1b/content/browser/loader/resource_dispatcher_host_unittest.cc
[modify] https://crrev.com/fc53168e9847a06f0f5769770b135a5279b3fc1b/content/browser/renderer_host/render_process_host_unittest.cc
[modify] https://crrev.com/fc53168e9847a06f0f5769770b135a5279b3fc1b/content/browser/web_contents/aura/overscroll_navigation_overlay_unittest.cc
[modify] https://crrev.com/fc53168e9847a06f0f5769770b135a5279b3fc1b/content/browser/web_contents/web_contents_impl_unittest.cc
[modify] https://crrev.com/fc53168e9847a06f0f5769770b135a5279b3fc1b/content/common/throttling_url_loader_unittest.cc
[modify] https://crrev.com/fc53168e9847a06f0f5769770b135a5279b3fc1b/content/public/common/url_utils_unittest.cc
[modify] https://crrev.com/fc53168e9847a06f0f5769770b135a5279b3fc1b/content/test/navigation_simulator_unittest.cc

Project Member

Comment 27 by bugdroid1@chromium.org, Feb 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2305cdc1d9309edaabf1b73ae3faf26577f96d65

commit 2305cdc1d9309edaabf1b73ae3faf26577f96d65
Author: John Abd-El-Malek <jam@chromium.org>
Date: Wed Feb 14 20:26:28 2018

Remove IsBrowserSideNavigationEnabled from chrome/.

Browser side navigation (aka PlzNavigate) is now the only navigation code.

Bug: 789577
Change-Id: Ifc5140816d5956bdff7d7f9b56ca0d48e67d2e44
Reviewed-on: https://chromium-review.googlesource.com/916726
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536799}
[modify] https://crrev.com/2305cdc1d9309edaabf1b73ae3faf26577f96d65/chrome/browser/captive_portal/captive_portal_browsertest.cc
[modify] https://crrev.com/2305cdc1d9309edaabf1b73ae3faf26577f96d65/chrome/browser/captive_portal/captive_portal_tab_helper_unittest.cc
[modify] https://crrev.com/2305cdc1d9309edaabf1b73ae3faf26577f96d65/chrome/browser/client_hints/client_hints_browsertest.cc
[modify] https://crrev.com/2305cdc1d9309edaabf1b73ae3faf26577f96d65/chrome/browser/data_use_measurement/chrome_data_use_ascriber.cc
[modify] https://crrev.com/2305cdc1d9309edaabf1b73ae3faf26577f96d65/chrome/browser/extensions/api/tabs/tabs_api_unittest.cc
[modify] https://crrev.com/2305cdc1d9309edaabf1b73ae3faf26577f96d65/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc
[modify] https://crrev.com/2305cdc1d9309edaabf1b73ae3faf26577f96d65/chrome/browser/extensions/extension_apitest.cc
[modify] https://crrev.com/2305cdc1d9309edaabf1b73ae3faf26577f96d65/chrome/browser/extensions/extension_context_menu_model_unittest.cc
[modify] https://crrev.com/2305cdc1d9309edaabf1b73ae3faf26577f96d65/chrome/browser/extensions/extension_protocols_unittest.cc
[modify] https://crrev.com/2305cdc1d9309edaabf1b73ae3faf26577f96d65/chrome/browser/extensions/extension_resource_request_policy_apitest.cc
[modify] https://crrev.com/2305cdc1d9309edaabf1b73ae3faf26577f96d65/chrome/browser/metrics/first_web_contents_profiler.cc
[modify] https://crrev.com/2305cdc1d9309edaabf1b73ae3faf26577f96d65/chrome/browser/net/chrome_extensions_network_delegate.cc
[modify] https://crrev.com/2305cdc1d9309edaabf1b73ae3faf26577f96d65/chrome/browser/safe_browsing/client_side_detection_host_unittest.cc
[modify] https://crrev.com/2305cdc1d9309edaabf1b73ae3faf26577f96d65/chrome/browser/ssl/ssl_browsertest.cc
[modify] https://crrev.com/2305cdc1d9309edaabf1b73ae3faf26577f96d65/chrome/browser/ssl/ssl_error_navigation_throttle_unittest.cc
[modify] https://crrev.com/2305cdc1d9309edaabf1b73ae3faf26577f96d65/chrome/browser/subresource_filter/subresource_filter_browsertest.cc
[modify] https://crrev.com/2305cdc1d9309edaabf1b73ae3faf26577f96d65/chrome/browser/subresource_filter/subresource_filter_special_subframe_navigations_browsertest.cc
[modify] https://crrev.com/2305cdc1d9309edaabf1b73ae3faf26577f96d65/chrome/browser/translate/translate_manager_render_view_host_unittest.cc
[modify] https://crrev.com/2305cdc1d9309edaabf1b73ae3faf26577f96d65/chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc
[modify] https://crrev.com/2305cdc1d9309edaabf1b73ae3faf26577f96d65/chrome/browser/ui/browser_browsertest.cc
[modify] https://crrev.com/2305cdc1d9309edaabf1b73ae3faf26577f96d65/chrome/browser/ui/browser_command_controller_interactive_browsertest.cc
[modify] https://crrev.com/2305cdc1d9309edaabf1b73ae3faf26577f96d65/chrome/browser/ui/login/login_handler_browsertest.cc
[modify] https://crrev.com/2305cdc1d9309edaabf1b73ae3faf26577f96d65/chrome/browser/ui/search/search_tab_helper.cc
[modify] https://crrev.com/2305cdc1d9309edaabf1b73ae3faf26577f96d65/chrome/browser/ui/search/search_tab_helper.h
[modify] https://crrev.com/2305cdc1d9309edaabf1b73ae3faf26577f96d65/chrome/browser/ui/sync/one_click_signin_sync_observer_unittest.cc
[modify] https://crrev.com/2305cdc1d9309edaabf1b73ae3faf26577f96d65/chrome/browser/ui/tab_helpers.cc
[modify] https://crrev.com/2305cdc1d9309edaabf1b73ae3faf26577f96d65/chrome/test/base/browser_with_test_window_test.cc
[modify] https://crrev.com/2305cdc1d9309edaabf1b73ae3faf26577f96d65/extensions/common/api/test.json

Project Member

Comment 28 by bugdroid1@chromium.org, Mar 16 2018

Project Member

Comment 29 by bugdroid1@chromium.org, Mar 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/390201aa5adcb551a06cd3f119625a7cbd7b677b

commit 390201aa5adcb551a06cd3f119625a7cbd7b677b
Author: Matt Falkenhagen <falken@chromium.org>
Date: Tue Mar 27 22:57:05 2018

service worker: Simplify OnProviderCreated since PlzNavigate is always on.

Bug: 789577
Change-Id: Id624ba43bcdcb6fdfc75341c02880bf4e4fff0ea
Reviewed-on: https://chromium-review.googlesource.com/981955
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546306}
[modify] https://crrev.com/390201aa5adcb551a06cd3f119625a7cbd7b677b/content/browser/bad_message.h
[modify] https://crrev.com/390201aa5adcb551a06cd3f119625a7cbd7b677b/content/browser/service_worker/service_worker_dispatcher_host.cc
[modify] https://crrev.com/390201aa5adcb551a06cd3f119625a7cbd7b677b/tools/metrics/histograms/enums.xml

Project Member

Comment 30 by bugdroid1@chromium.org, Apr 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02ba63f1c77e78d24afae7e6f0e9675b15d72621

commit 02ba63f1c77e78d24afae7e6f0e9675b15d72621
Author: csharrison <csharrison@chromium.org>
Date: Mon Apr 30 14:40:25 2018

Remove some transfer navigation logic

This is all dead code now that PlzNavigate has shipped.

This CL should have no intended behavior changes.

Bug: 789577
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ifcf05eee1a4486cdf89b8f658bbd2212f0b74bc5
Reviewed-on: https://chromium-review.googlesource.com/1022631
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554747}
[modify] https://crrev.com/02ba63f1c77e78d24afae7e6f0e9675b15d72621/content/browser/appcache/appcache_interceptor.cc
[modify] https://crrev.com/02ba63f1c77e78d24afae7e6f0e9675b15d72621/content/browser/appcache/appcache_interceptor.h
[modify] https://crrev.com/02ba63f1c77e78d24afae7e6f0e9675b15d72621/content/browser/appcache/appcache_request_handler.cc
[modify] https://crrev.com/02ba63f1c77e78d24afae7e6f0e9675b15d72621/content/browser/appcache/appcache_request_handler.h
[modify] https://crrev.com/02ba63f1c77e78d24afae7e6f0e9675b15d72621/content/browser/appcache/appcache_request_handler_unittest.cc
[modify] https://crrev.com/02ba63f1c77e78d24afae7e6f0e9675b15d72621/content/browser/bad_message.h
[modify] https://crrev.com/02ba63f1c77e78d24afae7e6f0e9675b15d72621/content/browser/loader/mojo_async_resource_handler.cc
[modify] https://crrev.com/02ba63f1c77e78d24afae7e6f0e9675b15d72621/content/browser/loader/mojo_async_resource_handler.h
[modify] https://crrev.com/02ba63f1c77e78d24afae7e6f0e9675b15d72621/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/02ba63f1c77e78d24afae7e6f0e9675b15d72621/content/browser/loader/resource_dispatcher_host_impl.h
[modify] https://crrev.com/02ba63f1c77e78d24afae7e6f0e9675b15d72621/content/browser/loader/resource_loader.cc
[modify] https://crrev.com/02ba63f1c77e78d24afae7e6f0e9675b15d72621/content/browser/loader/resource_loader.h
[modify] https://crrev.com/02ba63f1c77e78d24afae7e6f0e9675b15d72621/content/browser/loader/resource_request_info_impl.cc
[modify] https://crrev.com/02ba63f1c77e78d24afae7e6f0e9675b15d72621/content/browser/loader/resource_request_info_impl.h
[modify] https://crrev.com/02ba63f1c77e78d24afae7e6f0e9675b15d72621/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/02ba63f1c77e78d24afae7e6f0e9675b15d72621/content/browser/renderer_host/render_process_host_impl.h
[modify] https://crrev.com/02ba63f1c77e78d24afae7e6f0e9675b15d72621/content/browser/renderer_host/render_widget_helper.cc
[modify] https://crrev.com/02ba63f1c77e78d24afae7e6f0e9675b15d72621/content/browser/renderer_host/render_widget_helper.h
[modify] https://crrev.com/02ba63f1c77e78d24afae7e6f0e9675b15d72621/content/browser/service_worker/service_worker_request_handler.cc
[modify] https://crrev.com/02ba63f1c77e78d24afae7e6f0e9675b15d72621/content/browser/service_worker/service_worker_request_handler.h
[modify] https://crrev.com/02ba63f1c77e78d24afae7e6f0e9675b15d72621/content/public/browser/render_process_host.h
[modify] https://crrev.com/02ba63f1c77e78d24afae7e6f0e9675b15d72621/content/public/test/mock_render_process_host.cc
[modify] https://crrev.com/02ba63f1c77e78d24afae7e6f0e9675b15d72621/content/public/test/mock_render_process_host.h
[modify] https://crrev.com/02ba63f1c77e78d24afae7e6f0e9675b15d72621/services/network/public/cpp/network_param_ipc_traits.h
[modify] https://crrev.com/02ba63f1c77e78d24afae7e6f0e9675b15d72621/services/network/public/cpp/resource_request.h
[modify] https://crrev.com/02ba63f1c77e78d24afae7e6f0e9675b15d72621/tools/metrics/histograms/enums.xml

Project Member

Comment 31 by bugdroid1@chromium.org, Apr 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa4e51736beddb9e6a2dd0e3c7b21c865652d417

commit fa4e51736beddb9e6a2dd0e3c7b21c865652d417
Author: Charlie Harrison <csharrison@chromium.org>
Date: Mon Apr 30 16:38:58 2018

Remove should_replace_current_entry from network stack

This is obsolete with PlzNavigate.

Bug: 789577
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I29cb9c7fa986cf6c564d9dad29c46b10df301be5
Reviewed-on: https://chromium-review.googlesource.com/1031392
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554787}
[modify] https://crrev.com/fa4e51736beddb9e6a2dd0e3c7b21c865652d417/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/fa4e51736beddb9e6a2dd0e3c7b21c865652d417/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/fa4e51736beddb9e6a2dd0e3c7b21c865652d417/content/browser/loader/resource_request_info_impl.cc
[modify] https://crrev.com/fa4e51736beddb9e6a2dd0e3c7b21c865652d417/content/browser/loader/resource_request_info_impl.h
[modify] https://crrev.com/fa4e51736beddb9e6a2dd0e3c7b21c865652d417/content/renderer/loader/request_extra_data.cc
[modify] https://crrev.com/fa4e51736beddb9e6a2dd0e3c7b21c865652d417/content/renderer/loader/request_extra_data.h
[modify] https://crrev.com/fa4e51736beddb9e6a2dd0e3c7b21c865652d417/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/fa4e51736beddb9e6a2dd0e3c7b21c865652d417/services/network/public/cpp/network_param_ipc_traits.h
[modify] https://crrev.com/fa4e51736beddb9e6a2dd0e3c7b21c865652d417/services/network/public/cpp/resource_request.h

Project Member

Comment 32 by bugdroid1@chromium.org, May 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/84e9f591b32880610404cec6c930fe1a4a19bcfe

commit 84e9f591b32880610404cec6c930fe1a4a19bcfe
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Wed May 02 14:46:11 2018

Remove browserSideNavigationEnabled setting from blink

It's always true, so we can remove some checks and unused code.

We can actually remove MaybeCheckCSP method, but it has some
valuable comments. We'll remove it either by removing the comments
or finding a better place for them.

Bug: 789577
Change-Id: I891407ad35230be936164acdfbe26f6123c3a0a9
Reviewed-on: https://chromium-review.googlesource.com/1037804
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555384}
[modify] https://crrev.com/84e9f591b32880610404cec6c930fe1a4a19bcfe/content/renderer/render_view_impl.cc
[modify] https://crrev.com/84e9f591b32880610404cec6c930fe1a4a19bcfe/third_party/blink/public/web/web_settings.h
[modify] https://crrev.com/84e9f591b32880610404cec6c930fe1a4a19bcfe/third_party/blink/renderer/core/dom/document.cc
[modify] https://crrev.com/84e9f591b32880610404cec6c930fe1a4a19bcfe/third_party/blink/renderer/core/exported/web_settings_impl.cc
[modify] https://crrev.com/84e9f591b32880610404cec6c930fe1a4a19bcfe/third_party/blink/renderer/core/exported/web_settings_impl.h
[modify] https://crrev.com/84e9f591b32880610404cec6c930fe1a4a19bcfe/third_party/blink/renderer/core/frame/frame_test_helpers.cc
[modify] https://crrev.com/84e9f591b32880610404cec6c930fe1a4a19bcfe/third_party/blink/renderer/core/frame/frame_test_helpers.h
[modify] https://crrev.com/84e9f591b32880610404cec6c930fe1a4a19bcfe/third_party/blink/renderer/core/frame/settings.json5
[modify] https://crrev.com/84e9f591b32880610404cec6c930fe1a4a19bcfe/third_party/blink/renderer/core/loader/document_loader.cc
[modify] https://crrev.com/84e9f591b32880610404cec6c930fe1a4a19bcfe/third_party/blink/renderer/core/loader/frame_loader.cc
[modify] https://crrev.com/84e9f591b32880610404cec6c930fe1a4a19bcfe/third_party/blink/renderer/core/loader/mixed_content_checker.cc

Project Member

Comment 33 by bugdroid1@chromium.org, May 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df3ea35f363255ed60698f5e951522beac51c7c0

commit df3ea35f363255ed60698f5e951522beac51c7c0
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Mon May 21 23:03:46 2018

Split StartNavigation and CommitNavigation APIs

The clients of FrameLoader and WebLocalFrame will have to
choose whether they are starting or committing a navigation.

The implementation is still the same, but we can assert some
preconditions, e.g. history navigation is always a commit.

This patch only replaces WebLocalFrame::Load method with
CommitNavigation, but more methods will be replaced in following
patches. After all usages will be migrated, we can start
separating the implementation of Start vs Commit in FrameLoader.

Bug: 789577
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I10d59bd5b523eba403265820d0b1df90e3d89f7b
Reviewed-on: https://chromium-review.googlesource.com/1042856
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560392}
[modify] https://crrev.com/df3ea35f363255ed60698f5e951522beac51c7c0/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/df3ea35f363255ed60698f5e951522beac51c7c0/third_party/blink/public/web/web_local_frame.h
[modify] https://crrev.com/df3ea35f363255ed60698f5e951522beac51c7c0/third_party/blink/renderer/core/exported/web_frame_test.cc
[modify] https://crrev.com/df3ea35f363255ed60698f5e951522beac51c7c0/third_party/blink/renderer/core/exported/web_plugin_container_impl.cc
[modify] https://crrev.com/df3ea35f363255ed60698f5e951522beac51c7c0/third_party/blink/renderer/core/exported/web_view_test.cc
[modify] https://crrev.com/df3ea35f363255ed60698f5e951522beac51c7c0/third_party/blink/renderer/core/exported/worker_shadow_page.cc
[modify] https://crrev.com/df3ea35f363255ed60698f5e951522beac51c7c0/third_party/blink/renderer/core/frame/frame_test.cc
[modify] https://crrev.com/df3ea35f363255ed60698f5e951522beac51c7c0/third_party/blink/renderer/core/frame/frame_test_helpers.cc
[modify] https://crrev.com/df3ea35f363255ed60698f5e951522beac51c7c0/third_party/blink/renderer/core/frame/local_frame.cc
[modify] https://crrev.com/df3ea35f363255ed60698f5e951522beac51c7c0/third_party/blink/renderer/core/frame/web_local_frame_impl.cc
[modify] https://crrev.com/df3ea35f363255ed60698f5e951522beac51c7c0/third_party/blink/renderer/core/frame/web_local_frame_impl.h
[modify] https://crrev.com/df3ea35f363255ed60698f5e951522beac51c7c0/third_party/blink/renderer/core/html/html_anchor_element.cc
[modify] https://crrev.com/df3ea35f363255ed60698f5e951522beac51c7c0/third_party/blink/renderer/core/html/html_frame_owner_element.cc
[modify] https://crrev.com/df3ea35f363255ed60698f5e951522beac51c7c0/third_party/blink/renderer/core/loader/frame_loader.cc
[modify] https://crrev.com/df3ea35f363255ed60698f5e951522beac51c7c0/third_party/blink/renderer/core/loader/frame_loader.h
[modify] https://crrev.com/df3ea35f363255ed60698f5e951522beac51c7c0/third_party/blink/renderer/core/loader/navigation_scheduler.cc
[modify] https://crrev.com/df3ea35f363255ed60698f5e951522beac51c7c0/third_party/blink/renderer/core/loader/ping_loader_test.cc
[modify] https://crrev.com/df3ea35f363255ed60698f5e951522beac51c7c0/third_party/blink/renderer/core/page/create_window.cc
[modify] https://crrev.com/df3ea35f363255ed60698f5e951522beac51c7c0/third_party/blink/renderer/core/svg/svg_a_element.cc

Project Member

Comment 34 by bugdroid1@chromium.org, May 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c24ad0015be90c0103ab618551ee5621ddef4def

commit c24ad0015be90c0103ab618551ee5621ddef4def
Author: Hans Wennborg <hans@chromium.org>
Date: Tue May 22 15:09:18 2018

Remove test exceptions for renderer-side navigation

These tests don't actually exist anymore; only the exceptions were left.

R=thakis@chromium.org

Bug: 789577,  842698 
Change-Id: I649f4ce44129e4b659e3801aad2f9ee296378dd3
Reviewed-on: https://chromium-review.googlesource.com/1068910
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560590}
[modify] https://crrev.com/c24ad0015be90c0103ab618551ee5621ddef4def/testing/buildbot/test_suite_exceptions.pyl

Project Member

Comment 35 by bugdroid1@chromium.org, May 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6cbfa371b381bc82a14262d52f761f071905d4bb

commit 6cbfa371b381bc82a14262d52f761f071905d4bb
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Sat May 26 02:42:05 2018

Replace more loading methods in WebLocalFrame

This patch renames Reload to StartReload (as opposite to Commit),
and LoadRequest to StartNavigation.

Multiple LoadRequest usages are migrated to either
CommitNavigation (if they mean it) or LoadHTMLString.

Bug: 789577
Change-Id: Ia58b00e08a6f31f3aa8e6e8f4357f4ad32271c1b
Reviewed-on: https://chromium-review.googlesource.com/1043093
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562099}
[modify] https://crrev.com/6cbfa371b381bc82a14262d52f761f071905d4bb/chrome/renderer/content_settings_observer.cc
[modify] https://crrev.com/6cbfa371b381bc82a14262d52f761f071905d4bb/chrome/renderer/net/net_error_helper.cc
[modify] https://crrev.com/6cbfa371b381bc82a14262d52f761f071905d4bb/components/printing/renderer/print_render_frame_helper.cc
[modify] https://crrev.com/6cbfa371b381bc82a14262d52f761f071905d4bb/content/public/test/render_view_test.cc
[modify] https://crrev.com/6cbfa371b381bc82a14262d52f761f071905d4bb/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/6cbfa371b381bc82a14262d52f761f071905d4bb/content/shell/renderer/layout_test/blink_test_runner.cc
[modify] https://crrev.com/6cbfa371b381bc82a14262d52f761f071905d4bb/third_party/blink/public/web/web_local_frame.h
[modify] https://crrev.com/6cbfa371b381bc82a14262d52f761f071905d4bb/third_party/blink/renderer/core/exported/web_frame_test.cc
[modify] https://crrev.com/6cbfa371b381bc82a14262d52f761f071905d4bb/third_party/blink/renderer/core/frame/frame_test_helpers.cc
[modify] https://crrev.com/6cbfa371b381bc82a14262d52f761f071905d4bb/third_party/blink/renderer/core/frame/web_local_frame_impl.cc
[modify] https://crrev.com/6cbfa371b381bc82a14262d52f761f071905d4bb/third_party/blink/renderer/core/frame/web_local_frame_impl.h
[modify] https://crrev.com/6cbfa371b381bc82a14262d52f761f071905d4bb/third_party/blink/renderer/core/page/scrolling/root_scroller_test.cc
[modify] https://crrev.com/6cbfa371b381bc82a14262d52f761f071905d4bb/third_party/blink/renderer/core/testing/sim/sim_test.cc

Project Member

Comment 36 by bugdroid1@chromium.org, May 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb76d6661f570672a37d6df4d937f9b4be71afdb

commit bb76d6661f570672a37d6df4d937f9b4be71afdb
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Wed May 30 02:22:14 2018

Remove HistoryLoadType

We always pass k{Web,}HistoryDifferentDocumentLoad except for
one test which migrated to CommitSameDocumentNavigation instead.

There is also no way to reach same_document_history_navigation
through CommitNavigation path anymore, since that goes through
CommitSameDocumentNavigation instead.

Bug: 789577
Change-Id: I0dc4514abd1a40fee05c29f9a55f85b57647f430
Reviewed-on: https://chromium-review.googlesource.com/1069778
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562698}
[modify] https://crrev.com/bb76d6661f570672a37d6df4d937f9b4be71afdb/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/bb76d6661f570672a37d6df4d937f9b4be71afdb/content/renderer/render_frame_impl.h
[modify] https://crrev.com/bb76d6661f570672a37d6df4d937f9b4be71afdb/content/shell/renderer/layout_test/blink_test_runner.cc
[modify] https://crrev.com/bb76d6661f570672a37d6df4d937f9b4be71afdb/third_party/blink/public/web/web_history_item.h
[modify] https://crrev.com/bb76d6661f570672a37d6df4d937f9b4be71afdb/third_party/blink/public/web/web_local_frame.h
[modify] https://crrev.com/bb76d6661f570672a37d6df4d937f9b4be71afdb/third_party/blink/renderer/core/exported/web_frame_test.cc
[modify] https://crrev.com/bb76d6661f570672a37d6df4d937f9b4be71afdb/third_party/blink/renderer/core/exported/web_view_test.cc
[modify] https://crrev.com/bb76d6661f570672a37d6df4d937f9b4be71afdb/third_party/blink/renderer/core/frame/frame_test_helpers.cc
[modify] https://crrev.com/bb76d6661f570672a37d6df4d937f9b4be71afdb/third_party/blink/renderer/core/frame/frame_test_helpers.h
[modify] https://crrev.com/bb76d6661f570672a37d6df4d937f9b4be71afdb/third_party/blink/renderer/core/frame/visual_viewport_test.cc
[modify] https://crrev.com/bb76d6661f570672a37d6df4d937f9b4be71afdb/third_party/blink/renderer/core/frame/web_local_frame_impl.cc
[modify] https://crrev.com/bb76d6661f570672a37d6df4d937f9b4be71afdb/third_party/blink/renderer/core/frame/web_local_frame_impl.h
[modify] https://crrev.com/bb76d6661f570672a37d6df4d937f9b4be71afdb/third_party/blink/renderer/core/loader/frame_loader.cc
[modify] https://crrev.com/bb76d6661f570672a37d6df4d937f9b4be71afdb/third_party/blink/renderer/core/loader/frame_loader.h
[modify] https://crrev.com/bb76d6661f570672a37d6df4d937f9b4be71afdb/third_party/blink/renderer/core/loader/frame_loader_types.h
[modify] https://crrev.com/bb76d6661f570672a37d6df4d937f9b4be71afdb/third_party/blink/renderer/core/testing/sim/sim_test.cc

Project Member

Comment 38 by bugdroid1@chromium.org, Jun 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/00152a250f55c4fa37bb9ee3fe2ed7344f9648d8

commit 00152a250f55c4fa37bb9ee3fe2ed7344f9648d8
Author: Charlie Reis <creis@chromium.org>
Date: Mon Jun 04 23:23:55 2018

Remove transferred_global_request_id.

This was used in the old cross-process transfer navigation logic,
which is no longer used with PlzNavigate.  This CL just cleans up
some dead code.

BUG=789577
TEST=No behavior change.

Change-Id: I287ba0fa2d540e52767134781bc6563bd3bf7132
Reviewed-on: https://chromium-review.googlesource.com/1082115
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Lucas Gadani <lfg@chromium.org>
Commit-Queue: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564287}
[modify] https://crrev.com/00152a250f55c4fa37bb9ee3fe2ed7344f9648d8/content/browser/frame_host/navigation_controller_impl.cc
[modify] https://crrev.com/00152a250f55c4fa37bb9ee3fe2ed7344f9648d8/content/browser/frame_host/navigation_controller_impl_unittest.cc
[modify] https://crrev.com/00152a250f55c4fa37bb9ee3fe2ed7344f9648d8/content/browser/frame_host/navigation_entry_impl.cc
[modify] https://crrev.com/00152a250f55c4fa37bb9ee3fe2ed7344f9648d8/content/browser/frame_host/navigation_entry_impl.h
[modify] https://crrev.com/00152a250f55c4fa37bb9ee3fe2ed7344f9648d8/content/browser/frame_host/navigator_impl.cc
[modify] https://crrev.com/00152a250f55c4fa37bb9ee3fe2ed7344f9648d8/content/public/browser/navigation_controller.h
[modify] https://crrev.com/00152a250f55c4fa37bb9ee3fe2ed7344f9648d8/extensions/browser/guest_view/web_view/web_view_guest.cc

Project Member

Comment 39 by bugdroid1@chromium.org, Jun 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/04bf4e5278a018769dbe776cbe722d6b5d102891

commit 04bf4e5278a018769dbe776cbe722d6b5d102891
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Fri Jun 08 18:28:23 2018

FrameLoader: split start and commit code paths pt1

This splits LoadInternal and removes it.

Bug: 789577
Change-Id: I4931659a1f50890fcda489e74591d12a2d2c4419
Reviewed-on: https://chromium-review.googlesource.com/1083823
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565696}
[modify] https://crrev.com/04bf4e5278a018769dbe776cbe722d6b5d102891/third_party/blink/renderer/core/loader/frame_loader.cc
[modify] https://crrev.com/04bf4e5278a018769dbe776cbe722d6b5d102891/third_party/blink/renderer/core/loader/frame_loader.h

Project Member

Comment 40 by bugdroid1@chromium.org, Jun 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bda8519bca969dc7a6c4d4c5313c59adabeda47f

commit bda8519bca969dc7a6c4d4c5313c59adabeda47f
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Sat Jun 09 05:44:31 2018

FrameLoader: remove MaybeCheckCSP and inline CheckLoadCanStart

This is a small refactor to further split start and commit code paths.

Bug: 789577
Change-Id: I4776467982cc1c1cb14a72693a0791965169bf9e
Reviewed-on: https://chromium-review.googlesource.com/1083825
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565866}
[modify] https://crrev.com/bda8519bca969dc7a6c4d4c5313c59adabeda47f/third_party/blink/renderer/core/loader/frame_loader.cc
[modify] https://crrev.com/bda8519bca969dc7a6c4d4c5313c59adabeda47f/third_party/blink/renderer/core/loader/frame_loader.h

Project Member

Comment 41 by bugdroid1@chromium.org, Jun 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f541bc35b24966de6982c2239b9cada4037f9403

commit f541bc35b24966de6982c2239b9cada4037f9403
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Tue Jun 19 04:49:34 2018

Remove ShouldContinueForRedirectNavigationPolicy

Redirects should have been already checked in the browser
beforehand and the right NavigationPolicy already determined.

Also cleanup unused DidReceiveServerRedirectForProvisionalLoad
callback.

Bug: 789577, 671276
Change-Id: I40421f36b57e85d731dc44914d8efe48e017fa91
Reviewed-on: https://chromium-review.googlesource.com/1103657
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568344}
[modify] https://crrev.com/f541bc35b24966de6982c2239b9cada4037f9403/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/f541bc35b24966de6982c2239b9cada4037f9403/content/renderer/render_frame_impl.h
[modify] https://crrev.com/f541bc35b24966de6982c2239b9cada4037f9403/content/shell/test_runner/web_frame_test_client.cc
[modify] https://crrev.com/f541bc35b24966de6982c2239b9cada4037f9403/content/shell/test_runner/web_frame_test_client.h
[modify] https://crrev.com/f541bc35b24966de6982c2239b9cada4037f9403/content/shell/test_runner/web_frame_test_proxy.h
[modify] https://crrev.com/f541bc35b24966de6982c2239b9cada4037f9403/third_party/WebKit/LayoutTests/http/tests/loading/307-after-303-after-post-expected.txt
[modify] https://crrev.com/f541bc35b24966de6982c2239b9cada4037f9403/third_party/WebKit/LayoutTests/http/tests/loading/redirect-methods-expected.txt
[modify] https://crrev.com/f541bc35b24966de6982c2239b9cada4037f9403/third_party/blink/public/web/web_local_frame_client.h
[modify] https://crrev.com/f541bc35b24966de6982c2239b9cada4037f9403/third_party/blink/renderer/core/exported/local_frame_client_impl.cc
[modify] https://crrev.com/f541bc35b24966de6982c2239b9cada4037f9403/third_party/blink/renderer/core/exported/local_frame_client_impl.h
[modify] https://crrev.com/f541bc35b24966de6982c2239b9cada4037f9403/third_party/blink/renderer/core/frame/local_frame_client.h
[modify] https://crrev.com/f541bc35b24966de6982c2239b9cada4037f9403/third_party/blink/renderer/core/loader/document_loader.cc
[modify] https://crrev.com/f541bc35b24966de6982c2239b9cada4037f9403/third_party/blink/renderer/core/loader/empty_clients.h
[modify] https://crrev.com/f541bc35b24966de6982c2239b9cada4037f9403/third_party/blink/renderer/core/loader/frame_loader.cc
[modify] https://crrev.com/f541bc35b24966de6982c2239b9cada4037f9403/third_party/blink/renderer/core/loader/frame_loader.h

Project Member

Comment 42 by bugdroid1@chromium.org, Jun 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b09ef22f0fcaec3e92f63147f0b08a0e44a5f7ae

commit b09ef22f0fcaec3e92f63147f0b08a0e44a5f7ae
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Wed Jun 27 19:01:02 2018

Ask client for navigation policy for empty url

This is the only case when we don't even ask the client to decide the
navigation policy, and it breaks a very nice assumption that
DecidePolicyForNavigation is always called for renderer-initiated
navigations.

For reference: this was introduced [1] in 2002 (sic!) and being
copied around since then.

[1] https://chromium.googlesource.com/chromium/src/+/80834d145816195289a30e4168a0659380a00d75%5E%21/

Bug: 789577
Change-Id: Ic4a4671bcc34db46f70d53d4281d2ce68017ec1a
Reviewed-on: https://chromium-review.googlesource.com/1114199
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570856}
[modify] https://crrev.com/b09ef22f0fcaec3e92f63147f0b08a0e44a5f7ae/third_party/blink/renderer/core/loader/frame_loader.cc

Project Member

Comment 43 by bugdroid1@chromium.org, Jun 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/91f94dcfb2e328e0e5c1f8c61f46e959bb98a556

commit 91f94dcfb2e328e0e5c1f8c61f46e959bb98a556
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Thu Jun 28 00:21:26 2018

Extract FrameLoader::CancelProvisionalLoaderForNewNavigation

This is a common part to be shared between StartNavigation and
CommitNavigation paths.

Bug: 789577
Change-Id: I3e90d158b411b9134bcd8d1a333c81875cff8753
Reviewed-on: https://chromium-review.googlesource.com/1107240
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570969}
[add] https://crrev.com/91f94dcfb2e328e0e5c1f8c61f46e959bb98a556/third_party/WebKit/LayoutTests/http/tests/loading/onbeforeunload-detach-expected.txt
[add] https://crrev.com/91f94dcfb2e328e0e5c1f8c61f46e959bb98a556/third_party/WebKit/LayoutTests/http/tests/loading/onbeforeunload-detach.html
[add] https://crrev.com/91f94dcfb2e328e0e5c1f8c61f46e959bb98a556/third_party/WebKit/LayoutTests/http/tests/loading/onreadystatechange-detach-expected.txt
[add] https://crrev.com/91f94dcfb2e328e0e5c1f8c61f46e959bb98a556/third_party/WebKit/LayoutTests/http/tests/loading/onreadystatechange-detach.html
[add] https://crrev.com/91f94dcfb2e328e0e5c1f8c61f46e959bb98a556/third_party/WebKit/LayoutTests/http/tests/loading/resources/onbeforeunload-detach-iframe.html
[add] https://crrev.com/91f94dcfb2e328e0e5c1f8c61f46e959bb98a556/third_party/WebKit/LayoutTests/http/tests/loading/resources/onreadystatechange-detach-iframe.html
[modify] https://crrev.com/91f94dcfb2e328e0e5c1f8c61f46e959bb98a556/third_party/blink/renderer/core/loader/frame_loader.cc
[modify] https://crrev.com/91f94dcfb2e328e0e5c1f8c61f46e959bb98a556/third_party/blink/renderer/core/loader/frame_loader.h

Project Member

Comment 44 by bugdroid1@chromium.org, Jun 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d665b5d8d3fe1f85cac3a1c620ea9370e4fd3cb8

commit d665b5d8d3fe1f85cac3a1c620ea9370e4fd3cb8
Author: Arthur Hemery <ahemery@chromium.org>
Date: Thu Jun 28 12:21:53 2018

Reworking DocumentState creation.

Prepares moving DocumentState creation outside of
DidCreateDocumentLoader. It does a few things:

- Separates the paths between using pending_navigation_params_
and not using them to build DocumentState.
- Removes the dependencies on navigation_state in
DidCreateDocumentLoader. Instead we use the pending_navigation_params_
directly. Also removes reliance on default constructed values of
CommonNavigationParams and RequestNavigationParams members.
- Moved as much things as possible out of the main class into
utilities in the anonymous namespace.
- Stripped UpdateNavigationState that is now only used to update same
document navigation states.


Bug: 789577
Change-Id: I18d12d24827c3289ef909d9253fe8bbf6ca5080f
Reviewed-on: https://chromium-review.googlesource.com/1109831
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Arthur Hemery <ahemery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571090}
[modify] https://crrev.com/d665b5d8d3fe1f85cac3a1c620ea9370e4fd3cb8/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/d665b5d8d3fe1f85cac3a1c620ea9370e4fd3cb8/content/renderer/render_frame_impl.h
[modify] https://crrev.com/d665b5d8d3fe1f85cac3a1c620ea9370e4fd3cb8/content/renderer/service_worker/service_worker_network_provider.cc
[modify] https://crrev.com/d665b5d8d3fe1f85cac3a1c620ea9370e4fd3cb8/content/renderer/service_worker/service_worker_network_provider.h

Project Member

Comment 47 by bugdroid1@chromium.org, Jul 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e46ff0c6936bb45702187ebf0dfa4e38d3717cc4

commit e46ff0c6936bb45702187ebf0dfa4e38d3717cc4
Author: Matt Falkenhagen <falken@chromium.org>
Date: Mon Jul 02 04:42:38 2018

service worker/navigation: Minor code cleanup after PlzNavigate.

Bug: 789577
Change-Id: I9f9424b5fcb51e2a00e5aa528ade35737fd335b7
Reviewed-on: https://chromium-review.googlesource.com/1121940
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571817}
[modify] https://crrev.com/e46ff0c6936bb45702187ebf0dfa4e38d3717cc4/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/e46ff0c6936bb45702187ebf0dfa4e38d3717cc4/content/browser/service_worker/service_worker_request_handler.cc

Project Member

Comment 48 by bugdroid1@chromium.org, Jul 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d8c681779202fff616b684f3434379669dbc5abe

commit d8c681779202fff616b684f3434379669dbc5abe
Author: Arthur Hemery <ahemery@chromium.org>
Date: Mon Jul 02 13:33:10 2018

WebDocumentLoader::ExtraData now std::moved.

WebDocumentLoader::ExtraData was passed via raw pointers. Converting it
to explicitly state ownership through std::unique_ptr.

A comment stated in the code that this is not OK, but I think the
comment is outdated since we don't support direct WebKit embedding
anymore.

Bug: 789577
Change-Id: Id5777b38e7d01ff7086eb6e725710903a691409d
Reviewed-on: https://chromium-review.googlesource.com/1118379
Commit-Queue: Arthur Hemery <ahemery@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571877}
[modify] https://crrev.com/d8c681779202fff616b684f3434379669dbc5abe/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/d8c681779202fff616b684f3434379669dbc5abe/third_party/blink/public/web/web_document_loader.h
[modify] https://crrev.com/d8c681779202fff616b684f3434379669dbc5abe/third_party/blink/renderer/core/exported/web_document_loader_impl.cc
[modify] https://crrev.com/d8c681779202fff616b684f3434379669dbc5abe/third_party/blink/renderer/core/exported/web_document_loader_impl.h

Project Member

Comment 49 by bugdroid1@chromium.org, Jul 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a660e359e6b55754513521fa9d11248f4001eef3

commit a660e359e6b55754513521fa9d11248f4001eef3
Author: Arthur Hemery <ahemery@chromium.org>
Date: Tue Jul 03 16:01:28 2018

DocumentState now passed in commit.

DocumentState is now created in content and passed all the way down to
FrameLoader::CommitNavigation to be put directly into the DocumentLoader.
In DidCreateDocumentLoader we now only create the DocumentState for
cases where the content layer was never yet aware, such as
DocumentLoader from a frame init and Renderer initiated navigations.

A future patch is on its way to remove PendingNavigationParams and build
DocumentState directly from parameters.

Bug: 789577
Change-Id: Iffe7804784b13afc7f9d708828039d723b36ebbf
Reviewed-on: https://chromium-review.googlesource.com/1105985
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Arthur Hemery <ahemery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572242}
[modify] https://crrev.com/a660e359e6b55754513521fa9d11248f4001eef3/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/a660e359e6b55754513521fa9d11248f4001eef3/content/renderer/render_frame_impl.h
[modify] https://crrev.com/a660e359e6b55754513521fa9d11248f4001eef3/content/shell/renderer/layout_test/blink_test_runner.cc
[modify] https://crrev.com/a660e359e6b55754513521fa9d11248f4001eef3/third_party/blink/public/web/web_local_frame.h
[modify] https://crrev.com/a660e359e6b55754513521fa9d11248f4001eef3/third_party/blink/renderer/core/exported/local_frame_client_impl.cc
[modify] https://crrev.com/a660e359e6b55754513521fa9d11248f4001eef3/third_party/blink/renderer/core/exported/local_frame_client_impl.h
[modify] https://crrev.com/a660e359e6b55754513521fa9d11248f4001eef3/third_party/blink/renderer/core/exported/web_frame_test.cc
[modify] https://crrev.com/a660e359e6b55754513521fa9d11248f4001eef3/third_party/blink/renderer/core/frame/frame_test_helpers.cc
[modify] https://crrev.com/a660e359e6b55754513521fa9d11248f4001eef3/third_party/blink/renderer/core/frame/local_frame_client.h
[modify] https://crrev.com/a660e359e6b55754513521fa9d11248f4001eef3/third_party/blink/renderer/core/frame/web_local_frame_impl.cc
[modify] https://crrev.com/a660e359e6b55754513521fa9d11248f4001eef3/third_party/blink/renderer/core/frame/web_local_frame_impl.h
[modify] https://crrev.com/a660e359e6b55754513521fa9d11248f4001eef3/third_party/blink/renderer/core/loader/empty_clients.cc
[modify] https://crrev.com/a660e359e6b55754513521fa9d11248f4001eef3/third_party/blink/renderer/core/loader/empty_clients.h
[modify] https://crrev.com/a660e359e6b55754513521fa9d11248f4001eef3/third_party/blink/renderer/core/loader/frame_loader.cc
[modify] https://crrev.com/a660e359e6b55754513521fa9d11248f4001eef3/third_party/blink/renderer/core/loader/frame_loader.h
[modify] https://crrev.com/a660e359e6b55754513521fa9d11248f4001eef3/third_party/blink/renderer/core/testing/sim/sim_test.cc

Project Member

Comment 50 by bugdroid1@chromium.org, Jul 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/192c03da563b822418491350345c93f2b03e9b80

commit 192c03da563b822418491350345c93f2b03e9b80
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Tue Jul 03 23:01:08 2018

Stop calling DecidePolicyForNavigation when committing

We had enough time with CHECK to ensure this is not needed.

A couple of tests which did browser-initiated navigation do
not dump the policy anymore.

reload-policy-delegate was doing browser-initiated reload,
and does not test anything meaningful for a while. I changed it
to check performance.navigation.type which is pretty similar
is also available for browser-initiated navigation.

Bug: 789577
Change-Id: If89041e4ae9b509e82d724f171a1faa731099965
Reviewed-on: https://chromium-review.googlesource.com/1119380
Reviewed-by: Camille Lamy <clamy@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572383}
[modify] https://crrev.com/192c03da563b822418491350345c93f2b03e9b80/third_party/WebKit/LayoutTests/fast/events/background-tab-on-ctrl-click-expected.txt
[modify] https://crrev.com/192c03da563b822418491350345c93f2b03e9b80/third_party/WebKit/LayoutTests/fast/events/background-tab-on-submit-ctrl-click-expected.txt
[modify] https://crrev.com/192c03da563b822418491350345c93f2b03e9b80/third_party/WebKit/LayoutTests/fast/events/background-tab-on-submit-synthesized-ctrl-click-expected.txt
[modify] https://crrev.com/192c03da563b822418491350345c93f2b03e9b80/third_party/WebKit/LayoutTests/fast/events/background-tab-on-synthesized-ctrl-click-expected.txt
[modify] https://crrev.com/192c03da563b822418491350345c93f2b03e9b80/third_party/WebKit/LayoutTests/fast/loader/middle-click-target-blank-expected.txt
[add] https://crrev.com/192c03da563b822418491350345c93f2b03e9b80/third_party/WebKit/LayoutTests/fast/loader/reload-navigation-type-expected.txt
[add] https://crrev.com/192c03da563b822418491350345c93f2b03e9b80/third_party/WebKit/LayoutTests/fast/loader/reload-navigation-type.html
[delete] https://crrev.com/97f9353ce77dd85ad2c312582d0529b28cd70247/third_party/WebKit/LayoutTests/fast/loader/reload-policy-delegate-expected.txt
[delete] https://crrev.com/97f9353ce77dd85ad2c312582d0529b28cd70247/third_party/WebKit/LayoutTests/fast/loader/reload-policy-delegate.html
[modify] https://crrev.com/192c03da563b822418491350345c93f2b03e9b80/third_party/WebKit/LayoutTests/http/tests/history/back-to-post-expected.txt
[modify] https://crrev.com/192c03da563b822418491350345c93f2b03e9b80/third_party/blink/renderer/core/loader/frame_loader.cc

Project Member

Comment 51 by bugdroid1@chromium.org, Jul 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43fa80cf181eaa3e5ea76eab3fc3047bf13b1b65

commit 43fa80cf181eaa3e5ea76eab3fc3047bf13b1b65
Author: Arthur Hemery <ahemery@chromium.org>
Date: Thu Jul 05 09:50:08 2018

Explicited params in PrepareFrameForCommit.

Made to remove the dependence on pending_navigation_params_ and
making more explicit the required parameters. Part of an effort to
store navigation state in the FrameLoader in the future.

Bug: 789577
Change-Id: Iee22fe94710b1834169011e05da0335dd17ce410
Reviewed-on: https://chromium-review.googlesource.com/1125925
Reviewed-by: Camille Lamy <clamy@chromium.org>
Commit-Queue: Arthur Hemery <ahemery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572746}
[modify] https://crrev.com/43fa80cf181eaa3e5ea76eab3fc3047bf13b1b65/content/renderer/navigation_state_impl.h
[modify] https://crrev.com/43fa80cf181eaa3e5ea76eab3fc3047bf13b1b65/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/43fa80cf181eaa3e5ea76eab3fc3047bf13b1b65/content/renderer/render_frame_impl.h

Project Member

Comment 52 by bugdroid1@chromium.org, Jul 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54c70ea07f851ca902096f6559d5efdfaa485c9b

commit 54c70ea07f851ca902096f6559d5efdfaa485c9b
Author: Arthur Hemery <ahemery@chromium.org>
Date: Mon Jul 09 12:50:50 2018

Fixing post merge nit (comment only).

Adressing dcheng@ last nit made post merge in
https://chromium-review.googlesource.com/c/chromium/src/+/1105985
This is only adding a comment.

Bug: 789577
Change-Id: Ia303dd28fe7932b05523f3541d6b47a64e4065cb
Reviewed-on: https://chromium-review.googlesource.com/1128858
Commit-Queue: Arthur Hemery <ahemery@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573279}
[modify] https://crrev.com/54c70ea07f851ca902096f6559d5efdfaa485c9b/content/renderer/render_frame_impl.cc

Project Member

Comment 53 by bugdroid1@chromium.org, Jul 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/16e324374e6f2f81d9d5b95a3b018db6dafb4874

commit 16e324374e6f2f81d9d5b95a3b018db6dafb4874
Author: Arthur Hemery <ahemery@chromium.org>
Date: Tue Jul 10 13:39:46 2018

Providing NavigationTimings directly to blink.

This removes the dependency on pending_navigation_params_ to provide
timings to the DocumentLoader. These timings are now passed directly
with the ExtraData to blink to be set at creation time.

Part of an effort to store navigation state in the FrameLoader in the
future. The plan is to factore at a later stage other informations
needed by blink (user activated, source location, etc.) in a unique
structure to be passed down.

Bug: 789577
Change-Id: I89c1f601a2f244d604edbec8e46c79c968d93cfd
Reviewed-on: https://chromium-review.googlesource.com/1127034
Commit-Queue: Arthur Hemery <ahemery@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573708}
[modify] https://crrev.com/16e324374e6f2f81d9d5b95a3b018db6dafb4874/content/renderer/dom_serializer_browsertest.cc
[modify] https://crrev.com/16e324374e6f2f81d9d5b95a3b018db6dafb4874/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/16e324374e6f2f81d9d5b95a3b018db6dafb4874/content/shell/renderer/layout_test/blink_test_runner.cc
[modify] https://crrev.com/16e324374e6f2f81d9d5b95a3b018db6dafb4874/third_party/blink/public/web/web_document_loader.h
[modify] https://crrev.com/16e324374e6f2f81d9d5b95a3b018db6dafb4874/third_party/blink/public/web/web_local_frame.h
[add] https://crrev.com/16e324374e6f2f81d9d5b95a3b018db6dafb4874/third_party/blink/public/web/web_navigation_timings.h
[modify] https://crrev.com/16e324374e6f2f81d9d5b95a3b018db6dafb4874/third_party/blink/renderer/core/exported/local_frame_client_impl.cc
[modify] https://crrev.com/16e324374e6f2f81d9d5b95a3b018db6dafb4874/third_party/blink/renderer/core/exported/local_frame_client_impl.h
[modify] https://crrev.com/16e324374e6f2f81d9d5b95a3b018db6dafb4874/third_party/blink/renderer/core/exported/web_document_loader_impl.cc
[modify] https://crrev.com/16e324374e6f2f81d9d5b95a3b018db6dafb4874/third_party/blink/renderer/core/exported/web_document_loader_impl.h
[modify] https://crrev.com/16e324374e6f2f81d9d5b95a3b018db6dafb4874/third_party/blink/renderer/core/exported/web_frame_test.cc
[modify] https://crrev.com/16e324374e6f2f81d9d5b95a3b018db6dafb4874/third_party/blink/renderer/core/frame/frame_test_helpers.cc
[modify] https://crrev.com/16e324374e6f2f81d9d5b95a3b018db6dafb4874/third_party/blink/renderer/core/frame/local_frame_client.h
[modify] https://crrev.com/16e324374e6f2f81d9d5b95a3b018db6dafb4874/third_party/blink/renderer/core/frame/web_local_frame_impl.cc
[modify] https://crrev.com/16e324374e6f2f81d9d5b95a3b018db6dafb4874/third_party/blink/renderer/core/frame/web_local_frame_impl.h
[modify] https://crrev.com/16e324374e6f2f81d9d5b95a3b018db6dafb4874/third_party/blink/renderer/core/loader/document_loader.cc
[modify] https://crrev.com/16e324374e6f2f81d9d5b95a3b018db6dafb4874/third_party/blink/renderer/core/loader/document_loader.h
[modify] https://crrev.com/16e324374e6f2f81d9d5b95a3b018db6dafb4874/third_party/blink/renderer/core/loader/empty_clients.cc
[modify] https://crrev.com/16e324374e6f2f81d9d5b95a3b018db6dafb4874/third_party/blink/renderer/core/loader/empty_clients.h
[modify] https://crrev.com/16e324374e6f2f81d9d5b95a3b018db6dafb4874/third_party/blink/renderer/core/loader/frame_loader.cc
[modify] https://crrev.com/16e324374e6f2f81d9d5b95a3b018db6dafb4874/third_party/blink/renderer/core/loader/frame_loader.h
[modify] https://crrev.com/16e324374e6f2f81d9d5b95a3b018db6dafb4874/third_party/blink/renderer/core/testing/sim/sim_test.cc

Project Member

Comment 54 by bugdroid1@chromium.org, Jul 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e5eea8bde90c506d20888d924444ffb92f1570b3

commit e5eea8bde90c506d20888d924444ffb92f1570b3
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Mon Jul 16 18:58:40 2018

DecidePolicyForNavigation should only be called for content-initiated

Adding CHECKs to verify that we did not miss any cases when it's called
for browser-initiated navigation. Will cleanup after a couple of Canaries.

Bug: 789577

Change-Id: I36890e1cb653a7f1795a187be0d80f2a99e10aaf
Reviewed-on: https://chromium-review.googlesource.com/1135934
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575371}
[modify] https://crrev.com/e5eea8bde90c506d20888d924444ffb92f1570b3/content/renderer/render_frame_impl.cc

Project Member

Comment 55 by bugdroid1@chromium.org, Jul 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2cb9bab6d6394016828290afc6d8dfdc56a15f6e

commit 2cb9bab6d6394016828290afc6d8dfdc56a15f6e
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Mon Jul 23 22:15:07 2018

Split FrameLoader start and commit paths part 2

Inline StartLoad and ShouldContinueForNavigationPolicy into
StartNavigation and CommitNavigation, dropping the parts which are not relevant.

Bug: 789577
Change-Id: I5d580bdffed64340fc2396f7a6a274d8242fd96f
Reviewed-on: https://chromium-review.googlesource.com/1107211
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577287}
[modify] https://crrev.com/2cb9bab6d6394016828290afc6d8dfdc56a15f6e/third_party/blink/renderer/core/loader/frame_loader.cc
[modify] https://crrev.com/2cb9bab6d6394016828290afc6d8dfdc56a15f6e/third_party/blink/renderer/core/loader/frame_loader.h

Project Member

Comment 56 by bugdroid1@chromium.org, Jul 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76b816d25933f584871762b4c3c7cc109826463e

commit 76b816d25933f584871762b4c3c7cc109826463e
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Tue Jul 24 18:17:40 2018

Simplify RenderFrameImpl::DecidePolicyForNavigation

Only renderer-inititated navigations go through DecidePolicyForNavigation
now, so there should be no |pending_navigation_params_| or |extra_data|.

This patch removes previous CHECKs and refactors code
assuming there is no extra_data and pending_navigation_params_.

Bug: 789577
Change-Id: I8ac67b5735e2f4b8976347df593877e0b1d61292
Reviewed-on: https://chromium-review.googlesource.com/1139024
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577612}
[modify] https://crrev.com/76b816d25933f584871762b4c3c7cc109826463e/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/76b816d25933f584871762b4c3c7cc109826463e/third_party/blink/public/web/web_local_frame_client.h
[modify] https://crrev.com/76b816d25933f584871762b4c3c7cc109826463e/third_party/blink/renderer/core/exported/local_frame_client_impl.cc
[modify] https://crrev.com/76b816d25933f584871762b4c3c7cc109826463e/third_party/blink/renderer/core/exported/web_frame_test.cc

Project Member

Comment 57 by bugdroid1@chromium.org, Jul 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f3d8ae51833d0e8d5068960334cf604ddd493d16

commit f3d8ae51833d0e8d5068960334cf604ddd493d16
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Fri Jul 27 17:20:12 2018

Remove CheckForBrowserSideNavigation

This also switches RenderViewTest to LoadHTMLString method,
instead of StartNavigation.

Bug: 789577
Change-Id: Ide2fc31dbf2ce62fd928c30d9170677e4a00e557
Reviewed-on: https://chromium-review.googlesource.com/1147212
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578686}
[modify] https://crrev.com/f3d8ae51833d0e8d5068960334cf604ddd493d16/content/public/test/render_view_test.cc
[modify] https://crrev.com/f3d8ae51833d0e8d5068960334cf604ddd493d16/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/f3d8ae51833d0e8d5068960334cf604ddd493d16/content/renderer/render_view_browsertest.cc
[modify] https://crrev.com/f3d8ae51833d0e8d5068960334cf604ddd493d16/content/test/test_render_frame.cc
[modify] https://crrev.com/f3d8ae51833d0e8d5068960334cf604ddd493d16/third_party/blink/public/platform/web_url_request.h
[modify] https://crrev.com/f3d8ae51833d0e8d5068960334cf604ddd493d16/third_party/blink/renderer/core/frame/web_local_frame_impl.cc
[modify] https://crrev.com/f3d8ae51833d0e8d5068960334cf604ddd493d16/third_party/blink/renderer/core/loader/frame_fetch_context.cc
[modify] https://crrev.com/f3d8ae51833d0e8d5068960334cf604ddd493d16/third_party/blink/renderer/core/loader/frame_loader.cc
[modify] https://crrev.com/f3d8ae51833d0e8d5068960334cf604ddd493d16/third_party/blink/renderer/platform/exported/web_url_request.cc
[modify] https://crrev.com/f3d8ae51833d0e8d5068960334cf604ddd493d16/third_party/blink/renderer/platform/loader/fetch/resource_request.cc
[modify] https://crrev.com/f3d8ae51833d0e8d5068960334cf604ddd493d16/third_party/blink/renderer/platform/loader/fetch/resource_request.h

Project Member

Comment 58 by bugdroid1@chromium.org, Jul 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/69ba140da4e36be14a245f3a21ec053ad2b98a3d

commit 69ba140da4e36be14a245f3a21ec053ad2b98a3d
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Fri Jul 27 17:44:52 2018

FrameLoader: do not rewrite frame load type to reload

Instead, make the right decision on the callsite.
This makes the implicit dependency between the request's
cache mode and frame load type a bit smaller.

Bug: 789577
Change-Id: Id82797025c7ff7160ec9cbeb37f681468127a34c
Reviewed-on: https://chromium-review.googlesource.com/1150836
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578696}
[modify] https://crrev.com/69ba140da4e36be14a245f3a21ec053ad2b98a3d/third_party/blink/renderer/core/frame/web_local_frame_impl.cc
[modify] https://crrev.com/69ba140da4e36be14a245f3a21ec053ad2b98a3d/third_party/blink/renderer/core/loader/frame_loader.cc
[modify] https://crrev.com/69ba140da4e36be14a245f3a21ec053ad2b98a3d/third_party/blink/renderer/core/loader/navigation_scheduler.cc

Project Member

Comment 59 by bugdroid1@chromium.org, Aug 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f1bf890a11b10797112be080c7913d376538c47d

commit f1bf890a11b10797112be080c7913d376538c47d
Author: Matt Falkenhagen <falken@chromium.org>
Date: Wed Aug 01 05:38:00 2018

service worker/navigation: Fix pre-PlzNavigate comment about provider id.

The comment is obsolete. "current architecture" meant pre-PlzNavigate.

Bug: 789577
Change-Id: Ib53714275a7f54503e415f3a1986cb2f498dd37d
Reviewed-on: https://chromium-review.googlesource.com/1156184
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579708}
[modify] https://crrev.com/f1bf890a11b10797112be080c7913d376538c47d/content/common/navigation_params.h

Project Member

Comment 60 by bugdroid1@chromium.org, Aug 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/587bec0ce6206661d53339d1183d07977fed8ee7

commit 587bec0ce6206661d53339d1183d07977fed8ee7
Author: Matt Falkenhagen <falken@chromium.org>
Date: Fri Aug 10 04:43:53 2018

service worker: Remove some pre-PlzNavigate dead code from nav preload.

Bug: 789577
Change-Id: Ib228eed68a8ab418f5a7922a3e1f0f3e4f311c0f
Reviewed-on: https://chromium-review.googlesource.com/1168947
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582058}
[modify] https://crrev.com/587bec0ce6206661d53339d1183d07977fed8ee7/content/browser/loader/resource_requester_info.cc
[modify] https://crrev.com/587bec0ce6206661d53339d1183d07977fed8ee7/content/browser/service_worker/service_worker_fetch_dispatcher.cc

Project Member

Comment 61 by bugdroid1@chromium.org, Aug 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a21610e9535701128eb84d28d837819ab919bd40

commit a21610e9535701128eb84d28d837819ab919bd40
Author: Arthur Hemery <ahemery@chromium.org>
Date: Wed Aug 22 17:22:50 2018

Correcting discrepancy in CommitNavigation signatures.

The interfaces for committing were not kept in sync. The work-in-progress
interface NavigationClient was lacking the added callbacks.
This is corrected in this patch.

Bug: 789577
Change-Id: Ic803d8265e9b8544f1f1027df5d4f5b5991838cf
Reviewed-on: https://chromium-review.googlesource.com/1181051
Commit-Queue: Arthur Hemery <ahemery@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585125}
[modify] https://crrev.com/a21610e9535701128eb84d28d837819ab919bd40/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/a21610e9535701128eb84d28d837819ab919bd40/content/common/navigation_client.mojom
[modify] https://crrev.com/a21610e9535701128eb84d28d837819ab919bd40/content/renderer/navigation_client.cc
[modify] https://crrev.com/a21610e9535701128eb84d28d837819ab919bd40/content/renderer/navigation_client.h
[modify] https://crrev.com/a21610e9535701128eb84d28d837819ab919bd40/content/test/mock_navigation_client_impl.cc
[modify] https://crrev.com/a21610e9535701128eb84d28d837819ab919bd40/content/test/mock_navigation_client_impl.h

Project Member

Comment 62 by bugdroid1@chromium.org, Aug 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33a17747bb2233da0b14dd5e9cee306a80aa9148

commit 33a17747bb2233da0b14dd5e9cee306a80aa9148
Author: Arthur Hemery <ahemery@chromium.org>
Date: Fri Aug 24 11:40:30 2018

Passing blink loading data into single structure.

Following the direct passing of navigation timings information to the
loader:
https://chromium-review.googlesource.com/c/chromium/src/+/1127034,
we move the remaining loading data down the same path and group them
in a new unified structure.

Background:
Currently, we setup the DocumentLoader with browser provided loading
data during the DidCreateDocumentLoader callback. This is modified in
this patch, and relevant loading information is provided directly to
the DocumentLoader at creation time. This reduces the reliance on the
DidCreateDocumentLoader callback and further enables a complete
removal of the PendingNavigationParams used to store browser provided
informations while waiting for the callback.

We do not include these informations in extra_data, to keep a clear
separation between information relevant to the loader
(ExternalLoadingData) and information that will eventually be stored
by the FrameLoader and decoupled from the DocumentLoader (ExtraData).

Bug: 789577
Change-Id: I4306c079a80260386547d4fb85ff8f398c811cc4
Reviewed-on: https://chromium-review.googlesource.com/1127783
Commit-Queue: Arthur Hemery <ahemery@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585798}
[modify] https://crrev.com/33a17747bb2233da0b14dd5e9cee306a80aa9148/content/renderer/dom_serializer_browsertest.cc
[modify] https://crrev.com/33a17747bb2233da0b14dd5e9cee306a80aa9148/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/33a17747bb2233da0b14dd5e9cee306a80aa9148/content/renderer/render_frame_impl.h
[modify] https://crrev.com/33a17747bb2233da0b14dd5e9cee306a80aa9148/content/renderer/service_worker/service_worker_network_provider.h
[modify] https://crrev.com/33a17747bb2233da0b14dd5e9cee306a80aa9148/content/shell/renderer/layout_test/blink_test_runner.cc
[modify] https://crrev.com/33a17747bb2233da0b14dd5e9cee306a80aa9148/third_party/blink/public/web/web_document_loader.h
[modify] https://crrev.com/33a17747bb2233da0b14dd5e9cee306a80aa9148/third_party/blink/public/web/web_local_frame.h
[add] https://crrev.com/33a17747bb2233da0b14dd5e9cee306a80aa9148/third_party/blink/public/web/web_navigation_params.h
[modify] https://crrev.com/33a17747bb2233da0b14dd5e9cee306a80aa9148/third_party/blink/renderer/core/exported/local_frame_client_impl.cc
[modify] https://crrev.com/33a17747bb2233da0b14dd5e9cee306a80aa9148/third_party/blink/renderer/core/exported/local_frame_client_impl.h
[modify] https://crrev.com/33a17747bb2233da0b14dd5e9cee306a80aa9148/third_party/blink/renderer/core/exported/web_document_loader_impl.cc
[modify] https://crrev.com/33a17747bb2233da0b14dd5e9cee306a80aa9148/third_party/blink/renderer/core/exported/web_document_loader_impl.h
[modify] https://crrev.com/33a17747bb2233da0b14dd5e9cee306a80aa9148/third_party/blink/renderer/core/exported/web_frame_test.cc
[modify] https://crrev.com/33a17747bb2233da0b14dd5e9cee306a80aa9148/third_party/blink/renderer/core/frame/frame_test_helpers.cc
[modify] https://crrev.com/33a17747bb2233da0b14dd5e9cee306a80aa9148/third_party/blink/renderer/core/frame/local_frame_client.h
[modify] https://crrev.com/33a17747bb2233da0b14dd5e9cee306a80aa9148/third_party/blink/renderer/core/frame/web_local_frame_impl.cc
[modify] https://crrev.com/33a17747bb2233da0b14dd5e9cee306a80aa9148/third_party/blink/renderer/core/frame/web_local_frame_impl.h
[modify] https://crrev.com/33a17747bb2233da0b14dd5e9cee306a80aa9148/third_party/blink/renderer/core/loader/document_loader.cc
[modify] https://crrev.com/33a17747bb2233da0b14dd5e9cee306a80aa9148/third_party/blink/renderer/core/loader/document_loader.h
[modify] https://crrev.com/33a17747bb2233da0b14dd5e9cee306a80aa9148/third_party/blink/renderer/core/loader/empty_clients.cc
[modify] https://crrev.com/33a17747bb2233da0b14dd5e9cee306a80aa9148/third_party/blink/renderer/core/loader/empty_clients.h
[modify] https://crrev.com/33a17747bb2233da0b14dd5e9cee306a80aa9148/third_party/blink/renderer/core/loader/frame_loader.cc
[modify] https://crrev.com/33a17747bb2233da0b14dd5e9cee306a80aa9148/third_party/blink/renderer/core/loader/frame_loader.h
[modify] https://crrev.com/33a17747bb2233da0b14dd5e9cee306a80aa9148/third_party/blink/renderer/core/testing/sim/sim_test.cc

Project Member

Comment 63 by bugdroid1@chromium.org, Sep 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a1ca22add2038d11daf60ac015f046a7725c1574

commit a1ca22add2038d11daf60ac015f046a7725c1574
Author: Arthur Hemery <ahemery@chromium.org>
Date: Wed Sep 05 09:11:51 2018

Removing outdated usage of pending_navigation_params_.

Remaining usage of pending_navigation_params_ in renderer initiated
navigations where it is always false.

Bug: 789577
Change-Id: Ie8c214b01922f96f9bf3f8b5f6e6be4e82273bed
Reviewed-on: https://chromium-review.googlesource.com/1189804
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Arthur Hemery <ahemery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588801}
[modify] https://crrev.com/a1ca22add2038d11daf60ac015f046a7725c1574/content/renderer/render_frame_impl.cc

Project Member

Comment 64 by bugdroid1@chromium.org, Sep 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/129123b5d7cda3766bb0782ebf50f6d9d426e172

commit 129123b5d7cda3766bb0782ebf50f6d9d426e172
Author: Arthur Hemery <ahemery@chromium.org>
Date: Fri Sep 07 11:59:29 2018

Passing down navigation data for same-doc navigations.

To be able to completely get rid of pending_navigation_params_ we need
to get rid of the same_document dependency on it. It is currently used
to store common and request params in CommitSameDocumentNavigation,
to later create a new state in DidFinishSameDocumentNavigation.

We now imitate what we did for cross-document navigations, pass
down to the loader the navigation information. An issue with this is
that same-document navigations only update NavigationState.
The structure used for now is only accessible in content. To blink it
is an opaque structure. This means that for now, we just carry the
structure all the way back to DidFinishSameDocumentNavigation.

This adds a lot of boilerplate code but will probably be completely
stateless when we have an adequate structure residing in the loader.

Bug: 789577
Change-Id: If872abf20477ee6bdf42053781a2a9077960fe6c
Reviewed-on: https://chromium-review.googlesource.com/1186406
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Arthur Hemery <ahemery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589494}
[modify] https://crrev.com/129123b5d7cda3766bb0782ebf50f6d9d426e172/chrome/renderer/content_settings_observer_browsertest.cc
[modify] https://crrev.com/129123b5d7cda3766bb0782ebf50f6d9d426e172/chrome/renderer/safe_browsing/phishing_classifier_delegate_browsertest.cc
[modify] https://crrev.com/129123b5d7cda3766bb0782ebf50f6d9d426e172/content/public/renderer/document_state.cc
[modify] https://crrev.com/129123b5d7cda3766bb0782ebf50f6d9d426e172/content/public/renderer/document_state.h
[modify] https://crrev.com/129123b5d7cda3766bb0782ebf50f6d9d426e172/content/public/test/render_view_test.cc
[modify] https://crrev.com/129123b5d7cda3766bb0782ebf50f6d9d426e172/content/public/test/render_view_test.h
[modify] https://crrev.com/129123b5d7cda3766bb0782ebf50f6d9d426e172/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/129123b5d7cda3766bb0782ebf50f6d9d426e172/content/renderer/render_frame_impl.h
[modify] https://crrev.com/129123b5d7cda3766bb0782ebf50f6d9d426e172/content/renderer/render_frame_impl_browsertest.cc
[modify] https://crrev.com/129123b5d7cda3766bb0782ebf50f6d9d426e172/third_party/blink/public/web/web_local_frame.h
[modify] https://crrev.com/129123b5d7cda3766bb0782ebf50f6d9d426e172/third_party/blink/renderer/core/exported/local_frame_client_impl.cc
[modify] https://crrev.com/129123b5d7cda3766bb0782ebf50f6d9d426e172/third_party/blink/renderer/core/exported/local_frame_client_impl.h
[modify] https://crrev.com/129123b5d7cda3766bb0782ebf50f6d9d426e172/third_party/blink/renderer/core/exported/web_frame_test.cc
[modify] https://crrev.com/129123b5d7cda3766bb0782ebf50f6d9d426e172/third_party/blink/renderer/core/exported/web_view_test.cc
[modify] https://crrev.com/129123b5d7cda3766bb0782ebf50f6d9d426e172/third_party/blink/renderer/core/frame/local_frame_client.h
[modify] https://crrev.com/129123b5d7cda3766bb0782ebf50f6d9d426e172/third_party/blink/renderer/core/frame/web_local_frame_impl.cc
[modify] https://crrev.com/129123b5d7cda3766bb0782ebf50f6d9d426e172/third_party/blink/renderer/core/frame/web_local_frame_impl.h
[modify] https://crrev.com/129123b5d7cda3766bb0782ebf50f6d9d426e172/third_party/blink/renderer/core/loader/document_loader.cc
[modify] https://crrev.com/129123b5d7cda3766bb0782ebf50f6d9d426e172/third_party/blink/renderer/core/loader/empty_clients.h
[modify] https://crrev.com/129123b5d7cda3766bb0782ebf50f6d9d426e172/third_party/blink/renderer/core/loader/frame_loader.cc
[modify] https://crrev.com/129123b5d7cda3766bb0782ebf50f6d9d426e172/third_party/blink/renderer/core/loader/frame_loader.h

Project Member

Comment 65 by bugdroid1@chromium.org, Sep 14

Project Member

Comment 67 by bugdroid1@chromium.org, Sep 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e561be24f7c16c21d7396d46840d96b30ca8a26

commit 1e561be24f7c16c21d7396d46840d96b30ca8a26
Author: clamy <clamy@chromium.org>
Date: Mon Sep 17 14:45:48 2018

Remove the FrameHostMsg_DidStartProvisionalLoad IPC

It's no longer useful following the launch of PlzNavigate.

Bug: 789577
Change-Id: I185265a1c19a4bcc5bcc318586b33bd4175f9798
Reviewed-on: https://chromium-review.googlesource.com/1131506
Commit-Queue: Camille Lamy <clamy@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591672}
[modify] https://crrev.com/1e561be24f7c16c21d7396d46840d96b30ca8a26/content/browser/frame_host/interstitial_page_navigator_impl.cc
[modify] https://crrev.com/1e561be24f7c16c21d7396d46840d96b30ca8a26/content/browser/frame_host/interstitial_page_navigator_impl.h
[modify] https://crrev.com/1e561be24f7c16c21d7396d46840d96b30ca8a26/content/browser/frame_host/navigation_controller_impl_unittest.cc
[modify] https://crrev.com/1e561be24f7c16c21d7396d46840d96b30ca8a26/content/browser/frame_host/navigation_handle_impl.cc
[modify] https://crrev.com/1e561be24f7c16c21d7396d46840d96b30ca8a26/content/browser/frame_host/navigation_handle_impl.h
[modify] https://crrev.com/1e561be24f7c16c21d7396d46840d96b30ca8a26/content/browser/frame_host/navigator.h
[modify] https://crrev.com/1e561be24f7c16c21d7396d46840d96b30ca8a26/content/browser/frame_host/navigator_impl.cc
[modify] https://crrev.com/1e561be24f7c16c21d7396d46840d96b30ca8a26/content/browser/frame_host/navigator_impl.h
[modify] https://crrev.com/1e561be24f7c16c21d7396d46840d96b30ca8a26/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/1e561be24f7c16c21d7396d46840d96b30ca8a26/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/1e561be24f7c16c21d7396d46840d96b30ca8a26/content/browser/web_contents/web_contents_impl_unittest.cc
[modify] https://crrev.com/1e561be24f7c16c21d7396d46840d96b30ca8a26/content/common/frame_messages.h
[modify] https://crrev.com/1e561be24f7c16c21d7396d46840d96b30ca8a26/content/public/test/navigation_simulator.cc
[modify] https://crrev.com/1e561be24f7c16c21d7396d46840d96b30ca8a26/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/1e561be24f7c16c21d7396d46840d96b30ca8a26/content/renderer/render_view_browsertest.cc
[modify] https://crrev.com/1e561be24f7c16c21d7396d46840d96b30ca8a26/content/test/test_render_frame_host.cc

Project Member

Comment 68 by bugdroid1@chromium.org, Sep 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c38237e6593750c763fa8a69308c37850b42f7a7

commit c38237e6593750c763fa8a69308c37850b42f7a7
Author: Arthur Sonzogni <arthursonzogni@chromium.org>
Date: Tue Sep 18 12:27:14 2018

ThrottlingURLLoader: Cleanup IsBrowserSideNavigationEnabled usages.

It's no longer useful following the launch of PlzNavigate.

Bug:  756751 , 789577
Change-Id: If342a766d03a832f6c333eccec970b4506faa847
Reviewed-on: https://chromium-review.googlesource.com/1230054
Reviewed-by: Camille Lamy <clamy@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592008}
[modify] https://crrev.com/c38237e6593750c763fa8a69308c37850b42f7a7/content/common/throttling_url_loader.cc
[modify] https://crrev.com/c38237e6593750c763fa8a69308c37850b42f7a7/content/common/throttling_url_loader.h
[modify] https://crrev.com/c38237e6593750c763fa8a69308c37850b42f7a7/content/common/throttling_url_loader_unittest.cc

Project Member

Comment 69 by bugdroid1@chromium.org, Sep 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/57d111143ffdba15eb821f8943005483d10f3117

commit 57d111143ffdba15eb821f8943005483d10f3117
Author: Arthur Sonzogni <arthursonzogni@chromium.org>
Date: Wed Sep 19 15:40:13 2018

Rename browser_side_navigation_browser_tests.cc

BrowserSideNavigation (aka PlzNavigate) launched. There is no more need
to prefix those tests with the "BrowserSide" prefix.

Bug: 789577
Change-Id: I5987644fdee4020eae1d7e420be1d24f6c656919
Reviewed-on: https://chromium-review.googlesource.com/1233493
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592411}
[rename] https://crrev.com/57d111143ffdba15eb821f8943005483d10f3117/content/browser/navigation_browsertest.cc
[modify] https://crrev.com/57d111143ffdba15eb821f8943005483d10f3117/content/test/BUILD.gn

Project Member

Comment 70 by bugdroid1@chromium.org, Oct 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/efd54b0e79ba20a52a862180b462868ede287319

commit efd54b0e79ba20a52a862180b462868ede287319
Author: Camille Lamy <clamy@chromium.org>
Date: Thu Oct 04 16:54:14 2018

Remove FrameHostMsg_DidStartLoading

Following the launch of PlzNavigate, this IPC is no longer useful: the browser
process is fully responsible for setting a RenderFrame in a loading state and
does need a notification from the renderer process.

Bug: 789577
Change-Id: I18ea2965f0151170e765af4e225475ad7a2f6202
Reviewed-on: https://chromium-review.googlesource.com/c/1131739
Commit-Queue: Camille Lamy <clamy@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596708}
[modify] https://crrev.com/efd54b0e79ba20a52a862180b462868ede287319/content/browser/frame_host/frame_tree_node.cc
[modify] https://crrev.com/efd54b0e79ba20a52a862180b462868ede287319/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/efd54b0e79ba20a52a862180b462868ede287319/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/efd54b0e79ba20a52a862180b462868ede287319/content/browser/web_contents/web_contents_impl_unittest.cc
[modify] https://crrev.com/efd54b0e79ba20a52a862180b462868ede287319/content/common/frame_messages.h
[modify] https://crrev.com/efd54b0e79ba20a52a862180b462868ede287319/content/public/test/navigation_simulator.cc
[modify] https://crrev.com/efd54b0e79ba20a52a862180b462868ede287319/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/efd54b0e79ba20a52a862180b462868ede287319/content/renderer/render_frame_impl.h
[modify] https://crrev.com/efd54b0e79ba20a52a862180b462868ede287319/content/test/test_render_frame_host.cc
[modify] https://crrev.com/efd54b0e79ba20a52a862180b462868ede287319/third_party/blink/public/web/web_local_frame_client.h
[modify] https://crrev.com/efd54b0e79ba20a52a862180b462868ede287319/third_party/blink/renderer/core/exported/local_frame_client_impl.cc
[modify] https://crrev.com/efd54b0e79ba20a52a862180b462868ede287319/third_party/blink/renderer/core/exported/local_frame_client_impl.h
[modify] https://crrev.com/efd54b0e79ba20a52a862180b462868ede287319/third_party/blink/renderer/core/exported/web_frame_test.cc
[modify] https://crrev.com/efd54b0e79ba20a52a862180b462868ede287319/third_party/blink/renderer/core/frame/frame_test_helpers.cc
[modify] https://crrev.com/efd54b0e79ba20a52a862180b462868ede287319/third_party/blink/renderer/core/frame/frame_test_helpers.h
[modify] https://crrev.com/efd54b0e79ba20a52a862180b462868ede287319/third_party/blink/renderer/core/frame/local_frame_client.h
[modify] https://crrev.com/efd54b0e79ba20a52a862180b462868ede287319/third_party/blink/renderer/core/loader/empty_clients.h
[modify] https://crrev.com/efd54b0e79ba20a52a862180b462868ede287319/third_party/blink/renderer/core/loader/frame_loader.cc
[modify] https://crrev.com/efd54b0e79ba20a52a862180b462868ede287319/third_party/blink/renderer/core/loader/progress_tracker.cc

Project Member

Comment 71 by bugdroid1@chromium.org, Nov 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f21fb5186095ce43faa66637d743beaaf875b60a

commit f21fb5186095ce43faa66637d743beaaf875b60a
Author: Arthur Sonzogni <arthursonzogni@chromium.org>
Date: Tue Nov 06 09:31:58 2018

Remove unused browser_side_navigation_policy include header.

1) Remove unnecessary include for the header:
   content/public/common/browser_side_navigation_policy.h

2) Rename it navigation_policy.h. BrowserSideNavigation landed, but this header
   remains for navigation related experiments.

R=nasko@chromium.org
TBR=jam@chromium.org

Bug: 789577
Change-Id: I5c42047470291e37df0bd3b13e7bf13ad4726205
Reviewed-on: https://chromium-review.googlesource.com/c/1317919
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605638}
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/chrome/browser/chrome_navigation_browsertest.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/chrome/browser/data_use_measurement/chrome_data_use_ascriber_unittest.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/chrome/browser/extensions/content_verifier_browsertest.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/chrome/browser/extensions/process_manager_browsertest.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/chrome/browser/extensions/window_open_apitest.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/chrome/browser/prerender/prerender_browsertest.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/chrome/browser/safe_browsing/safe_browsing_navigation_observer_unittest.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/chrome/browser/ssl/typed_navigation_timing_throttle.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/chrome/browser/translate/translate_manager_render_view_host_unittest.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/chrome/browser/ui/browser_instant_controller_unittest.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/components/security_interstitials/content/security_interstitial_tab_helper_unittest.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/browser/appcache/appcache_backend_impl.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/browser/appcache/appcache_dispatcher_host.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/browser/devtools/devtools_manager_unittest.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/browser/devtools/protocol/network_handler.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/browser/devtools/protocol/page_handler.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/browser/devtools/protocol/target_auto_attacher.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/browser/devtools/render_frame_devtools_agent_host.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/browser/devtools/render_frame_devtools_agent_host_browsertest.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/browser/download/download_manager_impl.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/browser/download/download_resource_handler.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/browser/frame_host/ancestor_throttle.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/browser/frame_host/blocked_scheme_navigation_browsertest.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/browser/frame_host/blocked_scheme_navigation_throttle.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/browser/frame_host/form_submission_throttle.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/browser/frame_host/form_submission_throttle_browsertest.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/browser/frame_host/frame_tree_node.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/browser/frame_host/interstitial_page_impl_browsertest.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/browser/frame_host/mixed_content_navigation_throttle.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/browser/frame_host/navigation_controller_impl_browsertest.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/browser/frame_host/navigation_controller_impl_unittest.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/browser/frame_host/navigation_entry_impl.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/browser/frame_host/navigation_handle_impl.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/browser/frame_host/navigation_handle_impl_browsertest.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/browser/frame_host/navigation_handle_impl_unittest.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/browser/frame_host/navigation_request.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/browser/frame_host/navigator_impl.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/browser/frame_host/render_frame_host_impl_browsertest.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/browser/frame_host/render_frame_host_manager_browsertest.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/browser/frame_host/render_frame_host_manager_unittest.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/browser/frame_host/webui_navigation_browsertest.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/browser/isolated_origin_browsertest.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/browser/loader/loader_browsertest.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/browser/loader/navigation_url_loader.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/browser/loader/reload_cache_control_browsertest.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/browser/loader/resource_dispatcher_host_unittest.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/browser/loader/resource_loader.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/browser/loader/resource_request_info_impl.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/browser/loader/resource_requester_info.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/browser/navigation_browsertest.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/browser/renderer_host/render_process_host_unittest.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/browser/screen_orientation/screen_orientation_browsertest.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/browser/security_exploit_browsertest.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/browser/service_worker/service_worker_controllee_request_handler.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/browser/service_worker/service_worker_dispatcher_host_unittest.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/browser/service_worker/service_worker_fetch_dispatcher.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/browser/service_worker/service_worker_info.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/browser/service_worker/service_worker_object_host.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/browser/service_worker/service_worker_process_manager.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/browser/service_worker/service_worker_provider_host_unittest.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/browser/service_worker/service_worker_request_handler.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/browser/service_worker/service_worker_url_request_job_unittest.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/browser/service_worker/service_worker_version.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/browser/site_per_process_browsertest.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/browser/web_contents/aura/overscroll_navigation_overlay_unittest.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/browser/web_contents/web_contents_impl_unittest.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/common/navigation_params.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/common/service_worker/service_worker_utils.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/public/common/BUILD.gn
[rename] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/public/common/navigation_policy.cc
[rename] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/public/common/navigation_policy.h
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/public/common/url_utils.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/public/common/url_utils_unittest.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/public/test/navigation_simulator.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/public/test/test_renderer_host.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/renderer/loader/resource_dispatcher.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/renderer/loader/web_url_loader_impl.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/renderer/render_view_browsertest.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/renderer/render_view_impl.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/renderer/service_worker/service_worker_network_provider.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/test/navigation_simulator_unittest.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/test/test_navigation_url_loader.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/test/test_render_frame.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/test/test_render_frame_host.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/test/test_web_contents.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/content/test/url_loader_interceptor_test.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/extensions/browser/api/feedback_private/feedback_private_api.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/extensions/browser/api/web_request/web_request_api.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/extensions/browser/guest_view/mime_handler_view/mime_handler_stream_manager.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/extensions/browser/guest_view/web_view/web_view_guest.cc
[modify] https://crrev.com/f21fb5186095ce43faa66637d743beaaf875b60a/extensions/renderer/script_injection_manager.cc

Project Member

Comment 72 by bugdroid1@chromium.org, Dec 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3bbe76430d255559f43f97c813d0c89fb9dfe90d

commit 3bbe76430d255559f43f97c813d0c89fb9dfe90d
Author: Nasko Oskov <nasko@chromium.org>
Date: Thu Dec 27 19:49:13 2018

Cleanup some uses of IsBrowserSideNavigationEnabled()

Browser Side Navigation (aka PlzNavigate) has been the only navigation
code path since M65, so these calls are no longer necessary.

Bug: 789577
Change-Id: I4572c05be6f6a7365b9b841d535ab6d56dd4f2fd
Reviewed-on: https://chromium-review.googlesource.com/c/1391487
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619057}
[modify] https://crrev.com/3bbe76430d255559f43f97c813d0c89fb9dfe90d/content/browser/loader/resource_loader.cc
[modify] https://crrev.com/3bbe76430d255559f43f97c813d0c89fb9dfe90d/content/browser/loader/resource_request_info_impl.cc
[modify] https://crrev.com/3bbe76430d255559f43f97c813d0c89fb9dfe90d/content/browser/loader/resource_request_info_impl.h
[modify] https://crrev.com/3bbe76430d255559f43f97c813d0c89fb9dfe90d/content/public/browser/resource_request_info.h
[modify] https://crrev.com/3bbe76430d255559f43f97c813d0c89fb9dfe90d/content/public/test/test_renderer_host.cc
[modify] https://crrev.com/3bbe76430d255559f43f97c813d0c89fb9dfe90d/content/renderer/loader/resource_dispatcher.cc
[modify] https://crrev.com/3bbe76430d255559f43f97c813d0c89fb9dfe90d/content/renderer/loader/web_url_loader_impl.cc
[modify] https://crrev.com/3bbe76430d255559f43f97c813d0c89fb9dfe90d/content/test/test_navigation_url_loader.cc
[modify] https://crrev.com/3bbe76430d255559f43f97c813d0c89fb9dfe90d/content/test/test_render_frame_host.cc

Project Member

Comment 73 by bugdroid1@chromium.org, Dec 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/356acc5811dc8db2ecd64b1f0f7c36cc57e7b710

commit 356acc5811dc8db2ecd64b1f0f7c36cc57e7b710
Author: Nasko Oskov <nasko@chromium.org>
Date: Fri Dec 28 20:40:36 2018

Enable SecurityExploitBrowserTest.AttemptDuplicateRenderWidgetHost

This test seems to be working fine at this time, so enabling it to see
if it fails on any bots.

Bug: 789577
Change-Id: I13b59de2dde7e7f7a19f7fb9bb3cfc33bc260207
Reviewed-on: https://chromium-review.googlesource.com/c/1390952
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619189}
[modify] https://crrev.com/356acc5811dc8db2ecd64b1f0f7c36cc57e7b710/content/browser/security_exploit_browsertest.cc

Project Member

Comment 74 by bugdroid1@chromium.org, Jan 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3814d77c2bb4058d705bdc3128e52b59083073b0

commit 3814d77c2bb4058d705bdc3128e52b59083073b0
Author: Nasko Oskov <nasko@chromium.org>
Date: Thu Jan 03 23:45:26 2019

Enable InterstitialPageImplTest.UnderlyingSubframeCommit

IsBrowserSideNavigationEnabled() is now always returning true, causing
this test to be disabled. It does pass now, so we can potentially
enable it if it is still valid.

Bug: 789577
Change-Id: I85438a626b6b764c4ad07e6e74d7cb08c8adad4a
Reviewed-on: https://chromium-review.googlesource.com/c/1394932
Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619810}
[modify] https://crrev.com/3814d77c2bb4058d705bdc3128e52b59083073b0/content/browser/frame_host/interstitial_page_impl_browsertest.cc

Project Member

Comment 75 by bugdroid1@chromium.org, Jan 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/83bb45ef135989c03620a3764b5bd92b7ee29735

commit 83bb45ef135989c03620a3764b5bd92b7ee29735
Author: Nasko Oskov <nasko@chromium.org>
Date: Fri Jan 04 22:46:08 2019

Remove IsBrowserSideNavigationEnabled method.

Browser Side Navigation (aka PlzNavigate) has been the only navigation
code path since M65, so IsBrowserSideNavigationEnabled is a redundant
method. This CL removes the last usage of it.
Since the last test gated by it is failing, I've just move it to
DISABLED_ rather than using the policy function, which semantically does
the same thing.

Bug: 789577
Change-Id: I8e4050d382a897929a6c8c5555d2bf4a25d2fc53
Reviewed-on: https://chromium-review.googlesource.com/c/1396302
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620094}
[modify] https://crrev.com/83bb45ef135989c03620a3764b5bd92b7ee29735/chrome/browser/extensions/process_manager_browsertest.cc
[modify] https://crrev.com/83bb45ef135989c03620a3764b5bd92b7ee29735/content/public/common/navigation_policy.cc
[modify] https://crrev.com/83bb45ef135989c03620a3764b5bd92b7ee29735/content/public/common/navigation_policy.h

Project Member

Comment 76 by bugdroid1@chromium.org, Jan 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fab3b904130e4d27c272eb7f0c2a5cc41316f9e5

commit fab3b904130e4d27c272eb7f0c2a5cc41316f9e5
Author: Nasko Oskov <nasko@chromium.org>
Date: Thu Jan 10 19:19:50 2019

Remove PlzNavigateNavigationHandleImplBrowserTest class.

Browser Side Navigation (aka PlzNavigate) has been the only navigation
code path since M65, so this class is no longer needed.

Bug: 789577
Change-Id: I0fc2ead3f32655bd109d5fcf941a297e936b07df
Reviewed-on: https://chromium-review.googlesource.com/c/1405498
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621692}
[modify] https://crrev.com/fab3b904130e4d27c272eb7f0c2a5cc41316f9e5/content/browser/frame_host/navigation_handle_impl_browsertest.cc

Sign in to add a comment