Schedule v8.browsing_desktop-future on the perf waterfall. |
||||
Issue descriptionThis is the cl: https://chromium-review.googlesource.com/c/chromium/src/+/784871 that will add a new benchmark v8.browsing_desktop-future. Please schedule it on the perf waterfall.
,
Nov 29 2017
I am sorry, I forgot to specify that I am adding two benchmarks in that cl and we want both v8.browsing_dekstop-future and v8.browsing_mobile-future to be scheduled on the perf waterfall.
,
Nov 29 2017
,
Nov 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/be454593e934f4e8c8fa0254d8592fb8bab012fb commit be454593e934f4e8c8fa0254d8592fb8bab012fb Author: Mythri Alle <mythria@chromium.org> Date: Wed Nov 29 17:28:59 2017 Add v8.browsing_desktop-future and v8.browsing_mobile-future benchmarks Add --future variants of v8.browse* benchmarks. Adds v8.browsing_desktop-future v8.browsing_mobile-future These are same as v8.browsing_desktop and v8.browsing_mobile benchmarks but run --future configuration of V8. These test the features enabled on --future flag. Bug: chromium:789571 Change-Id: Ib0934ff43753eb9d4d52622f1111ba8ecf289580 Reviewed-on: https://chromium-review.googlesource.com/784871 Reviewed-by: Ned Nguyen <nednguyen@google.com> Reviewed-by: Michael Hablich <hablich@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#520152} [modify] https://crrev.com/be454593e934f4e8c8fa0254d8592fb8bab012fb/tools/perf/benchmarks/v8_browsing.py [modify] https://crrev.com/be454593e934f4e8c8fa0254d8592fb8bab012fb/tools/perf/core/perf_data_generator.py
,
Nov 30 2017
,
Nov 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3ef02637dc3c6aec65aed5e3144b96c38e3aa2d1 commit 3ef02637dc3c6aec65aed5e3144b96c38e3aa2d1 Author: Ashley Enstad <ashleymarie@chromium.org> Date: Thu Nov 30 23:55:02 2017 Scheduling v8.browsing_mobile-future and v8.browsing_desktop-future Scheduling these benchmarks on the perf waterfall. Turns out, even if you know a benchmark won't be run on certain types of devices, you still have to add them to the sharding map for those configurations. Example: loading.mobile is sharded onto windows bots even though the tests are specifically for mobile configurations. We should change the unscheduled benchmarks check of perf_data_generator.py in the future. perf_data_generator seems to do the right thing in not scheduling the benchmarks on configurations that don't run them. BUG=chromium:789571 Change-Id: I1a7b785cc04f5b207d6a60d05b8177bc9e7df37c Reviewed-on: https://chromium-review.googlesource.com/801580 Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Ashley Enstad <ashleymarie@chromium.org> Cr-Commit-Position: refs/heads/master@{#520756} [modify] https://crrev.com/3ef02637dc3c6aec65aed5e3144b96c38e3aa2d1/testing/buildbot/chromium.perf.fyi.json [modify] https://crrev.com/3ef02637dc3c6aec65aed5e3144b96c38e3aa2d1/testing/buildbot/chromium.perf.json [modify] https://crrev.com/3ef02637dc3c6aec65aed5e3144b96c38e3aa2d1/tools/perf/benchmark.csv [modify] https://crrev.com/3ef02637dc3c6aec65aed5e3144b96c38e3aa2d1/tools/perf/core/benchmark_sharding_map.json [modify] https://crrev.com/3ef02637dc3c6aec65aed5e3144b96c38e3aa2d1/tools/perf/core/perf_data_generator.py
,
Aug 1
|
||||
►
Sign in to add a comment |
||||
Comment 1 by nedngu...@google.com
, Nov 29 2017