New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 789570 link

Starred by 1 user
Status: Fixed
Owner:
█ jose.dap...@lge.com
Last visit > 30 days ago
Closed: Nov 2017
Cc:
ikilpatrick@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug-Regression



Sign in to add a comment

Chromium Linux build fails on GCC: SecureContextMode defined as enum and as getter

Project Member Reported by jose.dap...@lge.com, Nov 29 2017 
Yocto poky pyro for Raspberry Pi 2. GCC version 6.3.0.

Snippet of log that contains the failure:

| ../../../chromium-64.0.3278.0/third_party/WebKit/Source/core/dom/ExecutionContext.h:181:3: error: declaration of 'blink::SecureContextMode blink::ExecutionContext::SecureContextMode() const' [-fpermissive]
|    }
|    ^
| ../../../chromium-64.0.3278.0/third_party/WebKit/Source/core/dom/ExecutionContext.h:72:12: error: changes meaning of 'SecureContextMode' from 'enum class blink::SecureContextMode' [-fpermissive]
|  enum class SecureContextMode { kInsecureContext, kSecureContext };

This is a build regression caused by this commit:
    commit 98b46470f307a68c8183d628237d7b361af96244
    Author: Ian Kilpatrick <ikilpatrick@chromium.org>
    Date:   Tue Nov 21 01:22:24 2017 +0000

    Add secure_context_mode_ to CSSParserContext.

Comment 1 by jose.dap...@lge.com, Nov 29 2017

Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b3ae479f21359860014b90d1adc25be92b4c022

commit 8b3ae479f21359860014b90d1adc25be92b4c022
Author: Jose Dapena Paz <jose.dapena@lge.com>
Date: Thu Nov 30 08:57:42 2017

Build fix for GCC: conflicting declarations of SecureContextMode.

ExecutionContext declares the enum SecureContextMode, and also an
accessor with the same name. That causes a compilation error in
GCC. This change renames the accessor to be GetSecureContextMode.

The regression was introduced by this commit:
    commit 98b46470f307a68c8183d628237d7b361af96244
    Author: Ian Kilpatrick <ikilpatrick@chromium.org>
    Date:   Tue Nov 21 01:22:24 2017 +0000

    Add secure_context_mode_ to CSSParserContext.

Bug:  789570 
Change-Id: I66b51e9b1c9c6d076eb0439b7de4b93121b42f45
Reviewed-on: https://chromium-review.googlesource.com/796892
Commit-Queue: José Dapena Paz <jose.dapena@lge.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520480}
[modify] https://crrev.com/8b3ae479f21359860014b90d1adc25be92b4c022/third_party/WebKit/Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp
[modify] https://crrev.com/8b3ae479f21359860014b90d1adc25be92b4c022/third_party/WebKit/Source/core/animation/AnimationInputHelpers.cpp
[modify] https://crrev.com/8b3ae479f21359860014b90d1adc25be92b4c022/third_party/WebKit/Source/core/animation/AnimationSimTest.cpp
[modify] https://crrev.com/8b3ae479f21359860014b90d1adc25be92b4c022/third_party/WebKit/Source/core/animation/CSSInterpolationType.cpp
[modify] https://crrev.com/8b3ae479f21359860014b90d1adc25be92b4c022/third_party/WebKit/Source/core/animation/EffectInput.cpp
[modify] https://crrev.com/8b3ae479f21359860014b90d1adc25be92b4c022/third_party/WebKit/Source/core/css/CSSGroupingRule.cpp
[modify] https://crrev.com/8b3ae479f21359860014b90d1adc25be92b4c022/third_party/WebKit/Source/core/css/CSSKeyframesRule.cpp
[modify] https://crrev.com/8b3ae479f21359860014b90d1adc25be92b4c022/third_party/WebKit/Source/core/css/CSSPageRule.cpp
[modify] https://crrev.com/8b3ae479f21359860014b90d1adc25be92b4c022/third_party/WebKit/Source/core/css/CSSPaintValue.cpp
[modify] https://crrev.com/8b3ae479f21359860014b90d1adc25be92b4c022/third_party/WebKit/Source/core/css/CSSStyleDeclaration.h
[modify] https://crrev.com/8b3ae479f21359860014b90d1adc25be92b4c022/third_party/WebKit/Source/core/css/CSSStyleRule.cpp
[modify] https://crrev.com/8b3ae479f21359860014b90d1adc25be92b4c022/third_party/WebKit/Source/core/css/DOMWindowCSS.cpp
[modify] https://crrev.com/8b3ae479f21359860014b90d1adc25be92b4c022/third_party/WebKit/Source/core/css/FontFaceSetDocument.cpp
[modify] https://crrev.com/8b3ae479f21359860014b90d1adc25be92b4c022/third_party/WebKit/Source/core/css/FontFaceSetWorker.cpp
[modify] https://crrev.com/8b3ae479f21359860014b90d1adc25be92b4c022/third_party/WebKit/Source/core/css/PropertySetCSSStyleDeclaration.cpp
[modify] https://crrev.com/8b3ae479f21359860014b90d1adc25be92b4c022/third_party/WebKit/Source/core/css/cssom/CSSStyleValue.cpp
[modify] https://crrev.com/8b3ae479f21359860014b90d1adc25be92b4c022/third_party/WebKit/Source/core/css/cssom/CSSTransformComponent.cpp
[modify] https://crrev.com/8b3ae479f21359860014b90d1adc25be92b4c022/third_party/WebKit/Source/core/css/parser/CSSParserContext.cpp
[modify] https://crrev.com/8b3ae479f21359860014b90d1adc25be92b4c022/third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.cpp
[modify] https://crrev.com/8b3ae479f21359860014b90d1adc25be92b4c022/third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp
[modify] https://crrev.com/8b3ae479f21359860014b90d1adc25be92b4c022/third_party/WebKit/Source/core/dom/Element.cpp
[modify] https://crrev.com/8b3ae479f21359860014b90d1adc25be92b4c022/third_party/WebKit/Source/core/dom/ExecutionContext.h
[modify] https://crrev.com/8b3ae479f21359860014b90d1adc25be92b4c022/third_party/WebKit/Source/core/editing/EditingStyle.cpp
[modify] https://crrev.com/8b3ae479f21359860014b90d1adc25be92b4c022/third_party/WebKit/Source/core/editing/EditingStyleUtilities.cpp
[modify] https://crrev.com/8b3ae479f21359860014b90d1adc25be92b4c022/third_party/WebKit/Source/core/editing/Editor.cpp
[modify] https://crrev.com/8b3ae479f21359860014b90d1adc25be92b4c022/third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp
[modify] https://crrev.com/8b3ae479f21359860014b90d1adc25be92b4c022/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp
[modify] https://crrev.com/8b3ae479f21359860014b90d1adc25be92b4c022/third_party/WebKit/Source/core/editing/commands/RemoveCSSPropertyCommand.cpp
[modify] https://crrev.com/8b3ae479f21359860014b90d1adc25be92b4c022/third_party/WebKit/Source/core/editing/serializers/StyledMarkupSerializer.cpp
[modify] https://crrev.com/8b3ae479f21359860014b90d1adc25be92b4c022/third_party/WebKit/Source/core/geometry/DOMMatrixReadOnly.cpp
[modify] https://crrev.com/8b3ae479f21359860014b90d1adc25be92b4c022/third_party/WebKit/Source/core/html/HTMLFontElement.cpp
[modify] https://crrev.com/8b3ae479f21359860014b90d1adc25be92b4c022/third_party/WebKit/Source/core/html/HTMLMarqueeElement.cpp
[modify] https://crrev.com/8b3ae479f21359860014b90d1adc25be92b4c022/third_party/WebKit/Source/core/html/canvas/CanvasFontCache.cpp
[modify] https://crrev.com/8b3ae479f21359860014b90d1adc25be92b4c022/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp
[modify] https://crrev.com/8b3ae479f21359860014b90d1adc25be92b4c022/third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp
[modify] https://crrev.com/8b3ae479f21359860014b90d1adc25be92b4c022/third_party/WebKit/Source/modules/canvas/canvas2d/BaseRenderingContext2D.cpp
[modify] https://crrev.com/8b3ae479f21359860014b90d1adc25be92b4c022/third_party/WebKit/Source/modules/canvas/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp

Comment 3 by jose.dap...@lge.com, Nov 30 2017

Status: Fixed (was: Started)
►

Sign in to add a comment