"Force unmount" read-only volumes even while other operation is in progress |
||||||||||||
Issue descriptionCurrently user cannot unmount a removable disk or a provided volume (e.g. mounted ZIP file) while other application is reading files. Since the Files app. can start loading image files for creating thumbnails or scanning for cloud import, it can be sometimes unclear why such volumes cannot be unmounted. Currently we only show an error message and cancel the unmount user request. The user needs to wait until operation ends before unmount. We would like to force unmount when user clicks the eject icon for read-only volumes, as aborting read operation would not break the data inside those volumes. This was originally discussed in Issue 785091.
,
Nov 30 2017
,
Dec 5 2017
,
Dec 5 2017
kinaba@, do you think this is feasible? I guess it is not, looking the nature of the umount command. However I think one possible way is to utilize lazy unmount and manage such transitional state of the volume. Because the thumbnail generation of the Files app. is a sequence of many reading operations, it is going to be cancelled as soon as the current file is done.
,
Dec 5 2017
sgtm, but +benchan@ is the best person to ask, I believe.
,
Jan 30 2018
,
Jan 30 2018
I think it makes sense to do a lazy unmount. We switched from force unmount to lazy unmount a while back (see crbug.com/646224#c5 for more context)
,
Feb 16 2018
,
Feb 28 2018
,
Feb 28 2018
,
Feb 28 2018
,
Apr 19 2018
,
Aug 23
,
Aug 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0bff4aef1e478c93d04a96d74f6ad38a9a1f43db commit 0bff4aef1e478c93d04a96d74f6ad38a9a1f43db Author: Anand K. Mistry <amistry@chromium.org> Date: Thu Aug 23 06:03:43 2018 Use lazy unmount for read-only mount points. A lazy unmount detaches the mount point immediately. Existing file accesses will continue, but any new accesses will fail. For read-only mounts, we do this because there are no changes to sync back to the volume and therefore it is ok if the volume is removed without waiting for the unmount. Note, this doesn't take into account the safety of removing media that should be "safely removed", such as hard disks. BUG= 789562 , 680903 Change-Id: I4dca06f825d5f3b4012bafa9a43e05bfe6455d23 Reviewed-on: https://chromium-review.googlesource.com/1184645 Reviewed-by: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#585410} [modify] https://crrev.com/0bff4aef1e478c93d04a96d74f6ad38a9a1f43db/chrome/browser/chromeos/extensions/file_manager/file_manager_private_apitest.cc [modify] https://crrev.com/0bff4aef1e478c93d04a96d74f6ad38a9a1f43db/chrome/browser/chromeos/extensions/file_manager/private_api_mount.cc [modify] https://crrev.com/0bff4aef1e478c93d04a96d74f6ad38a9a1f43db/chrome/test/data/extensions/api_test/file_browser/mount_test/test.js
,
Aug 29
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/68418e6ca4ef1562b9b97c971698b7a71f931adc commit 68418e6ca4ef1562b9b97c971698b7a71f931adc Author: Anand K Mistry <amistry@chromium.org> Date: Wed Aug 29 18:15:26 2018 cros-disks: Support unmount options for FUSE and archive mounts This allows all mount types to be lazily unmounted. BUG= chromium:789562 TEST=platform_CrosDisks* autotest + cros-disks unittests Change-Id: I53b5223fc043761016b80a458efaea2b57c09da7 Reviewed-on: https://chromium-review.googlesource.com/1184123 Commit-Ready: Anand Mistry <amistry@chromium.org> Tested-by: Anand Mistry <amistry@chromium.org> Reviewed-by: Ben Chan <benchan@chromium.org> [modify] https://crrev.com/68418e6ca4ef1562b9b97c971698b7a71f931adc/cros-disks/platform.cc [modify] https://crrev.com/68418e6ca4ef1562b9b97c971698b7a71f931adc/cros-disks/fuse_mount_manager_unittest.cc [modify] https://crrev.com/68418e6ca4ef1562b9b97c971698b7a71f931adc/cros-disks/archive_manager.cc [modify] https://crrev.com/68418e6ca4ef1562b9b97c971698b7a71f931adc/cros-disks/platform.h [modify] https://crrev.com/68418e6ca4ef1562b9b97c971698b7a71f931adc/cros-disks/fuse_mount_manager.cc
,
Aug 29
|
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by yamaguchi@chromium.org
, Nov 29 2017