Track work specific to exporting passwords on desktop DD: https://docs.google.com/document/d/1miKr2x0PTNIKgt3RQeur51ICQ66uszlYAmFXJONbG_0/edit#heading=h.mnnwhrv1qaak
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ae0adde32d93e5bd1957aa08163d64053f33e4ff commit ae0adde32d93e5bd1957aa08163d64053f33e4ff Author: Christos Froussios <cfroussios@chromium.org> Date: Fri Dec 01 18:47:59 2017 [Password Manager] Export error message is localised We want to show a basic error message to the user, if exporting the passwords to the filesystem fails. Bug: 789561 Change-Id: Ieff5a590dd882374494c3d23c2aef0ff89734545 Reviewed-on: https://chromium-review.googlesource.com/803484 Commit-Queue: Christos Froussios <cfroussios@chromium.org> Reviewed-by: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#520999} [modify] https://crrev.com/ae0adde32d93e5bd1957aa08163d64053f33e4ff/chrome/browser/ui/passwords/destination_file_system.cc [modify] https://crrev.com/ae0adde32d93e5bd1957aa08163d64053f33e4ff/chrome/browser/ui/passwords/destination_file_system.h [modify] https://crrev.com/ae0adde32d93e5bd1957aa08163d64053f33e4ff/components/password_manager/core/browser/export/destination.h [modify] https://crrev.com/ae0adde32d93e5bd1957aa08163d64053f33e4ff/components/password_manager/core/browser/export/password_manager_exporter_unittest.cc [modify] https://crrev.com/ae0adde32d93e5bd1957aa08163d64053f33e4ff/components/password_manager_strings.grdp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2cf1f2b7f4f342023c016f62e3e698b65a12ebdb commit 2cf1f2b7f4f342023c016f62e3e698b65a12ebdb Author: Christos Froussios <cfroussios@chromium.org> Date: Tue Jan 09 16:14:59 2018 [Password Manager] Remove password_manager::Destination password_manager::Destination was a cross-platform abstraction for the export feature. Since only desktop ended up using it, its functionality is collapsed into PasswordManagerExporter. Bug: 789561 Change-Id: I3eee1d6f99f584cc08e81bb9764e74a319667389 Reviewed-on: https://chromium-review.googlesource.com/850875 Commit-Queue: Christos Froussios <cfroussios@chromium.org> Reviewed-by: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#528009} [modify] https://crrev.com/2cf1f2b7f4f342023c016f62e3e698b65a12ebdb/chrome/browser/ui/BUILD.gn [delete] https://crrev.com/da7d328849c5fb0967214dde5ef1d3710ee9034f/chrome/browser/ui/passwords/destination_file_system.cc [delete] https://crrev.com/da7d328849c5fb0967214dde5ef1d3710ee9034f/chrome/browser/ui/passwords/destination_file_system.h [delete] https://crrev.com/da7d328849c5fb0967214dde5ef1d3710ee9034f/chrome/browser/ui/passwords/destination_file_system_unittest.cc [modify] https://crrev.com/2cf1f2b7f4f342023c016f62e3e698b65a12ebdb/chrome/browser/ui/passwords/password_manager_porter.cc [modify] https://crrev.com/2cf1f2b7f4f342023c016f62e3e698b65a12ebdb/chrome/browser/ui/passwords/password_manager_porter_unittest.cc [modify] https://crrev.com/2cf1f2b7f4f342023c016f62e3e698b65a12ebdb/chrome/test/BUILD.gn [modify] https://crrev.com/2cf1f2b7f4f342023c016f62e3e698b65a12ebdb/components/password_manager/core/browser/BUILD.gn [delete] https://crrev.com/da7d328849c5fb0967214dde5ef1d3710ee9034f/components/password_manager/core/browser/export/destination.h [modify] https://crrev.com/2cf1f2b7f4f342023c016f62e3e698b65a12ebdb/components/password_manager/core/browser/export/password_manager_exporter.cc [modify] https://crrev.com/2cf1f2b7f4f342023c016f62e3e698b65a12ebdb/components/password_manager/core/browser/export/password_manager_exporter.h [modify] https://crrev.com/2cf1f2b7f4f342023c016f62e3e698b65a12ebdb/components/password_manager/core/browser/export/password_manager_exporter_unittest.cc [modify] https://crrev.com/2cf1f2b7f4f342023c016f62e3e698b65a12ebdb/components/password_manager_strings.grdp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3e35f6776b0713feb49f1d323bfbfc36d1a1e517 commit 3e35f6776b0713feb49f1d323bfbfc36d1a1e517 Author: Christos Froussios <cfroussios@chromium.org> Date: Wed Jan 17 10:07:34 2018 [Password Manager] Exporting passwords does not reuse previous reauth Viewing passwords on the settins page requires reauth, but only once per minute. Exporting the entire password list now ignores this grace period. Bug: 800686 , 789561 Change-Id: I5f46afc3f0ec123bac371a6fa2329f55c6c20632 Reviewed-on: https://chromium-review.googlesource.com/864149 Reviewed-by: Vaclav Brozek <vabr@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#529690} [modify] https://crrev.com/3e35f6776b0713feb49f1d323bfbfc36d1a1e517/chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl.cc [modify] https://crrev.com/3e35f6776b0713feb49f1d323bfbfc36d1a1e517/chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl_unittest.cc [modify] https://crrev.com/3e35f6776b0713feb49f1d323bfbfc36d1a1e517/chrome/browser/ui/passwords/password_access_authenticator.cc [modify] https://crrev.com/3e35f6776b0713feb49f1d323bfbfc36d1a1e517/chrome/browser/ui/passwords/password_access_authenticator.h [modify] https://crrev.com/3e35f6776b0713feb49f1d323bfbfc36d1a1e517/chrome/browser/ui/passwords/password_access_authenticator_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f4ce91d240b507165c37bed46830106c993eb086 commit f4ce91d240b507165c37bed46830106c993eb086 Author: Christos Froussios <cfroussios@chromium.org> Date: Thu Jan 18 17:46:46 2018 [Password Manager] Update export passwords dialog UI According to the new mocks, we won't show an info icon. We also won't tell the user not to share the exported file. https://docs.google.com/presentation/d/1nIm5OmaOnb85ZAwMZPSVqHT0vkFbsRYZhOzbmznWU_c/edit#slide=id.g284db53a0f_0_50 Bug: 789561 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I4c193c25a18a993dfa29ad0592e8b0a32e3d179c Reviewed-on: https://chromium-review.googlesource.com/868157 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#530190} [modify] https://crrev.com/f4ce91d240b507165c37bed46830106c993eb086/chrome/app/settings_strings.grdp [modify] https://crrev.com/f4ce91d240b507165c37bed46830106c993eb086/chrome/browser/resources/settings/passwords_and_forms_page/passwords_export_dialog.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0a337816849a142be7f936702d3a9d9a56130eb1 commit 0a337816849a142be7f936702d3a9d9a56130eb1 Author: Christos Froussios <cfroussios@chromium.org> Date: Wed Jan 24 19:51:42 2018 [Password Manager] Introduce export callback to the UI I extended chrome.passwordsPrivate with the onPasswordsFileExportProgress event and a callback to exportPasswords function. These serve to notify the UI about the progress of an export request. Bug: 789561 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic2e3c81c2c92128c0726da3193205765350b8df0 Reviewed-on: https://chromium-review.googlesource.com/787472 Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Vaclav Brozek <vabr@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#531653} [modify] https://crrev.com/0a337816849a142be7f936702d3a9d9a56130eb1/chrome/browser/extensions/api/passwords_private/passwords_private_api.cc [modify] https://crrev.com/0a337816849a142be7f936702d3a9d9a56130eb1/chrome/browser/extensions/api/passwords_private/passwords_private_api.h [modify] https://crrev.com/0a337816849a142be7f936702d3a9d9a56130eb1/chrome/browser/extensions/api/passwords_private/passwords_private_apitest.cc [modify] https://crrev.com/0a337816849a142be7f936702d3a9d9a56130eb1/chrome/browser/extensions/api/passwords_private/passwords_private_delegate.h [modify] https://crrev.com/0a337816849a142be7f936702d3a9d9a56130eb1/chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl.cc [modify] https://crrev.com/0a337816849a142be7f936702d3a9d9a56130eb1/chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl.h [modify] https://crrev.com/0a337816849a142be7f936702d3a9d9a56130eb1/chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl_unittest.cc [modify] https://crrev.com/0a337816849a142be7f936702d3a9d9a56130eb1/chrome/browser/extensions/api/passwords_private/passwords_private_event_router.cc [modify] https://crrev.com/0a337816849a142be7f936702d3a9d9a56130eb1/chrome/browser/extensions/api/passwords_private/passwords_private_event_router.h [modify] https://crrev.com/0a337816849a142be7f936702d3a9d9a56130eb1/chrome/browser/resources/settings/passwords_and_forms_page/passwords_export_dialog.js [modify] https://crrev.com/0a337816849a142be7f936702d3a9d9a56130eb1/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js [modify] https://crrev.com/0a337816849a142be7f936702d3a9d9a56130eb1/chrome/browser/ui/passwords/password_manager_porter.cc [modify] https://crrev.com/0a337816849a142be7f936702d3a9d9a56130eb1/chrome/browser/ui/passwords/password_manager_porter.h [modify] https://crrev.com/0a337816849a142be7f936702d3a9d9a56130eb1/chrome/browser/ui/passwords/password_manager_porter_unittest.cc [modify] https://crrev.com/0a337816849a142be7f936702d3a9d9a56130eb1/chrome/common/extensions/api/passwords_private.idl [modify] https://crrev.com/0a337816849a142be7f936702d3a9d9a56130eb1/chrome/test/data/extensions/api_test/passwords_private/test.js [modify] https://crrev.com/0a337816849a142be7f936702d3a9d9a56130eb1/components/password_manager/core/browser/BUILD.gn [modify] https://crrev.com/0a337816849a142be7f936702d3a9d9a56130eb1/components/password_manager/core/browser/export/password_manager_exporter.cc [modify] https://crrev.com/0a337816849a142be7f936702d3a9d9a56130eb1/components/password_manager/core/browser/export/password_manager_exporter.h [modify] https://crrev.com/0a337816849a142be7f936702d3a9d9a56130eb1/components/password_manager/core/browser/export/password_manager_exporter_unittest.cc [modify] https://crrev.com/0a337816849a142be7f936702d3a9d9a56130eb1/components/password_manager/core/browser/ui/export_flow.h [add] https://crrev.com/0a337816849a142be7f936702d3a9d9a56130eb1/components/password_manager/core/browser/ui/export_progress_status.h [modify] https://crrev.com/0a337816849a142be7f936702d3a9d9a56130eb1/extensions/browser/extension_event_histogram_value.h [modify] https://crrev.com/0a337816849a142be7f936702d3a9d9a56130eb1/extensions/browser/extension_function_histogram_value.h [modify] https://crrev.com/0a337816849a142be7f936702d3a9d9a56130eb1/third_party/closure_compiler/externs/passwords_private.js [modify] https://crrev.com/0a337816849a142be7f936702d3a9d9a56130eb1/tools/metrics/histograms/enums.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ba8b05497be7febe8e16f63fadd4ede6c02b8f2c commit ba8b05497be7febe8e16f63fadd4ede6c02b8f2c Author: Christos Froussios <cfroussios@chromium.org> Date: Tue Jan 30 08:29:48 2018 [Password Manager] Add "exporting..." and "error" states to the export passwords dialog The different states of the export flow are implemented as separate dialog instances which replace each other. Mocks: https://docs.google.com/presentation/d/1nIm5OmaOnb85ZAwMZPSVqHT0vkFbsRYZhOzbmznWU_c/edit#slide=id.g289b1efcd8_0_4 Bug: 789561 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id25af371164196ee8fffec723f080be2320e5b22 Reviewed-on: https://chromium-review.googlesource.com/800611 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#532811} [modify] https://crrev.com/ba8b05497be7febe8e16f63fadd4ede6c02b8f2c/chrome/app/settings_strings.grdp [modify] https://crrev.com/ba8b05497be7febe8e16f63fadd4ede6c02b8f2c/chrome/browser/resources/settings/passwords_and_forms_page/passwords_export_dialog.html [modify] https://crrev.com/ba8b05497be7febe8e16f63fadd4ede6c02b8f2c/chrome/browser/resources/settings/passwords_and_forms_page/passwords_export_dialog.js [modify] https://crrev.com/ba8b05497be7febe8e16f63fadd4ede6c02b8f2c/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc [modify] https://crrev.com/ba8b05497be7febe8e16f63fadd4ede6c02b8f2c/chrome/test/data/webui/settings/settings_passwords_section_browsertest.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/37e0a7ffc7ea17783ca00193d87fc117c0df4af6 commit 37e0a7ffc7ea17783ca00193d87fc117c0df4af6 Author: Christos Froussios <cfroussios@chromium.org> Date: Wed Jan 31 11:10:25 2018 [Password Manager] Enable the Password Export feature on Desktop Bug: 790990, 789561 Change-Id: I89dae77899c27ea166ed75c038a82fe0a1278b9a Reviewed-on: https://chromium-review.googlesource.com/893378 Reviewed-by: Vaclav Brozek <vabr@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#533249} [modify] https://crrev.com/37e0a7ffc7ea17783ca00193d87fc117c0df4af6/components/password_manager/core/common/password_manager_features.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9151bb73af57517873ae2b7e476434feb5c94632 commit 9151bb73af57517873ae2b7e476434feb5c94632 Author: Christos Froussios <cfroussios@chromium.org> Date: Wed Jan 31 21:00:36 2018 [Password Manager] Add UMA metrics for the export feature Bug: 789561 Change-Id: If90d55a31821c999ad67c7683c662e6c040e4739 Reviewed-on: https://chromium-review.googlesource.com/893359 Reviewed-by: Jesse Doherty <jwd@chromium.org> Reviewed-by: Vaclav Brozek <vabr@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#533404} [modify] https://crrev.com/9151bb73af57517873ae2b7e476434feb5c94632/components/password_manager/core/browser/export/password_manager_exporter.cc [modify] https://crrev.com/9151bb73af57517873ae2b7e476434feb5c94632/components/password_manager/core/browser/export/password_manager_exporter.h [modify] https://crrev.com/9151bb73af57517873ae2b7e476434feb5c94632/components/password_manager/core/browser/export/password_manager_exporter_unittest.cc [modify] https://crrev.com/9151bb73af57517873ae2b7e476434feb5c94632/components/password_manager/core/browser/password_manager_metrics_util.h [modify] https://crrev.com/9151bb73af57517873ae2b7e476434feb5c94632/tools/metrics/histograms/enums.xml [modify] https://crrev.com/9151bb73af57517873ae2b7e476434feb5c94632/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6979584b93630148ae36e4049c2a691d07b099ca commit 6979584b93630148ae36e4049c2a691d07b099ca Author: Christos Froussios <cfroussios@chromium.org> Date: Fri Feb 02 10:49:28 2018 [Password Manager] Update export UI to match mocks 1. Empty space is introduced between the buttons in the export dialog. 2. The export menu item is the More Actions menu is changed to a different string. Additionally, the string is moved to settings_strings.grdp, next to the rest of the strings. Mocks: https://docs.google.com/presentation/d/1nIm5OmaOnb85ZAwMZPSVqHT0vkFbsRYZhOzbmznWU_c/edit#slide=id.g29b76db41a_0_6 Bug: 789561 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id939ebe158a68ff71e12a783919c7baaea1ed00f Reviewed-on: https://chromium-review.googlesource.com/892881 Commit-Queue: Christos Froussios <cfroussios@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#534018} [modify] https://crrev.com/6979584b93630148ae36e4049c2a691d07b099ca/chrome/app/generated_resources.grd [modify] https://crrev.com/6979584b93630148ae36e4049c2a691d07b099ca/chrome/app/settings_strings.grdp [modify] https://crrev.com/6979584b93630148ae36e4049c2a691d07b099ca/chrome/browser/resources/settings/passwords_and_forms_page/passwords_export_dialog.html [modify] https://crrev.com/6979584b93630148ae36e4049c2a691d07b099ca/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html [modify] https://crrev.com/6979584b93630148ae36e4049c2a691d07b099ca/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d57ac0affdfc1080acc0de78384260798681b92c commit d57ac0affdfc1080acc0de78384260798681b92c Author: Christos Froussios <cfroussios@chromium.org> Date: Tue Feb 06 18:32:11 2018 [Password Manager] Show export menu item only for a non-empty password list Exporting an empty password list has no value for the user. Additionally, exporting while the password list is still loading is undefined behaviour. For these reasons, we only show the Export Passwords menu item only once the password list has been read and is non-empty. Bug: 789561 , 805534 , 807975 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ief82b4b46a231402dbaa7251e514c4078f7be31a Reviewed-on: https://chromium-review.googlesource.com/897486 Commit-Queue: Christos Froussios <cfroussios@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#534728} [modify] https://crrev.com/d57ac0affdfc1080acc0de78384260798681b92c/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3121b3349e8846fab825b5fbb6d0b6bf2cfad870 commit 3121b3349e8846fab825b5fbb6d0b6bf2cfad870 Author: Christos Froussios <cfroussios@chromium.org> Date: Fri Feb 09 18:28:47 2018 [Password Manager] Start serialising passwords for export before file selection Reading and serialising can take a non-trivial amount of time. If we do this while the user is selecting the file destination, we decrease the chance that there will be a delay after the file is selected. Bug: 785237 , 789561 Change-Id: Ifae55091733e0310345385cbdb05023246e2ebff Reviewed-on: https://chromium-review.googlesource.com/911792 Reviewed-by: Vaclav Brozek <vabr@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#535757} [modify] https://crrev.com/3121b3349e8846fab825b5fbb6d0b6bf2cfad870/chrome/browser/ui/passwords/password_manager_porter.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2ed0e987a6e2800a431ae30942424fb0fa09db9b commit 2ed0e987a6e2800a431ae30942424fb0fa09db9b Author: Christos Froussios <cfroussios@chromium.org> Date: Fri Feb 09 19:13:43 2018 [Password Manager] Implement cancel passwords export Exporting passwords is cancelled if the user cancels the file selection dialog. It is necessary to cancel, so that PasswordManagerExporter will cancel any pending tasks and clear any cached password list. Bug: 789561 Change-Id: I3184d6355b21618998b8816e2ccf990a6b785826 Reviewed-on: https://chromium-review.googlesource.com/911791 Reviewed-by: Vaclav Brozek <vabr@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#535777} [modify] https://crrev.com/2ed0e987a6e2800a431ae30942424fb0fa09db9b/chrome/browser/ui/passwords/password_manager_porter.cc [modify] https://crrev.com/2ed0e987a6e2800a431ae30942424fb0fa09db9b/chrome/browser/ui/passwords/password_manager_porter.h [modify] https://crrev.com/2ed0e987a6e2800a431ae30942424fb0fa09db9b/chrome/browser/ui/passwords/password_manager_porter_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9b8321149fd8c80099f26e4ef83b9c5cd1e2a676 commit 9b8321149fd8c80099f26e4ef83b9c5cd1e2a676 Author: Christos Froussios <cfroussios@chromium.org> Date: Thu Feb 15 08:53:35 2018 [Password Manager] Reduce minimum time for showing the export progress The "busy exporting" dialog is shown for at least 2 seconds, to avoid flashing when exporting happens fast. We reduce this time to 1 seconds, as suggested by UX. Bug: 789561 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ibeb1c3736d914ee1d83814dfdc9d3a902fed1796 Reviewed-on: https://chromium-review.googlesource.com/918562 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#536973} [modify] https://crrev.com/9b8321149fd8c80099f26e4ef83b9c5cd1e2a676/chrome/browser/resources/settings/passwords_and_forms_page/passwords_export_dialog.js [modify] https://crrev.com/9b8321149fd8c80099f26e4ef83b9c5cd1e2a676/chrome/test/data/webui/settings/settings_passwords_section_browsertest.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c2c1737ecf6e23b8afb87d2d23f58c8395b6928e commit c2c1737ecf6e23b8afb87d2d23f58c8395b6928e Author: Christos Froussios <cfroussios@chromium.org> Date: Thu Feb 15 09:41:48 2018 [Password Manager] Reauth when exporting has a special message The reauth challenge mentions "showing" a password. This does not correctly describe the intention of exporting the passwords. I introduced an enum for the purpose of the reauth and made the authentication util select the appropriate messaging according to the purpose. Bug: 789561 Change-Id: I64e50f49bb87b41db3dbbfe7e3be50f9395f0985 Reviewed-on: https://chromium-review.googlesource.com/916606 Commit-Queue: Christos Froussios <cfroussios@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#536979} [modify] https://crrev.com/c2c1737ecf6e23b8afb87d2d23f58c8395b6928e/chrome/app/chromium_strings.grd [modify] https://crrev.com/c2c1737ecf6e23b8afb87d2d23f58c8395b6928e/chrome/app/google_chrome_strings.grd [modify] https://crrev.com/c2c1737ecf6e23b8afb87d2d23f58c8395b6928e/chrome/browser/BUILD.gn [modify] https://crrev.com/c2c1737ecf6e23b8afb87d2d23f58c8395b6928e/chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl.cc [modify] https://crrev.com/c2c1737ecf6e23b8afb87d2d23f58c8395b6928e/chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl.h [modify] https://crrev.com/c2c1737ecf6e23b8afb87d2d23f58c8395b6928e/chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl_unittest.cc [modify] https://crrev.com/c2c1737ecf6e23b8afb87d2d23f58c8395b6928e/chrome/browser/password_manager/password_manager_util_mac.h [modify] https://crrev.com/c2c1737ecf6e23b8afb87d2d23f58c8395b6928e/chrome/browser/password_manager/password_manager_util_mac.mm [modify] https://crrev.com/c2c1737ecf6e23b8afb87d2d23f58c8395b6928e/chrome/browser/password_manager/password_manager_util_win.cc [modify] https://crrev.com/c2c1737ecf6e23b8afb87d2d23f58c8395b6928e/chrome/browser/password_manager/password_manager_util_win.h [add] https://crrev.com/c2c1737ecf6e23b8afb87d2d23f58c8395b6928e/chrome/browser/password_manager/reauth_purpose.h [modify] https://crrev.com/c2c1737ecf6e23b8afb87d2d23f58c8395b6928e/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc [modify] https://crrev.com/c2c1737ecf6e23b8afb87d2d23f58c8395b6928e/chrome/browser/ui/passwords/password_access_authenticator.cc [modify] https://crrev.com/c2c1737ecf6e23b8afb87d2d23f58c8395b6928e/chrome/browser/ui/passwords/password_access_authenticator.h [modify] https://crrev.com/c2c1737ecf6e23b8afb87d2d23f58c8395b6928e/chrome/browser/ui/passwords/password_access_authenticator_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/962c7a6e30467b9d85d46a7de0cf8328da04feab commit 962c7a6e30467b9d85d46a7de0cf8328da04feab Author: Christos Froussios <cfroussios@chromium.org> Date: Mon Feb 19 12:00:57 2018 [Password Manager] Export progress dialog dismissable only via cancel button As per mocks https://docs.google.com/presentation/d/1nIm5OmaOnb85ZAwMZPSVqHT0vkFbsRYZhOzbmznWU_c/edit#slide=id.g284db53a0f_0_226 Bug: 789561 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I504755e6f362e130a59c806ed700866df5ef06f4 Reviewed-on: https://chromium-review.googlesource.com/924065 Commit-Queue: Christos Froussios <cfroussios@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#537631} [modify] https://crrev.com/962c7a6e30467b9d85d46a7de0cf8328da04feab/chrome/browser/resources/settings/passwords_and_forms_page/passwords_export_dialog.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ad431f78b0f527f8c512b7b7632120e895c2f8f9 commit ad431f78b0f527f8c512b7b7632120e895c2f8f9 Author: Christos Froussios <cfroussios@chromium.org> Date: Thu Feb 22 14:34:13 2018 [Password Manager] Create a new PasswordManagerExporter for each export Reusing the same instance for PasswordManagerExporter for consecutive exports requests complicates state management in it. We make its state easier to reason about by scoping it to one instance per export. In a future CL we will introduce post-facto cleanup to cancelling an export request. It will be easier to implement if state isn't shared between asynchronous tasks and independent export requests. Bug: 789561 ,811779 Change-Id: I5b9a0e59e0114d57b5a94d51869be6bc65151210 Reviewed-on: https://chromium-review.googlesource.com/921623 Commit-Queue: Christos Froussios <cfroussios@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#538428} [modify] https://crrev.com/ad431f78b0f527f8c512b7b7632120e895c2f8f9/chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl.cc [modify] https://crrev.com/ad431f78b0f527f8c512b7b7632120e895c2f8f9/chrome/browser/ui/passwords/password_manager_porter.cc [modify] https://crrev.com/ad431f78b0f527f8c512b7b7632120e895c2f8f9/chrome/browser/ui/passwords/password_manager_porter.h [modify] https://crrev.com/ad431f78b0f527f8c512b7b7632120e895c2f8f9/chrome/browser/ui/passwords/password_manager_porter_unittest.cc [modify] https://crrev.com/ad431f78b0f527f8c512b7b7632120e895c2f8f9/components/password_manager/core/browser/export/password_manager_exporter.cc [modify] https://crrev.com/ad431f78b0f527f8c512b7b7632120e895c2f8f9/components/password_manager/core/browser/export/password_manager_exporter.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fcca5bf95c62665f045498edcfcdbce67aa43ade commit fcca5bf95c62665f045498edcfcdbce67aa43ade Author: Christos Froussios <cfroussios@chromium.org> Date: Thu Feb 22 15:52:03 2018 [Password Manager] If export is canceled, delete the file The user may chose to cancel the export process at any point * While we are serialising the list * While we are writing to the file * After completion, because the Cancel button was still visible In every of these cases, the result should be that there is no file on the disk. Bug: 789561 ,811779 Change-Id: Ied4b6b662453623446da92dacdb0adcf14fa1629 Reviewed-on: https://chromium-review.googlesource.com/922461 Commit-Queue: Christos Froussios <cfroussios@chromium.org> Reviewed-by: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#538444} [modify] https://crrev.com/fcca5bf95c62665f045498edcfcdbce67aa43ade/components/password_manager/core/browser/export/password_manager_exporter.cc [modify] https://crrev.com/fcca5bf95c62665f045498edcfcdbce67aa43ade/components/password_manager/core/browser/export/password_manager_exporter.h [modify] https://crrev.com/fcca5bf95c62665f045498edcfcdbce67aa43ade/components/password_manager/core/browser/export/password_manager_exporter_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/705ee65406b56f0e30b013d7c4baa2f8f272f4ec commit 705ee65406b56f0e30b013d7c4baa2f8f272f4ec Author: Christos Froussios <cfroussios@chromium.org> Date: Sun Feb 25 17:48:17 2018 [Password Manager] Simplify export tests pulling out setting the password list and allowing to use a base::MockCallback<WriteCallback> in SetWriteForTesting directly to reduce noise in the PasswordManagerExporter test code. Bug: 789561 Change-Id: Ib703b8a720e38f75d57519b9f96f926e93e9a561 Reviewed-on: https://chromium-review.googlesource.com/924422 Commit-Queue: Christos Froussios <cfroussios@chromium.org> Reviewed-by: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#539044} [modify] https://crrev.com/705ee65406b56f0e30b013d7c4baa2f8f272f4ec/components/password_manager/core/browser/export/password_manager_exporter.cc [modify] https://crrev.com/705ee65406b56f0e30b013d7c4baa2f8f272f4ec/components/password_manager/core/browser/export/password_manager_exporter.h [modify] https://crrev.com/705ee65406b56f0e30b013d7c4baa2f8f272f4ec/components/password_manager/core/browser/export/password_manager_exporter_unittest.cc
Issue 691802 has been merged into this issue.
Comment 1 by cfroussios@chromium.org
, Nov 29 2017