New issue
Advanced search Search tips

Issue 789542 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

"PreviewsNoScriptBrowserTest.NoScriptPreviewsEnabled" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Nov 29 2017

Issue description

"PreviewsNoScriptBrowserTest.NoScriptPreviewsEnabled" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyPgsSBUZsYWtlIjNQcmV2aWV3c05vU2NyaXB0QnJvd3NlclRlc3QuTm9TY3JpcHRQcmV2aWV3c0VuYWJsZWQM.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 

Comment 1 by hbos@chromium.org, Nov 29 2017

Components: UI>Browser>Previews
Owner: dougarnett@chromium.org
Status: Assigned (was: Untriaged)
dougarnett can you take a look or re-assign?
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/216b6d2998eca0568eb771a84091c47e53b19453

commit 216b6d2998eca0568eb771a84091c47e53b19453
Author: Henrik Boström <hbos@chromium.org>
Date: Wed Nov 29 14:23:48 2017

Disabled flaky PreviewsNoScriptBrowserTest.NoScriptPreviewsEnabled on windows

TBR=dougarnett@chromium.org,mmenke@chromium.org,tbansal@chromium.org

No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  789542 
Change-Id: I1e48af6ee6b75794863ed0bfc5ddfa28a6a5d9d8
Reviewed-on: https://chromium-review.googlesource.com/796670
Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520102}
[modify] https://crrev.com/216b6d2998eca0568eb771a84091c47e53b19453/chrome/browser/previews/previews_browsertest.cc

Comment 3 by hbos@chromium.org, Nov 29 2017

Labels: -Sheriff-Chromium
Test disabled, removing issue from sheriff's queue.
Bummer, thought I had it working on windows. Ran for 4 weeks before hitting couple failures here. 
Labels: -Pri-1 OS-Windows Pri-2
Labels: -Pri-2 Pri-3
Running on Windows not critical for logic under test so dropping pri

Comment 7 by efoo@chromium.org, Dec 5 2017

Components: Blink>Previews

Comment 8 by efoo@chromium.org, Dec 5 2017

Components: -UI>Browser>Previews
Status: WontFix (was: Assigned)
The flakiness seems to be some Features initialization flakiness problem
and not related to the logic under test. Not going to pursue further here.
 Issue 837822  has been merged into this issue.
Project Member

Comment 11 by bugdroid1@chromium.org, Jul 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a875a2ea21d8a321295a11440c80af01bcf7fa86

commit a875a2ea21d8a321295a11440c80af01bcf7fa86
Author: Tarun Bansal <tbansal@chromium.org>
Date: Thu Jul 12 17:14:30 2018

Deflake resource loading hints and previews browsertest

Attempt to deflake resource loading hints and previews
browsertest by waiting for hints to be processed.

Currently, the hints are processed on the background thread,
and so may not be processed immediately.

Log from the failed Linux test bots seem to indicate that
the hints are not processed in time.
See http://shortn/_IjBGHDP2Rp

Bug:  789542 , 831838 
Change-Id: I6b30b1a86dc5d2cdef1cd8274cf5c6088bec8634
Reviewed-on: https://chromium-review.googlesource.com/1134598
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574613}
[modify] https://crrev.com/a875a2ea21d8a321295a11440c80af01bcf7fa86/chrome/browser/previews/previews_browsertest.cc
[modify] https://crrev.com/a875a2ea21d8a321295a11440c80af01bcf7fa86/chrome/browser/previews/resource_loading_hints/resource_loading_hints_browsertest.cc

Sign in to add a comment