"org.chromium.chrome.browser.payments.PaymentRequestServiceWorkerPaymentAppTest#testCallCanMakePayment" is flaky |
|||||
Issue description"org.chromium.chrome.browser.payments.PaymentRequestServiceWorkerPaymentAppTest#testCallCanMakePayment" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNycAsSBUZsYWtlImVvcmcuY2hyb21pdW0uY2hyb21lLmJyb3dzZXIucGF5bWVudHMuUGF5bWVudFJlcXVlc3RTZXJ2aWNlV29ya2VyUGF5bWVudEFwcFRlc3QjdGVzdENhbGxDYW5NYWtlUGF5bWVudAw. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Nov 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/70baccadfc23bd160016f46f62463ebdced89b2d commit 70baccadfc23bd160016f46f62463ebdced89b2d Author: Henrik Boström <hbos@chromium.org> Date: Wed Nov 29 13:51:02 2017 Disabled flaky testCallCanMakePayment() In PaymentRequestServiceWorkerPaymentAppTest.java. It's flaky, see bug. TBR=rouslan@chromium.org,mathp@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 789532 Change-Id: I62d087abd95c37fd32fdef123c2d4bf847d2e4ac Reviewed-on: https://chromium-review.googlesource.com/796417 Reviewed-by: Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#520097} [modify] https://crrev.com/70baccadfc23bd160016f46f62463ebdced89b2d/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestServiceWorkerPaymentAppTest.java
,
Nov 29 2017
With test disabled, removing issue from sheriff's queue.
,
Nov 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6a3412f5b8b954e96e6a8b1d4df2a279d63c6754 commit 6a3412f5b8b954e96e6a8b1d4df2a279d63c6754 Author: Boris Sazonov <bsazonov@chromium.org> Date: Wed Nov 29 14:32:48 2017 Revert "Disabled flaky testCallCanMakePayment()" This reverts commit 70baccadfc23bd160016f46f62463ebdced89b2d. Reason for revert: broke build (https://build.chromium.org/p/chromium.android/builders/Android%20x64%20Builder%20%28dbg%29/builds/24483) Original change's description: > Disabled flaky testCallCanMakePayment() > > In PaymentRequestServiceWorkerPaymentAppTest.java. > It's flaky, see bug. > > TBR=rouslan@chromium.org,mathp@chromium.org > > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 789532 > Change-Id: I62d087abd95c37fd32fdef123c2d4bf847d2e4ac > Reviewed-on: https://chromium-review.googlesource.com/796417 > Reviewed-by: Henrik Boström <hbos@chromium.org> > Commit-Queue: Henrik Boström <hbos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#520097} TBR=rouslan@chromium.org,mathp@chromium.org,hbos@chromium.org,gogerald@chromium.org Change-Id: Ia5866ee50f2099ba28134c09cbecf59374c669f6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 789532 Reviewed-on: https://chromium-review.googlesource.com/796730 Reviewed-by: Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#520104} [modify] https://crrev.com/6a3412f5b8b954e96e6a8b1d4df2a279d63c6754/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestServiceWorkerPaymentAppTest.java
,
Nov 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bafeb14b148f5f48af3212d5592f72809f0144e2 commit bafeb14b148f5f48af3212d5592f72809f0144e2 Author: Henrik Boström <hbos@chromium.org> Date: Wed Nov 29 14:34:15 2017 Revert "Disabled flaky testCallCanMakePayment()" This reverts commit 70baccadfc23bd160016f46f62463ebdced89b2d. Reason for revert: <INSERT REASONING HERE> Original change's description: > Disabled flaky testCallCanMakePayment() > > In PaymentRequestServiceWorkerPaymentAppTest.java. > It's flaky, see bug. > > TBR=rouslan@chromium.org,mathp@chromium.org > > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 789532 > Change-Id: I62d087abd95c37fd32fdef123c2d4bf847d2e4ac > Reviewed-on: https://chromium-review.googlesource.com/796417 > Reviewed-by: Henrik Boström <hbos@chromium.org> > Commit-Queue: Henrik Boström <hbos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#520097} TBR=rouslan@chromium.org,mathp@chromium.org,hbos@chromium.org,gogerald@chromium.org Change-Id: I7af4826ee276aa7e3a508a5d30dbb4495d86b332 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 789532 Reviewed-on: https://chromium-review.googlesource.com/796731 Reviewed-by: Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#520105}
,
Nov 29 2017
Oops forgot to import org.chromium.base.test.util.DisabledTest; Re-trying.
,
Nov 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/afbc84cbc66aeaa66bd79eba98dde95fb92f90f3 commit afbc84cbc66aeaa66bd79eba98dde95fb92f90f3 Author: Henrik Boström <hbos@chromium.org> Date: Wed Nov 29 14:44:34 2017 Disabled flaky testCallCanMakePayment() (attempt #2) TBR=rouslan@chromium.org,mathp@chromium.org,hbos@chromium.org,gogerald@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 789532 Change-Id: I7a9bddb93565d68e51b7846b2eb20878387ebf39 Reviewed-on: https://chromium-review.googlesource.com/796770 Reviewed-by: Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#520107} [modify] https://crrev.com/afbc84cbc66aeaa66bd79eba98dde95fb92f90f3/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestServiceWorkerPaymentAppTest.java
,
Nov 29 2017
,
Nov 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/068404995166ff4bb41c9b5430ed096b5dd53f62 commit 068404995166ff4bb41c9b5430ed096b5dd53f62 Author: Matthew Jones <mdjones@chromium.org> Date: Wed Nov 29 17:07:08 2017 Revert "Disabled flaky testCallCanMakePayment()" This reverts commit 70baccadfc23bd160016f46f62463ebdced89b2d. Reason for revert: Missing import causes compile failure. Original change's description: > Disabled flaky testCallCanMakePayment() > > In PaymentRequestServiceWorkerPaymentAppTest.java. > It's flaky, see bug. > > TBR=rouslan@chromium.org,mathp@chromium.org > > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 789532 > Change-Id: I62d087abd95c37fd32fdef123c2d4bf847d2e4ac > Reviewed-on: https://chromium-review.googlesource.com/796417 > Reviewed-by: Henrik Boström <hbos@chromium.org> > Commit-Queue: Henrik Boström <hbos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#520097} TBR=rouslan@chromium.org,mathp@chromium.org,hbos@chromium.org,gogerald@chromium.org Change-Id: I496a3e9099f1a89a2356b035f9fc24873f963295 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 789532 Reviewed-on: https://chromium-review.googlesource.com/797170 Reviewed-by: Matthew Jones <mdjones@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#520147} [modify] https://crrev.com/068404995166ff4bb41c9b5430ed096b5dd53f62/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestServiceWorkerPaymentAppTest.java
,
Dec 1 2017
Detected 7 new flakes for test/step "org.chromium.chrome.browser.payments.PaymentRequestServiceWorkerPaymentAppTest#testCallCanMakePayment". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNycAsSBUZsYWtlImVvcmcuY2hyb21pdW0uY2hyb21lLmJyb3dzZXIucGF5bWVudHMuUGF5bWVudFJlcXVlc3RTZXJ2aWNlV29ya2VyUGF5bWVudEFwcFRlc3QjdGVzdENhbGxDYW5NYWtlUGF5bWVudAw. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
,
Dec 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b01d414f98d219c7777c2ece9db528f09197ee94 commit b01d414f98d219c7777c2ece9db528f09197ee94 Author: gogerald <gogerald@google.com> Date: Fri Dec 01 16:12:01 2017 [Payments] Make sure callbacks invoked on UI thread. Bug: 789532 Change-Id: Iad9ed5998dd245df7c8def83cc3123f960a8fdc7 Reviewed-on: https://chromium-review.googlesource.com/802734 Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#520950} [modify] https://crrev.com/b01d414f98d219c7777c2ece9db528f09197ee94/chrome/android/java/src/org/chromium/chrome/browser/payments/ServiceWorkerPaymentAppBridge.java [modify] https://crrev.com/b01d414f98d219c7777c2ece9db528f09197ee94/content/browser/payments/payment_app_provider_impl.cc
,
Dec 1 2017
Land a CL to fix a bug in product code, hopefully fix this flaky test, will close this bug if it is not happen again,
,
Dec 5 2017
Do not see additional failure after the fix, |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by hbos@chromium.org
, Nov 29 2017Components: UI>Browser>Payments
Owner: gogerald@chromium.org
Status: Assigned (was: Untriaged)