New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 789520 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue webrtc:8589
Owner: ----
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Can't include webrtc and libyuv headers in the same compilation unit (FOURCC)

Project Member Reported by brat...@opera.com, Nov 29 2017

Issue description

#include "third_party/webrtc/media/base/videocommon.h"
#include "third_party/libyuv/include/libyuv.h"

->

../../third_party/libyuv/include/libyuv/video_common.h:31:9: error: 'FOURCC' macro redefined [-Werror,-Wmacro-redefined]
#define FOURCC(a, b, c, d)                                    \
        ^
../../third_party/webrtc/media/base/videocommon.h:42:9: note: previous definition is here
#define FOURCC(a, b, c, d)                                        \
        ^
1 error generated.


-----

It would be good if webrtc headers don't leak their internal macros. And the same for libyuv. Short term this is a problem for jumbo compilations where this actually happens inside //content (not landed yet since it doesn't compile).
 

Comment 1 by brat...@opera.com, Nov 29 2017

Summary: Can't include webrtc and libyuv headers in the same compilation unit (FOURCC) (was: Can't include webrtc and libyuv headers in the same compilation unit)
Mergedinto: webrtc:8589
Status: Duplicate (was: Untriaged)
Let's move this one to the WebRTC bug tracker.

Sign in to add a comment