Issue metadata
Sign in to add a comment
|
"GenericSensorBrowserTest.AmbientLightSensorTest" is flaky |
||||||||||||||||||||||
Issue description"GenericSensorBrowserTest.AmbientLightSensorTest" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyOgsSBUZsYWtlIi9HZW5lcmljU2Vuc29yQnJvd3NlclRlc3QuQW1iaWVudExpZ2h0U2Vuc29yVGVzdAw. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Nov 30 2017
looks like a lot more than 3 flakes. in last CQ run the bot failed because each retry timed out: https://ci.chromium.org/buildbot/tryserver.chromium.linux/linux_chromium_asan_rel_ng/501894 Adding sheriffs.
,
Dec 1 2017
,
Dec 1 2017
Change is in the CQ to disable this flaky test. Adding a few more people cc to fix it. https://crrev.com/c/803855
,
Dec 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e3e7c9ca64f9cd6a684586c6b1e5589fc07891d8 commit e3e7c9ca64f9cd6a684586c6b1e5589fc07891d8 Author: Avi Drissman <avi@chromium.org> Date: Fri Dec 01 19:58:44 2017 Disable flaky test. BUG= 789515 TBR=alexis.menard@intel.com Change-Id: Ic5ad0bc6247ec7548887962f6d204b63da150fc6 Reviewed-on: https://chromium-review.googlesource.com/803855 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#521024} [modify] https://crrev.com/e3e7c9ca64f9cd6a684586c6b1e5589fc07891d8/content/browser/generic_sensor_browsertest.cc
,
Jun 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aa03d3a04070f6a5549ac47e43c189c994b4ea63 commit aa03d3a04070f6a5549ac47e43c189c994b4ea63 Author: Reilly Grant <reillyg@chromium.org> Date: Mon Jun 18 21:32:28 2018 Read initial sensor reading from shared memory on initialization A sensor's initial reading is checked to see if an event should be fired immediately after it is activated. Unfortunately this initial reading was not actually read from shared memory. Depending on timing the reading might be refreshed by the polling timer or upon receiving a SensorReadingChanged message. This patch updates the code to take this initial reading on initialization so that we can reliably decide whether to send an initial reading event. Bug: 789515 , 809537 Change-Id: I96f441aad3ec474ef94fd634aa34bf9b29b9edf9 Reviewed-on: https://chromium-review.googlesource.com/1103178 Reviewed-by: Jun Cai <juncai@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#568169} [modify] https://crrev.com/aa03d3a04070f6a5549ac47e43c189c994b4ea63/content/browser/generic_sensor/generic_sensor_browsertest.cc [modify] https://crrev.com/aa03d3a04070f6a5549ac47e43c189c994b4ea63/content/test/data/generic_sensor/ambient_light_sensor_test.html [modify] https://crrev.com/aa03d3a04070f6a5549ac47e43c189c994b4ea63/third_party/blink/renderer/modules/sensor/sensor_proxy_impl.cc
,
Jun 18 2018
I believe this flakiness has been fixed. Setting next action for 2 days from now to double-check on the flakiness dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=content_browsertests&tests=GenericSensorBrowserTest.AmbientLightSensorTest
,
Jun 20 2018
The NextAction date has arrived: 2018-06-20
,
Jun 20 2018
Verified no more flakiness appearing on the dashboard. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by henrika@chromium.org
, Nov 30 2017Owner: alexis.m...@intel.com
Status: Assigned (was: Untriaged)