New issue
Advanced search Search tips

Issue 789506 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 591981
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Omnibox history provider does not return urls with midterm matches

Project Member Reported by a-...@yandex-team.ru, Nov 29 2017

Issue description

Google Chrome	64.0.3279.0 (Официальная сборка) canary (64 бит)
Версия	bafc2ba3b2d740a656e19a2f7473ea7922530a6f-refs/heads/master@{#519518}
ОС	Mac OS X

What steps will reproduce the problem?
(1)Visit some page, for example http://example.com several times
(2)Go to chrome://omnibox/, check "Show results per provider, not just merged results" and "Show incomplete results" checkboxes
(3)enter "xample" or "ample" in input field and press "Send"

What is the expected result?
Where are results from HistoryQuickProvider with "example.com" URL

What happens instead?
No results present

This is regression from previous(2 years old) Chrome behaviour. I was able to bisect this change to range
https://chromium.googlesource.com/chromium/src/+log/1edeeb2849552e8d06a782836bb4d6d0cafd5d9d..e3cfb233f6d7689d96fdb52a87caa3ada346666d

I think culprit is https://codereview.chromium.org/1286093006 which also changed one of tests with comment "found because we suppress mid-term matches."

I think midterm results are sometimes usefull and we have several complains from our users not finding results from history. 
Also HistoryQuickProvider component is architected with this feature in mind, so now its complexity is somehow redundant.

Is this change intentional and well thought?
 
Status: Assigned (was: Untriaged)
Mergedinto: 591981
Status: Duplicate (was: Assigned)

Sign in to add a comment