desktop-pwas: Investigate reducing code duplication in BookmarkAppNavigationThrottleExperimentalBrowserTest |
||
Issue descriptionBookmarkAppNavigationThrottleBrowserTests has many methods that follow the same pattern: 1. Get current state of browser windows and tabs 2. Perform an action 3. Check that the new state matches the expected state. Step 1. is very similar on all these methods and could possibly be abstracted.
,
Jun 20 2018
Yup. It got split to support running tests with link capturing enabled and disabled. All the tests are in: https://cs.chromium.org/chromium/src/chrome/browser/extensions/bookmark_app_navigation_throttle_browsertest.cc
,
Jun 20 2018
I refactored this class into https://cs.chromium.org/chromium/src/chrome/browser/extensions/bookmark_app_navigation_browsertest.h?q=chrome/browser/extensions/bookmark_app_navigation_browsertest.h&sq=package:chromium&dr. I think the reducing duplication is still available though since I just pulled out common code to reuse the test helper elsewhere.
,
Jun 20 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by alancutter@chromium.org
, Jun 20 2018