New issue
Advanced search Search tips

Issue 789445 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue gerrit:6455
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

can't remove CQ+2 as reviewer

Project Member Reported by jochen@chromium.org, Nov 29 2017

Issue description

when somebody hits the CQ+2 button, there's no (obvious?) way for a reviewer to cancel the commit queue.
 

Comment 1 by aga...@chromium.org, Nov 29 2017

Status: Fixed (was: Untriaged)
You can click the X on that other person's "Code-Review [+1 Their Name (X)]" label in the metadata section.

Comment 2 by jochen@chromium.org, Nov 30 2017

Owner: aga...@chromium.org
Status: Assigned (was: Fixed)
the X only shows up for my own votes, not for others

Comment 3 by aga...@chromium.org, Nov 30 2017

All logged-in public users should be granted the ability to set other people's CQ vote to zero: https://chromium.googlesource.com/chromium/src/+/refs/meta/config/project.config#22

I also verified that vmpstr@ (another chrome committer with no other special powers) was able to remove my CQ vote from one of his changes.

However, my @gmail account doesn't seem to have the ability to remove other people's CQ votes, so something is wrong. Investigating further.

Can you provide a link to a CL where you ran into this?

Comment 4 by jochen@chromium.org, Nov 30 2017

e.g. https://chromium-review.googlesource.com/c/chromium/src/+/800619 (screenshot attached)
gerrit.png
385 KB View Download

Comment 5 by aga...@chromium.org, Nov 30 2017

Mergedinto: gerrit:6455
Status: Duplicate (was: Assigned)
Oh, I see what's going on here. For some reason I thought that gerrit:6455 had been fixed, and this was something else. Unfortunately, this is a big underlying issue in Gerrit. I'm talking to them now about the fastest way to get gerrit:6455 fixed.

Sign in to add a comment