New issue
Advanced search Search tips

Issue 789408 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

[Missing Test]: [Print Preview]: Componetize UI codebase

Project Member Reported by pnangunoori@chromium.org, Nov 29 2017

Issue description

Automated tests for the below commit have been missing. Please add test coverage ASAP to avoid regressions in future.

CL: 
----
https://chromium.googlesource.com/chromium/src/+/9de2607e09cc5491b30418c0eb1d6abf88b34d5d

Ref Bug: 
---------
https://bugs.chromium.org/p/chromium/issues/detail?id=773928

Thank you...!!
 

Comment 1 by dpa...@chromium.org, Nov 29 2017

Cc: rbpotter@chromium.org
>  Please add test coverage ASAP to avoid regressions in future

@pnangunoori: Can you explain the ASAP nature of this request?

The feature is being in early development, and disabled by default on all channels. Tests are planned to be added as soon as the design is stable enough.
@dpapad - Apologies for the wording. It is the default template which we follow if we notice the Fixes without any unit test cases.

Thanks.
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b47ce9e77e47653a1b61db4e171f3d4516c0fa80

commit b47ce9e77e47653a1b61db4e171f3d4516c0fa80
Author: rbpotter <rbpotter@chromium.org>
Date: Fri Dec 01 02:43:04 2017

Print Preview Componentization: Add tests for more sections

Bug: 773928,  789408 
Change-Id: I66009509ad601756ec0281a66fd093ee7fc96477
Reviewed-on: https://chromium-review.googlesource.com/802175
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520815}
[modify] https://crrev.com/b47ce9e77e47653a1b61db4e171f3d4516c0fa80/chrome/test/data/webui/print_preview/new_print_preview_ui_browsertest.js
[modify] https://crrev.com/b47ce9e77e47653a1b61db4e171f3d4516c0fa80/chrome/test/data/webui/print_preview/settings_section_test.js

Cc: -rbpotter@chromium.org dpa...@chromium.org
Owner: rbpotter@chromium.org
Status: Fixed (was: Assigned)
I am closing this issue. Tests are being added as part of addressing isssue 773928. There is no need for a separate bug.

Sign in to add a comment