New issue
Advanced search Search tips

Issue 789405 link

Starred by 2 users
Status: Fixed
Owner:
thomasanderson@chromium.org
Closed: Dec 2017
Cc:
thomasanderson@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Native (ClientSide) Decoration dont respect dconf option set for double-click action

Reported by plusf...@gmail.com, Nov 29 2017 
UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3202.94 Safari/537.36

Steps to reproduce the problem:
1. Set dconf "/org/gnome/desktop/wm/preferences/action-double-click-titlebar" to "minimize"
2. start Chromium
3. double-click on titlebar

What is the expected behavior?
It should now minimize itsels

What went wrong?
it still maximizes itself

Did this work before? No 

Chrome version: 62.0.3202.94  Channel: stable
OS Version: Manjaro
Flash Version: 

While Chromium respects all other dconf settings i know about, this one seems to be broken.

Comment 1 by manoranj...@chromium.org, Nov 29 2017

Cc: thomasanderson@chromium.org
Labels: Needs-Triage-M62

Comment 2 by thomasanderson@chromium.org, Nov 29 2017

Owner: thomasanderson@chromium.org
Status: Assigned (was: Unconfirmed)

Comment 3 by thomasanderson@chromium.org, Dec 5 2017

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ada8cbd4218118a10e79d2a42ffd80870f7f1d3

commit 3ada8cbd4218118a10e79d2a42ffd80870f7f1d3
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Tue Dec 12 06:12:30 2017

Respect GTK settings when double-clicking or right-clicking the titlebar

BUG= 789405 
R=erg@chromium.org,sky@chromium.org

Change-Id: I9b313c1027cd5ac69ed1b3545f909b60a648b148
Reviewed-on: https://chromium-review.googlesource.com/803666
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Elliot Glaysher <erg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523354}
[modify] https://crrev.com/3ada8cbd4218118a10e79d2a42ffd80870f7f1d3/chrome/browser/ui/libgtkui/BUILD.gn
[modify] https://crrev.com/3ada8cbd4218118a10e79d2a42ffd80870f7f1d3/chrome/browser/ui/libgtkui/gtk_ui.cc
[modify] https://crrev.com/3ada8cbd4218118a10e79d2a42ffd80870f7f1d3/chrome/browser/ui/libgtkui/gtk_ui.h
[delete] https://crrev.com/696ce2f4da2a0142e06ae76b4fe317af0446d5ac/chrome/browser/ui/libgtkui/nav_button_layout_manager.h
[delete] https://crrev.com/696ce2f4da2a0142e06ae76b4fe317af0446d5ac/chrome/browser/ui/libgtkui/nav_button_layout_manager_gtk3.cc
[delete] https://crrev.com/696ce2f4da2a0142e06ae76b4fe317af0446d5ac/chrome/browser/ui/libgtkui/nav_button_layout_manager_gtk3.h
[add] https://crrev.com/3ada8cbd4218118a10e79d2a42ffd80870f7f1d3/chrome/browser/ui/libgtkui/settings_provider.h
[add] https://crrev.com/3ada8cbd4218118a10e79d2a42ffd80870f7f1d3/chrome/browser/ui/libgtkui/settings_provider_gconf.cc
[add] https://crrev.com/3ada8cbd4218118a10e79d2a42ffd80870f7f1d3/chrome/browser/ui/libgtkui/settings_provider_gconf.h
[rename] https://crrev.com/3ada8cbd4218118a10e79d2a42ffd80870f7f1d3/chrome/browser/ui/libgtkui/settings_provider_gsettings.cc
[rename] https://crrev.com/3ada8cbd4218118a10e79d2a42ffd80870f7f1d3/chrome/browser/ui/libgtkui/settings_provider_gsettings.h
[add] https://crrev.com/3ada8cbd4218118a10e79d2a42ffd80870f7f1d3/chrome/browser/ui/libgtkui/settings_provider_gtk3.cc
[add] https://crrev.com/3ada8cbd4218118a10e79d2a42ffd80870f7f1d3/chrome/browser/ui/libgtkui/settings_provider_gtk3.h
[modify] https://crrev.com/3ada8cbd4218118a10e79d2a42ffd80870f7f1d3/ui/views/linux_ui/linux_ui.h
[modify] https://crrev.com/3ada8cbd4218118a10e79d2a42ffd80870f7f1d3/ui/views/widget/desktop_aura/window_event_filter.cc

Comment 5 by thomasanderson@chromium.org, Dec 12 2017

Status: Fixed (was: Started)
►

Sign in to add a comment