New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 789397 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Skip install banner prompt for desktop PWAs

Project Member Reported by mcgreevy@chromium.org, Nov 29 2017

Issue description

The current install flow for PWAs (when beforeinstallprompt.preventDefault()) has been called is:

1. user clicks on some UI in the web page, triggering a call to beforeinstallprompt.prompt().
2. we show the app install banner, which the user must click to accept
3. we show the app install dialog, which contains no editable fields, and the user must click to accept.

We don't need two confirmation mechanisms (#2 & #3), and the install banner is also redundant with respect the the UI element in #1.  So we should remove #2 (the app install banner).

We will still show the banner when the beforeinstallprompt.preventDefault() is not called.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c233b32519c34fe253cd3b8153398c8f7155416

commit 3c233b32519c34fe253cd3b8153398c8f7155416
Author: Michael McGreevy <mcgreevy@chromium.org>
Date: Thu Nov 30 04:02:59 2017

Skip app install banner for manually-triggered PWA installs.

When beforeinstallprompt.preventDefault() is called and the web developer
supplies their own UI for triggering an app install, the banner is redundant.
This CL skips the banner in this case.

Bug:  789397 
Change-Id: Ia8920f9b65b1086fb12fc45f4f87b1ded90f4e98
Reviewed-on: https://chromium-review.googlesource.com/795412
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Michael McGreevy <mcgreevy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520428}
[modify] https://crrev.com/3c233b32519c34fe253cd3b8153398c8f7155416/chrome/browser/banners/app_banner_manager_desktop.cc
[modify] https://crrev.com/3c233b32519c34fe253cd3b8153398c8f7155416/chrome/browser/installable/installable_logging.cc
[modify] https://crrev.com/3c233b32519c34fe253cd3b8153398c8f7155416/chrome/browser/installable/installable_logging.h
[modify] https://crrev.com/3c233b32519c34fe253cd3b8153398c8f7155416/tools/metrics/histograms/enums.xml

Comment 2 by mcgreevy@google.com, Nov 30 2017

Status: Fixed (was: Assigned)

Sign in to add a comment