New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 789384 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Redispatch beforeinstallprompt event on installation cancellation or failure.

Project Member Reported by mcgreevy@chromium.org, Nov 29 2017

Issue description

The AppBannerManager flow currently terminates when the user dismisses the install dialog.  Instead, beforeinstallprompt should be redispatched so that the user can retry the installation.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/842166c48c6bf7b914418cb997ff14872e540331

commit 842166c48c6bf7b914418cb997ff14872e540331
Author: Michael McGreevy <mcgreevy@chromium.org>
Date: Thu Nov 30 00:03:04 2017

Redispatch beforeinstallprompt event on installation cancellation or failure.

This resends the beforeinstallprompt event when kExperimentalAppBanners is
enabled, and:
  * the install dialog is cancelled, or
  * the app fails to install.

When kExperimentalAppBanners is enabled, we currently reprompt when the install
banner is dismissed. However, a subsequent CL will skip the install banner and
launch the confirmation dialog directly, so dismissal of the install banner is
not the appropriate juncture to reprompt.

Bug:  789384 
Change-Id: I681af00e56a946272414841da06767b6e9878dab
Reviewed-on: https://chromium-review.googlesource.com/784652
Commit-Queue: Michael McGreevy <mcgreevy@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520313}
[modify] https://crrev.com/842166c48c6bf7b914418cb997ff14872e540331/chrome/browser/banners/app_banner_manager.cc
[modify] https://crrev.com/842166c48c6bf7b914418cb997ff14872e540331/chrome/browser/banners/app_banner_manager_desktop.cc

Status: Fixed (was: Untriaged)

Sign in to add a comment